Re: [HACKERS] should xlog_outdesc modify its argument?

2016-09-28 Thread Mark Dilger
> On Sep 27, 2016, at 11:25 PM, Heikki Linnakangas wrote: > > On 09/28/2016 02:35 AM, Mark Dilger wrote: >> The function >> >> static void xlog_outdesc(StringInfo buf, XLogReaderState *record); >> >> in src/backend/access/transam/xlog.c is called by XLogInsertRecord, >> and

Re: [HACKERS] should xlog_outdesc modify its argument?

2016-09-28 Thread Heikki Linnakangas
On 09/28/2016 02:35 AM, Mark Dilger wrote: The function static void xlog_outdesc(StringInfo buf, XLogReaderState *record); in src/backend/access/transam/xlog.c is called by XLogInsertRecord, and after returning a string describing an XLogRecord, it clears the state data in its

[HACKERS] should xlog_outdesc modify its argument?

2016-09-27 Thread Mark Dilger
The function static void xlog_outdesc(StringInfo buf, XLogReaderState *record); in src/backend/access/transam/xlog.c is called by XLogInsertRecord, and after returning a string describing an XLogRecord, it clears the state data in its XLogReaderState argument. That mixes the read-only