Re: [HACKERS] small typo in src/backend/access/transam/xlog.c

2014-04-26 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: On Mon, Jul 22, 2013 at 07:32:20PM -0400, Tom Lane wrote: We could for instance keep the high half as tv_sec, while making the low half be something like (tv_usec 12) | (getpid() 0xfff). This would restore the intended ability to reverse-engineer the

Re: [HACKERS] small typo in src/backend/access/transam/xlog.c

2014-01-31 Thread Bruce Momjian
On Mon, Jul 22, 2013 at 07:32:20PM -0400, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: On 2013-07-22 15:55:46 -0400, Robert Haas wrote: And why is that? The comment above tells: while the lower half is the XOR of tv_sec and tv_usec. Yeah, the code doesn't match the

[HACKERS] small typo in src/backend/access/transam/xlog.c

2013-07-22 Thread didier
Hi in void BootStrapXLOG(void) * to seed it other than the system clock value...) The upper half of the * uint64 value is just the tv_sec part, while the lower half is the XOR * of tv_sec and tv_usec. This is to ensure that we don't lose uniqueness *

Re: [HACKERS] small typo in src/backend/access/transam/xlog.c

2013-07-22 Thread Robert Haas
On Mon, Jul 22, 2013 at 6:45 AM, didier did...@gmail.com wrote: Hi in void BootStrapXLOG(void) * to seed it other than the system clock value...) The upper half of the * uint64 value is just the tv_sec part, while the lower half is the XOR * of tv_sec and

Re: [HACKERS] small typo in src/backend/access/transam/xlog.c

2013-07-22 Thread Andres Freund
On 2013-07-22 15:55:46 -0400, Robert Haas wrote: On Mon, Jul 22, 2013 at 6:45 AM, didier did...@gmail.com wrote: Hi in void BootStrapXLOG(void) * to seed it other than the system clock value...) The upper half of the * uint64 value is just the tv_sec part, while

Re: [HACKERS] small typo in src/backend/access/transam/xlog.c

2013-07-22 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: On 2013-07-22 15:55:46 -0400, Robert Haas wrote: And why is that? The comment above tells: while the lower half is the XOR of tv_sec and tv_usec. Yeah, the code doesn't match the comment; this mistake seems to be aboriginal. I don't think it