Excerpts from Alvaro Herrera's message of mié ago 29 15:13:11 -0400 2012:
> Excerpts from Andres Freund's message of mié ago 29 12:10:17 -0400 2012:
>
> > > OK, scratch that thought then. So we seem to be down to choosing a new
> > > name for what we're going to take out of htup.h. If you don't
On Wednesday, August 29, 2012 05:47:14 PM Tom Lane wrote:
> Alvaro Herrera writes:
> > Excerpts from Tom Lane's message of mar ago 28 17:27:51 -0400 2012:
> >> Also, is there any reason to consider just moving those defs into
> >> heapam.h, instead of inventing a new header? I'm not sure if there
Alvaro Herrera writes:
> ... we already have catalog/heap.h, so that would be one reason to avoid
> that name.
Yeah, good point. We do have some duplicate file names elsewhere, but
it's not a terribly good practice.
regards, tom lane
--
Sent via pgsql-hackers mailing
Alvaro Herrera writes:
> Excerpts from Tom Lane's message of mar ago 28 17:27:51 -0400 2012:
>> Also, is there any reason to consider just moving those defs into
>> heapam.h, instead of inventing a new header? I'm not sure if there's
>> any principled distinction between heap.h and heapam.h, or a
Excerpts from Alvaro Herrera's message of mié ago 29 11:32:04 -0400 2012:
> Excerpts from Tom Lane's message of mar ago 28 17:27:51 -0400 2012:
> > This should
> > reduce the number of changes needed, not only in our code but third
> > party code. Not sure if the new file could sanely be called
>
Excerpts from Tom Lane's message of mar ago 28 17:27:51 -0400 2012:
> Alvaro Herrera writes:
> > This patch is mainly doing four things:
>
> > 1. take some typedefs and the HeapTupleData struct definition from
> > access/htup.h, and put them in access/tupbasics.h. This new file is
> > used as #i
... btw, the buildfarm says you forgot contrib/ while fixing the
collateral damage from these changes.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-h
Alvaro Herrera writes:
> This patch is mainly doing four things:
> 1. take some typedefs and the HeapTupleData struct definition from
> access/htup.h, and put them in access/tupbasics.h. This new file is
> used as #include in all headers instead of htup.h.
> I'm unsure about the "tupbasics.h" f
Alvaro Herrera writes:
> This patch splits htup.h in two pieces -- the first one (tupbasics.h;
> not wedded to the name) does not include many other headers and is just
> enough to have other parts of the code create tuples and pass them
> around, to be used by most other headers. The other one (
Hi,
This patch splits htup.h in two pieces -- the first one (tupbasics.h;
not wedded to the name) does not include many other headers and is just
enough to have other parts of the code create tuples and pass them
around, to be used by most other headers. The other one (which keeps
the name htup.h
10 matches
Mail list logo
