Alvaro Herrera writes:
> Pushed, with some further minor changes. One not-so-minor change I
Thanks a lot for all the work you did put into this patch!
> introduced was that pg_event_trigger_dropped_objects() now only works
> within a sql_drop event function. The reason I decided to do this was
Pushed, with some further minor changes. One not-so-minor change I
introduced was that pg_event_trigger_dropped_objects() now only works
within a sql_drop event function. The reason I decided to do this was
that if we don't have that protection, then it is possible to have a
ddl_command_end trigg
Robert Haas escribió:
> On Tue, Mar 26, 2013 at 3:02 PM, Alvaro Herrera
> wrote:
> > Now there *is* one rather big performance problem in this patch, which
> > is that it turns on collection of object dropped data regardless of
> > there being event triggers that use the info at all. That's a se
On Tue, Mar 26, 2013 at 3:02 PM, Alvaro Herrera
wrote:
> I tried this and it doesn't work. The "error pathways" you speak about
> would be the xact.c entry points to commit and abort transactions;
> however, there's a problem with that because some of the commands that
> ProcessUtility() deals wi
Tom Lane escribió:
> Alvaro Herrera writes:
> > Now there *is* one rather big performance problem in this patch, which
> > is that it turns on collection of object dropped data regardless of
> > there being event triggers that use the info at all. That's a serious
> > drawback and we're going to
Alvaro Herrera writes:
> Now there *is* one rather big performance problem in this patch, which
> is that it turns on collection of object dropped data regardless of
> there being event triggers that use the info at all. That's a serious
> drawback and we're going to get complaints about it. So
Robert Haas escribió:
> On Wed, Mar 20, 2013 at 5:42 PM, Alvaro Herrera
> wrote:
> > Here's a new version of this patch, rebased on top of the new
> > pg_identify_object() stuff. Note that the regression test doesn't work
> > yet, because I didn't adjust to the new identity output definition (the
On Wed, Mar 20, 2013 at 5:42 PM, Alvaro Herrera
wrote:
> Here's a new version of this patch, rebased on top of the new
> pg_identify_object() stuff. Note that the regression test doesn't work
> yet, because I didn't adjust to the new identity output definition (the
> docs need work, too). But th
Here's a new version of this patch, rebased on top of the new
pg_identify_object() stuff. Note that the regression test doesn't work
yet, because I didn't adjust to the new identity output definition (the
docs need work, too). But that's a simple change to do. I'm leaving
that for later.
--
Ál
Robert Haas escribió:
> On Fri, Mar 8, 2013 at 9:18 AM, Alvaro Herrera
> wrote:
> > Robert Haas escribió:
> >> On Tue, Mar 5, 2013 at 12:45 PM, Alvaro Herrera
> >> wrote:
> >> > Hmm, maybe I should be considering a pair of macros instead --
> >> > UTILITY_START_DROP and UTILITY_END_DROP. I'll g
On Fri, Mar 8, 2013 at 9:18 AM, Alvaro Herrera wrote:
> Robert Haas escribió:
>> On Tue, Mar 5, 2013 at 12:45 PM, Alvaro Herrera
>> wrote:
>> > Hmm, maybe I should be considering a pair of macros instead --
>> > UTILITY_START_DROP and UTILITY_END_DROP. I'll give this a try. Other
>> > ideas are
Robert Haas escribió:
> On Tue, Mar 5, 2013 at 12:45 PM, Alvaro Herrera
> wrote:
> > Hmm, maybe I should be considering a pair of macros instead --
> > UTILITY_START_DROP and UTILITY_END_DROP. I'll give this a try. Other
> > ideas are welcome.
>
> That seems like a possibly promising idea. I d
On Tue, Mar 5, 2013 at 12:45 PM, Alvaro Herrera
wrote:
> Hmm, maybe I should be considering a pair of macros instead --
> UTILITY_START_DROP and UTILITY_END_DROP. I'll give this a try. Other
> ideas are welcome.
That seems like a possibly promising idea. I do wonder how well any
of this is goi
> Robert Haas escribió:
> > Or at least move the save/restore logic into something inside the
> > deletion machinery itself so that new callers don't have to worry
> > about it?
I don't think that works well; precisely the point of the
initialize/finalize pair of functions is to bracket the drop
Robert Haas escribió:
> On Mon, Mar 4, 2013 at 4:59 PM, Alvaro Herrera
> wrote:
> > Alvaro Herrera escribió:
> >
> >> I think this is mostly ready to go in. I'll look at your docs, and
> >> unless there are more objections will commit later or early tomorrow.
> >
> > Actually it still needs a bi
15 matches
Mail list logo
