Re: [HACKERS] src/test/ssl broken on HEAD

2015-09-15 Thread Michael Paquier
On Tue, Sep 15, 2015 at 5:23 PM, Peter Eisentraut wrote: > The only trick, as I remember, was that clients tend to prefer SSL > automatically, which we probably don't want for Unix-domain sockets, so > we'd need to tweak those settings a bit. > > The "old patch" referred to in that old thread wasn'

Re: [HACKERS] src/test/ssl broken on HEAD

2015-09-15 Thread Peter Eisentraut
On 9/2/15 7:15 PM, Andres Freund wrote: >> Add a regression test suite for SSL support. >> >> It's not run by the global "check" or "installcheck" targets, because the >> temporary installation it creates accepts TCP connections from any user >> the same host, which is insecure. >

Re: [HACKERS] src/test/ssl broken on HEAD

2015-09-06 Thread Noah Misch
On Thu, Sep 03, 2015 at 01:15:47AM +0200, Andres Freund wrote: > On 2015-09-02 17:03:46 -0400, Robert Haas wrote: > > On Wed, Sep 2, 2015 at 4:50 PM, Andrew Dunstan wrote: > > > Tell me what's needed and I'll look at creating a buildfarm test module > > > for > > > it. > > It's not run by th

Re: [HACKERS] src/test/ssl broken on HEAD

2015-09-02 Thread Michael Paquier
On Thu, Sep 3, 2015 at 5:22 AM, Robert Haas wrote: > Still, that's not a reason not commit this, so done. Thanks. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] src/test/ssl broken on HEAD

2015-09-02 Thread Andres Freund
On 2015-09-02 17:03:46 -0400, Robert Haas wrote: > On Wed, Sep 2, 2015 at 4:50 PM, Andrew Dunstan wrote: > > Tell me what's needed and I'll look at creating a buildfarm test module for > > it. > > You run the tests via: make -C src/test/ssl check > > But nota bene security caveats: > > commit e

Re: [HACKERS] src/test/ssl broken on HEAD

2015-09-02 Thread Alvaro Herrera
Andrew Dunstan wrote: > > > On 09/02/2015 04:22 PM, Robert Haas wrote: > >For so long as this test suite is not run by 'make check-world' or by > >the buildfarm, it's likely to keep getting broken, and we're likely to > >keep not noticing. I realize that the decision to exclude this from > >'ma

Re: [HACKERS] src/test/ssl broken on HEAD

2015-09-02 Thread Robert Haas
On Wed, Sep 2, 2015 at 4:50 PM, Andrew Dunstan wrote: > Tell me what's needed and I'll look at creating a buildfarm test module for > it. You run the tests via: make -C src/test/ssl check But nota bene security caveats: commit e39250c644ea7cd3904e4e24570db21a209cf97f Author: Heikki Linnakangas

Re: [HACKERS] src/test/ssl broken on HEAD

2015-09-02 Thread Andrew Dunstan
On 09/02/2015 04:22 PM, Robert Haas wrote: On Wed, Aug 26, 2015 at 3:37 AM, Michael Paquier wrote: On Wed, Aug 26, 2015 at 4:35 PM, Michael Paquier wrote: Only HEAD is impacted, and attached is a patch to fix the problem. Actually this version is better, I forgot to update a comment. For

Re: [HACKERS] src/test/ssl broken on HEAD

2015-09-02 Thread Robert Haas
On Wed, Aug 26, 2015 at 3:37 AM, Michael Paquier wrote: > On Wed, Aug 26, 2015 at 4:35 PM, Michael Paquier > wrote: >> Only HEAD is impacted, and attached is a patch to fix the problem. > > Actually this version is better, I forgot to update a comment. For so long as this test suite is not run b

Re: [HACKERS] src/test/ssl broken on HEAD

2015-08-26 Thread Michael Paquier
On Wed, Aug 26, 2015 at 4:35 PM, Michael Paquier wrote: > Only HEAD is impacted, and attached is a patch to fix the problem. Actually this version is better, I forgot to update a comment. -- Michael diff --git a/src/test/ssl/ServerSetup.pm b/src/test/ssl/ServerSetup.pm index 8c1b517..79d948a 100

[HACKERS] src/test/ssl broken on HEAD

2015-08-26 Thread Michael Paquier
Hi all, The following commit has broken the SSL test suite (embarrassing and lonely moment): commit 13d856e177e69083f543d6383eeda9e12ce3c55c Author: Heikki Linnakangas Date: Wed Jul 29 19:17:02 2015 +0300 Make TAP tests work on Windows. [...] *Michael Paquier*, reviewed by Noah Misch, some add