Re: [HACKERS] statistics for array types

2016-03-18 Thread David Steele
On 3/9/16 7:42 PM, David Steele wrote: > On 1/18/16 11:24 AM, Alvaro Herrera wrote: >> Alexander Korotkov wrote: >> >>> The patch implementing my idea above is attached. >> What's the status here? Jeff, did you have a look at Alexander's >> version of your patch? Tomas, does this patch satisfy yo

Re: [HACKERS] statistics for array types

2016-03-09 Thread David Steele
On 1/18/16 11:24 AM, Alvaro Herrera wrote: Alexander Korotkov wrote: The patch implementing my idea above is attached. What's the status here? Jeff, did you have a look at Alexander's version of your patch? Tomas, does this patch satisfy your concerns? This was marked as "needs review" but

Re: [HACKERS] statistics for array types

2016-01-18 Thread Alvaro Herrera
Alexander Korotkov wrote: > The patch implementing my idea above is attached. What's the status here? Jeff, did you have a look at Alexander's version of your patch? Tomas, does this patch satisfy your concerns? -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Developme

Re: [HACKERS] statistics for array types

2015-12-18 Thread Alexander Korotkov
On Wed, Sep 16, 2015 at 8:01 PM, Alexander Korotkov < a.korot...@postgrespro.ru> wrote: > On Mon, Aug 24, 2015 at 8:26 PM, Jeff Janes wrote: > >> On Thu, Aug 20, 2015 at 6:00 PM, Tomas Vondra < >> tomas.von...@2ndquadrant.com> wrote: >> >>> Hi, >>> >>> On 08/11/2015 04:38 PM, Jeff Janes wrote: >>

Re: [HACKERS] statistics for array types

2015-09-16 Thread Alexander Korotkov
On Mon, Aug 24, 2015 at 8:26 PM, Jeff Janes wrote: > On Thu, Aug 20, 2015 at 6:00 PM, Tomas Vondra < > tomas.von...@2ndquadrant.com> wrote: > >> Hi, >> >> On 08/11/2015 04:38 PM, Jeff Janes wrote: >> >>> When reviewing some recent patches, I decided the statistics gathered >>> for arrays had som

Re: [HACKERS] statistics for array types

2015-09-10 Thread Alvaro Herrera
Jeff Janes wrote: > The attached patch forces there to be at least one element in MCE, keeping > the one element with the highest predicted frequency if the MCE would > otherwise be empty. Then any other element queried for is assumed to be no > more common than this most common element. Hmm, wh

Re: [HACKERS] statistics for array types

2015-08-24 Thread Jeff Janes
On Thu, Aug 20, 2015 at 6:00 PM, Tomas Vondra wrote: > Hi, > > On 08/11/2015 04:38 PM, Jeff Janes wrote: > >> When reviewing some recent patches, I decided the statistics gathered >> for arrays had some pre-existing shortcomings. >> >> The main one is that when the arrays contain rare elements t

Re: [HACKERS] statistics for array types

2015-08-20 Thread Tomas Vondra
Hi, On 08/11/2015 04:38 PM, Jeff Janes wrote: When reviewing some recent patches, I decided the statistics gathered for arrays had some pre-existing shortcomings. The main one is that when the arrays contain rare elements there is no histogram to fall back upon when the MCE array is empty, the

[HACKERS] statistics for array types

2015-08-11 Thread Jeff Janes
When reviewing some recent patches, I decided the statistics gathered for arrays had some pre-existing shortcomings. The main one is that when the arrays contain rare elements there is no histogram to fall back upon when the MCE array is empty, the way there is for scalar stats. So it has to punt