Re: [HACKERS] tab completion for setting search_path

2014-07-14 Thread Christoph Berg
Re: Andres Freund 2014-07-12 <20140712135128.gd3...@awork2.anarazel.de> > I'm also not really happy with the fact that we only complete a single > search_path item. But it's not easy to do better and when looking around > other places (e.g. DROP TABLE) don't support it either. The difference is th

Re: [HACKERS] tab completion for setting search_path

2014-07-12 Thread Andres Freund
Hi, On 2014-06-23 19:57:21 -0700, Jeff Janes wrote: > diff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c > new file mode 100644 > index be5c3c5..dcd1b7d > *** a/src/bin/psql/tab-complete.c > --- b/src/bin/psql/tab-complete.c > *** psql_completion(const char *text, i

Re: [HACKERS] tab completion for setting search_path

2014-07-07 Thread Fujii Masao
On Mon, Jul 7, 2014 at 8:51 PM, Fujii Masao wrote: > On Tue, Jun 24, 2014 at 11:57 AM, Jeff Janes wrote: >> On Mon, Jun 23, 2014 at 6:25 PM, Jeff Janes wrote: >>> On Mon, Jun 23, 2014 at 3:53 PM, Andres Freund >>> wrote: On 2014-06-23 13:10:34 -0400, Robert Haas wrote: > On Mon, Jun 23

Re: [HACKERS] tab completion for setting search_path

2014-07-07 Thread Fujii Masao
On Tue, Jun 24, 2014 at 11:57 AM, Jeff Janes wrote: > On Mon, Jun 23, 2014 at 6:25 PM, Jeff Janes wrote: >> On Mon, Jun 23, 2014 at 3:53 PM, Andres Freund >> wrote: >>> On 2014-06-23 13:10:34 -0400, Robert Haas wrote: On Mon, Jun 23, 2014 at 9:10 AM, Kevin Grittner wrote: > I wou

Re: [HACKERS] tab completion for setting search_path

2014-06-23 Thread Jeff Janes
On Mon, Jun 23, 2014 at 6:25 PM, Jeff Janes wrote: > On Mon, Jun 23, 2014 at 3:53 PM, Andres Freund > wrote: >> On 2014-06-23 13:10:34 -0400, Robert Haas wrote: >>> On Mon, Jun 23, 2014 at 9:10 AM, Kevin Grittner >>> wrote: >>> > I would be for excluding the pg_toast, pg_toast_temp_n, and >>> >

[HACKERS] tab completion for setting search_path

2014-06-23 Thread Jeff Janes
On Mon, Jun 23, 2014 at 3:53 PM, Andres Freund > wrote: > On 2014-06-23 13:10:34 -0400, Robert Haas wrote: >> On Mon, Jun 23, 2014 at 9:10 AM, Kevin Grittner > wrote: >> > I would be for excluding the pg_toast, pg_toast_temp_n, and >> > pg_temp_n schemas, and including public and pg_catalog. >> >>

Re: [HACKERS] tab completion for setting search_path

2014-06-23 Thread Andres Freund
On 2014-06-23 13:10:34 -0400, Robert Haas wrote: > On Mon, Jun 23, 2014 at 9:10 AM, Kevin Grittner wrote: > > I would be for excluding the pg_toast, pg_toast_temp_n, and > > pg_temp_n schemas, and including public and pg_catalog. > > +1. Jeff, are you willing to update the patch that way? Seems

Re: [HACKERS] tab completion for setting search_path

2014-06-23 Thread Robert Haas
On Mon, Jun 23, 2014 at 9:10 AM, Kevin Grittner wrote: > Andres Freund wrote: >> On 2014-06-22 20:02:57 -0700, Tom Lane wrote: >>> Ian Barwick writes: On 23/06/14 00:58, Andres Freund wrote: > I thought about committing this but couldn't get over this bit. If you > type "SELECT * FR

Re: [HACKERS] tab completion for setting search_path

2014-06-23 Thread Kevin Grittner
Andres Freund wrote: > On 2014-06-22 20:02:57 -0700, Tom Lane wrote: >> Ian Barwick writes: >>> On 23/06/14 00:58, Andres Freund wrote: I thought about committing this but couldn't get over this bit. If you type "SELECT * FROM pg_cat" it'll get autocompleted to pg_catalog.pg_ and "

Re: [HACKERS] tab completion for setting search_path

2014-06-23 Thread Andres Freund
On 2014-06-22 20:02:57 -0700, Tom Lane wrote: > Ian Barwick writes: > > On 23/06/14 00:58, Andres Freund wrote: > >> I thought about committing this but couldn't get over this bit. If you > >> type "SELECT * FROM pg_cat" it'll get autocompleted to > >> pg_catalog.pg_ and "pg_temp" will list all th

Re: [HACKERS] tab completion for setting search_path

2014-06-22 Thread Tom Lane
Ian Barwick writes: > On 23/06/14 00:58, Andres Freund wrote: >> I thought about committing this but couldn't get over this bit. If you >> type "SELECT * FROM pg_cat" it'll get autocompleted to >> pg_catalog.pg_ and "pg_temp" will list all the temp schemas >> including the numeric and toast ones.

Re: [HACKERS] tab completion for setting search_path

2014-06-22 Thread Ian Barwick
On 23/06/14 00:58, Andres Freund wrote: On 2014-05-05 09:10:17 -0700, Jeff Janes wrote: On Sat, May 3, 2014 at 1:11 AM, Andres Freund wrote: On 2014-05-03 00:13:45 -0700, Jeff Janes wrote: On Friday, May 2, 2014, Jeff Janes wrote: Why should we exclude system schemata? That seems more lik

Re: [HACKERS] tab completion for setting search_path

2014-06-22 Thread Andres Freund
On 2014-05-05 09:10:17 -0700, Jeff Janes wrote: > On Sat, May 3, 2014 at 1:11 AM, Andres Freund wrote: > > > On 2014-05-03 00:13:45 -0700, Jeff Janes wrote: > > > On Friday, May 2, 2014, Jeff Janes wrote: > > Why should we exclude system schemata? That seems more likely to be > > confusing than h

Re: [HACKERS] tab completion for setting search_path

2014-05-06 Thread Christoph Berg
Re: Jeff Janes 2014-05-05 > I've personally never had a need to set the search_path to a system schema, > and I guess I was implicitly modelling this on what is returned by \dn, not > by \dnS. I wouldn't object much to including them; that would be better > than not having any completion. I ju

Re: [HACKERS] tab completion for setting search_path

2014-05-05 Thread Jeff Janes
On Sat, May 3, 2014 at 1:11 AM, Andres Freund wrote: > On 2014-05-03 00:13:45 -0700, Jeff Janes wrote: > > On Friday, May 2, 2014, Jeff Janes wrote: > > > > > I've been working with an app that uses a schema name whose spelling is > > > hard to type, and the lack of tab completion for "SET search

Re: [HACKERS] tab completion for setting search_path

2014-05-05 Thread Bernd Helmle
--On 3. Mai 2014 10:11:33 +0200 Andres Freund wrote: diff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c new file mode 100644 index 6d26ffc..dec3d4a *** a/src/bin/psql/tab-complete.c --- b/src/bin/psql/tab-complete.c *** psql_completion(const char *text, int s

Re: [HACKERS] tab completion for setting search_path

2014-05-03 Thread Andres Freund
On 2014-05-03 00:13:45 -0700, Jeff Janes wrote: > On Friday, May 2, 2014, Jeff Janes wrote: > > > I've been working with an app that uses a schema name whose spelling is > > hard to type, and the lack of tab completion for "SET search_path TO" was > > bugging me. So see attached. > > > > I filte

Re: [HACKERS] tab completion for setting search_path

2014-05-03 Thread Jeff Janes
On Friday, May 2, 2014, Jeff Janes wrote: > I've been working with an app that uses a schema name whose spelling is > hard to type, and the lack of tab completion for "SET search_path TO" was > bugging me. So see attached. > > I filter out the system schemata, but not public. > > For commit fest

[HACKERS] tab completion for setting search_path

2014-05-02 Thread Jeff Janes
I've been working with an app that uses a schema name whose spelling is hard to type, and the lack of tab completion for "SET search_path TO" was bugging me. So see attached. I filter out the system schemata, but not public. For commit fest next. Cheers, Jeff