Re: [HACKERS] tablesample test failure with small TOAST_TUPLE_THRESHOLD

2016-10-14 Thread Tom Lane
Robert Haas writes: > On Fri, Oct 14, 2016 at 9:51 AM, Tom Lane wrote: >> Possibly we should be using a less chintzy (ie slower) test there, >> but a change like this would inevitably change the outputs anyway. > OK. So passing the regression tests with different values of > TOAST_TUPLE_THRESHO

Re: [HACKERS] tablesample test failure with small TOAST_TUPLE_THRESHOLD

2016-10-14 Thread Robert Haas
On Fri, Oct 14, 2016 at 9:51 AM, Tom Lane wrote: > Robert Haas writes: >> Today, I tried compiling with: >> -#define TOAST_TUPLE_THRESHOLD MaximumBytesPerTuple(TOAST_TUPLES_PER_PAGE) >> +#define TOAST_TUPLE_THRESHOLD 100 > >> Most of the regression tests pass just fine, but the tablesample on

Re: [HACKERS] tablesample test failure with small TOAST_TUPLE_THRESHOLD

2016-10-14 Thread Tom Lane
Robert Haas writes: > Today, I tried compiling with: > -#define TOAST_TUPLE_THRESHOLD MaximumBytesPerTuple(TOAST_TUPLES_PER_PAGE) > +#define TOAST_TUPLE_THRESHOLD 100 > Most of the regression tests pass just fine, but the tablesample one > experiences numerous failures. For example: > ... >

[HACKERS] tablesample test failure with small TOAST_TUPLE_THRESHOLD

2016-10-14 Thread Robert Haas
Today, I tried compiling with: -#define TOAST_TUPLE_THRESHOLD MaximumBytesPerTuple(TOAST_TUPLES_PER_PAGE) +#define TOAST_TUPLE_THRESHOLD 100 Most of the regression tests pass just fine, but the tablesample one experiences numerous failures. For example: SELECT t.id FROM test_tablesample A