Re: [HACKERS] tests for client programs

2014-06-11 Thread Andres Freund
Hi, On 2014-06-04 20:40:40 -0400, Peter Eisentraut wrote: On Wed, 2014-05-07 at 03:08 +0200, Andres Freund wrote: As an additional issue it currently doesn't seem to work in VPATH builds. That's imo a must fix. A cd $(srcdir) .. in prove_installcheck and prove_check seems to do the

Re: [HACKERS] tests for client programs

2014-06-09 Thread Peter Eisentraut
On Thu, 2014-06-05 at 21:57 -0400, Noah Misch wrote: I recommend TMPDIR = 1 instead of setting DIR. I originally decided against doing that, because 1) I don't know if all systems would have enough space in their regular temporary directory for the kinds of things we put there. Using the build

Re: [HACKERS] tests for client programs

2014-06-09 Thread Noah Misch
On Mon, Jun 09, 2014 at 09:12:27PM -0400, Peter Eisentraut wrote: On Thu, 2014-06-05 at 21:57 -0400, Noah Misch wrote: I recommend TMPDIR = 1 instead of setting DIR. I originally decided against doing that, because 1) I don't know if all systems would have enough space in their regular

Re: [HACKERS] tests for client programs

2014-06-05 Thread Andres Freund
On 2014-06-04 20:40:40 -0400, Peter Eisentraut wrote: On Wed, 2014-05-07 at 03:08 +0200, Andres Freund wrote: As an additional issue it currently doesn't seem to work in VPATH builds. That's imo a must fix. A cd $(srcdir) .. in prove_installcheck and prove_check seems to do the

Re: [HACKERS] tests for client programs

2014-06-05 Thread Noah Misch
On Thu, Jun 05, 2014 at 10:57:03AM +0200, Andres Freund wrote: On 2014-06-04 20:40:40 -0400, Peter Eisentraut wrote: On Wed, 2014-05-07 at 03:08 +0200, Andres Freund wrote: As an additional issue it currently doesn't seem to work in VPATH builds. That's imo a must fix. A cd

Re: [HACKERS] tests for client programs

2014-06-04 Thread Peter Eisentraut
On Wed, 2014-05-07 at 03:08 +0200, Andres Freund wrote: As an additional issue it currently doesn't seem to work in VPATH builds. That's imo a must fix. A cd $(srcdir) .. in prove_installcheck and prove_check seems to do the trick. Here is my proposed patch for this. diff --git

Re: [HACKERS] tests for client programs

2014-06-04 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: On Wed, 2014-05-07 at 03:08 +0200, Andres Freund wrote: As an additional issue it currently doesn't seem to work in VPATH builds. That's imo a must fix. A cd $(srcdir) .. in prove_installcheck and prove_check seems to do the trick. Here is my

Re: [HACKERS] tests for client programs

2014-05-06 Thread Peter Eisentraut
On Wed, 2014-04-30 at 18:09 +0200, Andres Freund wrote: On 2014-04-04 16:44:46 +0200, Andres Freund wrote: On 2014-02-27 21:44:48 -0500, Peter Eisentraut wrote: +open HBA, $tempdir/pgdata/pg_hba.conf; +print HBA local replication all trust\n; +print HBA host replication all

Re: [HACKERS] tests for client programs

2014-05-06 Thread Andres Freund
On 2014-05-06 20:44:56 -0400, Peter Eisentraut wrote: On Wed, 2014-04-30 at 18:09 +0200, Andres Freund wrote: On 2014-04-04 16:44:46 +0200, Andres Freund wrote: On 2014-02-27 21:44:48 -0500, Peter Eisentraut wrote: +open HBA, $tempdir/pgdata/pg_hba.conf; +print HBA local replication

Re: [HACKERS] tests for client programs

2014-05-06 Thread Andres Freund
On 2014-04-30 18:17:54 +0200, Andres Freund wrote: On 2014-04-30 18:09:15 +0200, Andres Freund wrote: The issues here don't seem to have been addressed in the commit. At least the latin1 thing should be fixed. As an additional issue it currently doesn't seem to work in VPATH builds.

Re: [HACKERS] tests for client programs

2014-04-30 Thread Andres Freund
On 2014-04-04 16:44:46 +0200, Andres Freund wrote: On 2014-02-27 21:44:48 -0500, Peter Eisentraut wrote: +open HBA, $tempdir/pgdata/pg_hba.conf; +print HBA local replication all trust\n; +print HBA host replication all 127.0.0.1/32 trust\n; +print HBA host replication all ::1/128 trust\n;

Re: [HACKERS] tests for client programs

2014-04-30 Thread Andres Freund
On 2014-04-30 18:09:15 +0200, Andres Freund wrote: The issues here don't seem to have been addressed in the commit. At least the latin1 thing should be fixed. As an additional issue it currently doesn't seem to work in VPATH builds. That's imo a must fix. Greetings, Andres Freund --

Re: [HACKERS] tests for client programs

2014-04-14 Thread Peter Eisentraut
On 4/4/14, 10:44 AM, Andres Freund wrote: I personally would very much like to get this patch commited. It doesn't have much risk in destabilizing stuff, rather the contrary. Peter, what's you opinion about the current state? I opine it's committed. ;-) -- Sent via pgsql-hackers mailing

Re: [HACKERS] tests for client programs

2014-04-04 Thread Andres Freund
Hi, I personally would very much like to get this patch commited. It doesn't have much risk in destabilizing stuff, rather the contrary. Peter, what's you opinion about the current state? On 2014-02-27 21:44:48 -0500, Peter Eisentraut wrote: diff --git a/doc/src/sgml/regress.sgml

Re: [HACKERS] tests for client programs

2014-02-27 Thread Peter Eisentraut
Updated patch. Changes: - added documentation - avoid port conflicts with running instances - added tests for pg_basebackup -T - removed TODO tests for rejected pg_basebackup feature A test on Windows would be nice. Otherwise we'll let the buildfarm do it. From

Re: [HACKERS] tests for client programs

2014-02-08 Thread Peter Eisentraut
On Wed, 2014-01-15 at 20:56 +0100, Erik Rijkers wrote: 2 tests stumbled: 1. One test ( pg_ctl/t/001_start_stop.pl ) failed because I had PGDATA set. I unset all PG+ vars after that. No a big problem but nonetheless it might be better if the test suite removes /controls the variables

[HACKERS] tests for client programs

2014-01-29 Thread Pavel Stehule
Hello I am looking on this patch. It is great idea, and I am sure, so we want this patch - it was requested and proposed more time. Some tips: a) possibility to test only selected tests b) possibility to verify generated file against expected file c) detection some warnings

Re: [HACKERS] tests for client programs

2014-01-15 Thread Peter Eisentraut
On 1/15/14, 1:46 AM, Erik Rijkers wrote: The seems to be a dependency on IPC::Run I can install that, of course... but I suppose you want to make this work without that. No, IPC::Run will be required. It looked like it was part of the default installation where I tested, but apparently

Re: [HACKERS] tests for client programs

2014-01-15 Thread Erik Rijkers
On Wed, January 15, 2014 06:30, Peter Eisentraut wrote: As we all know, the client programs (src/bin/) don't have any real test So I wrote something. I chose to use Perl-based tools, prove and Test::More, because those are [ 0001-Add-TAP-tests-for-client-programs.patch ] 32 k I gave this

[HACKERS] tests for client programs

2014-01-14 Thread Peter Eisentraut
As we all know, the client programs (src/bin/) don't have any real test suites. Some pieces are tested as part of the backend regression tests, some as part of the pg_upgrade test script, but nothing is specifically targeted, and pg_basebackup for example is not tested at all. So I wrote

Re: [HACKERS] tests for client programs

2014-01-14 Thread Erik Rijkers
On Wed, January 15, 2014 06:30, Peter Eisentraut wrote: As we all know, the client programs (src/bin/) don't have any real test suites. Some pieces are tested as part of the backend regression tests, some as part of the pg_upgrade test script, but nothing is specifically targeted, and