Hi Fujii, thanks for the review. I have pushed the patch to 9.5 and
master.
Fujii Masao wrote:
> @@ -5321,7 +5333,7 @@ xact_redo_commit(xl_xact_parsed_commit *parsed,
> /* Set the transaction commit timestamp and metadata */
> TransactionTreeSetCommitTsData(xid, parsed->nsubxacts, pars
Petr Jelinek wrote:
> On 2015-09-29 13:44, Fujii Masao wrote:
> >On Tue, Sep 29, 2015 at 12:05 PM, Alvaro Herrera
> > wrote:
> >-#define RecoveryRequiresBoolParameter(param_name, currValue, masterValue) \
> >-do { \
> >-bool _currValue = (currValue); \
> >-bool _masterValue = (masterValue)
On 2015-09-29 13:44, Fujii Masao wrote:
On Tue, Sep 29, 2015 at 12:05 PM, Alvaro Herrera
wrote:
Petr Jelinek wrote:
On 2015-09-02 16:14, Fujii Masao wrote:
On Wed, Aug 5, 2015 at 2:16 AM, Robert Haas wrote:
On Mon, Aug 3, 2015 at 10:31 AM, Fujii Masao wrote:
track_commit_timestamp tracks
On Tue, Sep 29, 2015 at 12:05 PM, Alvaro Herrera
wrote:
> Petr Jelinek wrote:
>> On 2015-09-02 16:14, Fujii Masao wrote:
>> >On Wed, Aug 5, 2015 at 2:16 AM, Robert Haas wrote:
>> >>On Mon, Aug 3, 2015 at 10:31 AM, Fujii Masao wrote:
>> >>>track_commit_timestamp tracks COMMIT PREPARED as expected
On 2015-09-29 05:05, Alvaro Herrera wrote:
Petr Jelinek wrote:
On 2015-09-02 16:14, Fujii Masao wrote:
On Wed, Aug 5, 2015 at 2:16 AM, Robert Haas wrote:
On Mon, Aug 3, 2015 at 10:31 AM, Fujii Masao wrote:
track_commit_timestamp tracks COMMIT PREPARED as expected in standby server,
but not
Petr Jelinek wrote:
> On 2015-09-02 16:14, Fujii Masao wrote:
> >On Wed, Aug 5, 2015 at 2:16 AM, Robert Haas wrote:
> >>On Mon, Aug 3, 2015 at 10:31 AM, Fujii Masao wrote:
> >>>track_commit_timestamp tracks COMMIT PREPARED as expected in standby
> >>>server,
> >>>but not in master server. Is thi
Fujii Masao wrote:
> +if (replorigin_sesssion_origin == InvalidRepOriginId ||
>
> This is not the problem of the patch, but I started wondering what
> "sesssion" in the variable name "replorigin_sesssion_origin" means.
> Is it just a typo and it should be "session"? Or it's the abbreviation
>
On Mon, Sep 28, 2015 at 2:07 PM, Petr Jelinek wrote:
> Sorry, missed your reply.
To be clear, that was actually Fujii Masao's reply, not mine. I hope
he can have a look at this version.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pg
On 2015-09-28 18:59, Robert Haas wrote:
The patch looks good to me except the following minor points.
* or not. Normal path through RecordTransactionCommit() will be related
* to a transaction commit XLog record, and so should pass "false" here.
The above source comment of TransactionTree
On Fri, Sep 18, 2015 at 12:53 AM, Fujii Masao wrote:
> On Sat, Sep 5, 2015 at 7:48 PM, Petr Jelinek wrote:
>> On 2015-09-02 16:14, Fujii Masao wrote:
>>>
>>> On Wed, Aug 5, 2015 at 2:16 AM, Robert Haas wrote:
On Mon, Aug 3, 2015 at 10:31 AM, Fujii Masao
wrote:
>
> track_c
On Sat, Sep 5, 2015 at 7:48 PM, Petr Jelinek wrote:
> On 2015-09-02 16:14, Fujii Masao wrote:
>>
>> On Wed, Aug 5, 2015 at 2:16 AM, Robert Haas wrote:
>>>
>>> On Mon, Aug 3, 2015 at 10:31 AM, Fujii Masao
>>> wrote:
track_commit_timestamp tracks COMMIT PREPARED as expected in standby
>>
On 2015-09-02 16:14, Fujii Masao wrote:
On Wed, Aug 5, 2015 at 2:16 AM, Robert Haas wrote:
On Mon, Aug 3, 2015 at 10:31 AM, Fujii Masao wrote:
track_commit_timestamp tracks COMMIT PREPARED as expected in standby server,
but not in master server. Is this intentional? It should track COMMIT PRE
On Wed, Aug 5, 2015 at 2:16 AM, Robert Haas wrote:
> On Mon, Aug 3, 2015 at 10:31 AM, Fujii Masao wrote:
>> track_commit_timestamp tracks COMMIT PREPARED as expected in standby server,
>> but not in master server. Is this intentional? It should track COMMIT
>> PREPARED
>> even in master? Otherwi
On Tue, Aug 4, 2015 at 1:18 PM, Andres Freund wrote:
> On 2015-08-04 13:16:52 -0400, Robert Haas wrote:
>> On Mon, Aug 3, 2015 at 10:31 AM, Fujii Masao wrote:
>> > track_commit_timestamp tracks COMMIT PREPARED as expected in standby
>> > server,
>> > but not in master server. Is this intentional
On 2015-08-04 13:16:52 -0400, Robert Haas wrote:
> On Mon, Aug 3, 2015 at 10:31 AM, Fujii Masao wrote:
> > track_commit_timestamp tracks COMMIT PREPARED as expected in standby server,
> > but not in master server. Is this intentional? It should track COMMIT
> > PREPARED
> > even in master? Otherw
On Mon, Aug 3, 2015 at 10:31 AM, Fujii Masao wrote:
> track_commit_timestamp tracks COMMIT PREPARED as expected in standby server,
> but not in master server. Is this intentional? It should track COMMIT PREPARED
> even in master? Otherwise, we cannot use commit_timestamp feature to check
> the rep
Hi,
track_commit_timestamp tracks COMMIT PREPARED as expected in standby server,
but not in master server. Is this intentional? It should track COMMIT PREPARED
even in master? Otherwise, we cannot use commit_timestamp feature to check
the replication lag properly while we use 2PC.
Regards,
--
F
17 matches
Mail list logo