Re: [HACKERS] tsearch2 regression test failures

2007-03-26 Thread Teodor Sigaev
FWIW, it looks like it failed to reject stopwords. Is it possible you Right. I suppose the problem is with '\r\n'... Try attached patch. -- Teodor Sigaev E-mail: [EMAIL PROTECTED] WWW: http://www.sigaev.ru/

Re: [HACKERS] tsearch2 regression test failures

2007-03-26 Thread Magnus Hagander
On Mon, Mar 26, 2007 at 02:32:26PM +0400, Teodor Sigaev wrote: FWIW, it looks like it failed to reject stopwords. Is it possible you Right. I suppose the problem is with '\r\n'... Try attached patch. -- Teodor Sigaev E-mail: [EMAIL PROTECTED]

Re: [HACKERS] tsearch2 regression test failures

2007-03-26 Thread Teodor Sigaev
Yup, that solved the problem, thanks. I'll commit extended patch - there is one more place with the same bug. Wouldn't it be more efficiently written to walk the string backwards until !isspace instead? Not sure that it matters at all, but then you'll normallyi never step over more than two

Re: [HACKERS] tsearch2 regression test failures

2007-03-26 Thread Magnus Hagander
Yup, that solved the problem, thanks. I'll commit extended patch - there is one more place with the same bug. Ok, thanks. Wouldn't it be more efficiently written to walk the string backwards until !isspace instead? Not sure that it matters at all, but then you'll normallyi never step

Re: [HACKERS] tsearch2 regression test failures

2007-03-26 Thread Tom Lane
Teodor Sigaev [EMAIL PROTECTED] writes: ! pbuf = buf; ! while( !isspace( *pbuf ) ) ! pbuf++; ! *pbuf = '\0'; Surely the loop needs to look like while (*pbuf !isspace(*pbuf))

Re: [HACKERS] tsearch2 regression test failures

2007-03-26 Thread Andrew Dunstan
Tom Lane wrote: Teodor Sigaev [EMAIL PROTECTED] writes: ! pbuf = buf; ! while( !isspace( *pbuf ) ) ! pbuf++; ! *pbuf = '\0'; Surely the loop needs to look like while (*pbuf

Re: [HACKERS] tsearch2 regression test failures

2007-03-25 Thread Tom Lane
Magnus Hagander [EMAIL PROTECTED] writes: tsearch2 regression tests are also failing on win32/msvc, with attached diffs. Any pointers on where to start? ;) FWIW, it looks like it failed to reject stopwords. Is it possible you ran it in an environment that would make it pick the Russian

[HACKERS] tsearch2 regression test failures

2007-03-24 Thread Magnus Hagander
tsearch2 regression tests are also failing on win32/msvc, with attached diffs. Any pointers on where to start? ;) //Magnus *** ./expected/tsearch2.out 2006-09-10 19:36:52.0 +0200 --- ./results/tsearch2.out 2007-03-24 15:03:01.59375 +0100 *** *** 799,806