Re: [HACKERS] tsearch2api project

2007-10-17 Thread Tom Lane
"Pavel Stehule" <[EMAIL PROTECTED]> writes: > but I would > #define ENVELOPE_FCE(name,dest) \ > Datum name (PG_FUNCTION_ARGS); \ > PG_FUNCTION_INFO_V1(name); \ > Datum \ > name (PG_FUNCTION_ARGS) \ > { \ > return (dest)(fceinfo); \ > } That seems perfectly legitimate to me --- I'm pretty s

Re: [HACKERS] tsearch2api project

2007-10-17 Thread Pavel Stehule
2007/10/17, Tom Lane <[EMAIL PROTECTED]>: > "Pavel Stehule" <[EMAIL PROTECTED]> writes: > >> Surely this shouldn't be creating its own tsvector datatype? > > > I would to use only pg_catalog.tsvector. But dump contains CREATE TYPE > > statement, and custom functions which prefere it, because path i

Re: [HACKERS] tsearch2api project

2007-10-17 Thread Tom Lane
"Pavel Stehule" <[EMAIL PROTECTED]> writes: >> Surely this shouldn't be creating its own tsvector datatype? > I would to use only pg_catalog.tsvector. But dump contains CREATE TYPE > statement, and custom functions which prefere it, because path is: > public, pg_catalog :(. I didn't find any other

Re: [HACKERS] tsearch2api project

2007-10-17 Thread Pavel Stehule
> > Surely this shouldn't be creating its own tsvector datatype? Having > both public.tsvector and pg_catalog.tsvector seems like a seriously > bad idea, if only because of confusion. ISTM you should only be > creating new public.foo objects for the functions whose names changed. > I would to us

Re: [HACKERS] tsearch2api project

2007-10-17 Thread andy
Tom Lane wrote: Anyway, the picture that's starting to emerge for me is that we should repurpose contrib/tsearch2 as a repository for scripts and documentation to help people migrate from previous use of tsearch2 to use of the new core facilities; and for people who want to try to *not* migrate,

Re: [HACKERS] tsearch2api project

2007-10-17 Thread Tom Lane
"Pavel Stehule" <[EMAIL PROTECTED]> writes: > I created new project on pgfoundry. It's wrapper of integrated > fulltext and it's binary compatible with TSearch2 API. > * it works, (I am able load 82 dump without changes) > * it is ugly :( . I expected, so this wrapper can be more elegant, but > no

[HACKERS] tsearch2api project

2007-10-17 Thread Pavel Stehule
Hello I created new project on pgfoundry. It's wrapper of integrated fulltext and it's binary compatible with TSearch2 API. * it works, (I am able load 82 dump without changes) * it is ugly :( . I expected, so this wrapper can be more elegant, but not. I had to create full dual interface to fullt