2017-09-19 21:11 GMT+02:00 Tom Lane :
> Pavel Stehule writes:
> > [ faster-concat-2.patch ]
>
> Pushed with some cosmetic adjustments (mostly better comments).
>
Thank you very much
Pavel
> regards, tom lane
>
Pavel Stehule writes:
> [ faster-concat-2.patch ]
Pushed with some cosmetic adjustments (mostly better comments).
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
2017-09-19 12:18 GMT+02:00 Alexander Kuzmenkov :
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, passed
> Implements feature: tested, passed
> Spec compliant: tested, passed
> Documentation:
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
Looks good to me.
The new status of this patch is: Ready
Hi
2017-08-24 19:24 GMT+02:00 Alexander Kuzmenkov :
> Hi Pavel,
>
> I tried applying your patch, it applies and compiles fine, check and
> checkworld pass.
>
> I ran a simple performance test, select concat(generate_series(1,10),
> ... [x5 total]) vs select
Hi Pavel,
I tried applying your patch, it applies and compiles fine, check and
checkworld pass.
I ran a simple performance test, select
concat(generate_series(1,10), ... [x5 total]) vs select
generate_series(1,10)::text || ... .
Operator || runs in 60 ms, while unpatched concat
2017-06-18 0:50 GMT+02:00 Dmitry Dolgov <9erthali...@gmail.com>:
> > On 20 May 2017 at 10:03, Pavel Stehule wrote:
> >
> > Now concat is 2x times slower than || operator. With cached FmgrInfo for
> > output function it will be only 5%.
>
> Looks nice and does what's
> On 20 May 2017 at 10:03, Pavel Stehule wrote:
>
> Now concat is 2x times slower than || operator. With cached FmgrInfo for
> output function it will be only 5%.
Looks nice and does what's expected (what else one may need from a Saturday
evening). I just can mention
Hi
Now concat is 2x times slower than || operator. With cached FmgrInfo for
output function it will be only 5%.
Regards
Pavel
diff --git a/src/backend/utils/adt/varlena.c b/src/backend/utils/adt/varlena.c
index be399f4..d3f04f8 100644
--- a/src/backend/utils/adt/varlena.c
+++