Re: [HACKERS] Typo in insert.sgml

2017-08-27 Thread Peter Eisentraut
On 6/20/17 15:03, David G. Johnston wrote: > On Tuesday, June 20, 2017, Robert Haas > wrote: > > On Tue, Jun 20, 2017 at 2:34 PM, Peter Eisentraut > > wrote: > > On 6/18/17 03:16,

Re: [HACKERS] typo for using "OBJECT_TYPE" for "security label on domain" in "gram.y"

2017-08-02 Thread Peter Eisentraut
On 8/2/17 08:21, Robert Haas wrote: > On Wed, Aug 2, 2017 at 6:04 AM, 高增琦 wrote: >> Commit: 3f88672a4e4d8e648d24ccc65937da61c7660854 add "security label on >> domain" >> in "gram.y", and set "objtype" to "OBJECT_TYPE". >> >> Is this a typo? > > Looks like it. Fix committed to

Re: [HACKERS] typo for using "OBJECT_TYPE" for "security label on domain" in "gram.y"

2017-08-02 Thread Robert Haas
On Wed, Aug 2, 2017 at 6:04 AM, 高增琦 wrote: > Commit: 3f88672a4e4d8e648d24ccc65937da61c7660854 add "security label on > domain" > in "gram.y", and set "objtype" to "OBJECT_TYPE". > > Is this a typo? Looks like it. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The

[HACKERS] typo for using "OBJECT_TYPE" for "security label on domain" in "gram.y"

2017-08-02 Thread 高增琦
Commit: 3f88672a4e4d8e648d24ccc65937da61c7660854 add "security label on domain" in "gram.y", and set "objtype" to "OBJECT_TYPE". Is this a typo? -- GaoZengqi pgf...@gmail.com zengqi...@gmail.com

Re: [HACKERS] Typo in backend/storage/ipc/standby.c

2017-07-12 Thread Kyotaro HORIGUCHI
At Wed, 12 Jul 2017 17:11:12 +0300, Heikki Linnakangas wrote in > On 07/11/2017 10:34 AM, Kyotaro HORIGUCHI wrote: > > I noticed that a comment above StandbyAcquireAccessExclusiveLock > > in backend/storage/ipc/standby.c using wrong

Re: [HACKERS] Typo in backend/storage/ipc/standby.c

2017-07-12 Thread Heikki Linnakangas
On 07/11/2017 10:34 AM, Kyotaro HORIGUCHI wrote: Hello. I noticed that a comment above StandbyAcquireAccessExclusiveLock in backend/storage/ipc/standby.c using wrong names of a variable and a type. The attached patch fixes it. The same mistake is found in older versions back to 9.0.

[HACKERS] Typo in backend/storage/ipc/standby.c

2017-07-11 Thread Kyotaro HORIGUCHI
Hello. I noticed that a comment above StandbyAcquireAccessExclusiveLock in backend/storage/ipc/standby.c using wrong names of a variable and a type. The attached patch fixes it. The same mistake is found in older versions back to 9.0. fix_typo_of_standby_c_10_master.patch is for 10 and master

Re: [HACKERS] Typo in comment in xlog.c: ReadRecord

2017-07-02 Thread Amit Langote
On 2017/07/01 3:49, Peter Eisentraut wrote: > On 6/27/17 20:54, Amit Langote wrote: >> Attached fixes $SUBJECT. >> >> s/fetch_ckpt/fetching_ckpt/g > > committed Thanks. Regards, Amit -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Typo in comment in postgres_fdw.c

2017-06-30 Thread Peter Eisentraut
On 6/28/17 09:53, Albe Laurenz wrote: > Attached is a fix for a small typo I found. committed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Typo in comment in xlog.c: ReadRecord

2017-06-30 Thread Peter Eisentraut
On 6/27/17 20:54, Amit Langote wrote: > Attached fixes $SUBJECT. > > s/fetch_ckpt/fetching_ckpt/g committed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list

[HACKERS] Typo in comment in postgres_fdw.c

2017-06-28 Thread Albe Laurenz
Attached is a fix for a small typo I found. Yours, Laurenz Albe comment.patch Description: comment.patch -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Typo in comment in xlog.c: ReadRecord

2017-06-27 Thread Amit Langote
Attached fixes $SUBJECT. s/fetch_ckpt/fetching_ckpt/g Thanks, Amit diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c index 0a6314a642..5b6cec8dee 100644 --- a/src/backend/access/transam/xlog.c +++ b/src/backend/access/transam/xlog.c @@ -4221,10 +4221,10 @@

Re: [HACKERS] Typo in insert.sgml

2017-06-20 Thread David G. Johnston
On Tue, Jun 20, 2017 at 1:35 PM, Tom Lane wrote: > Robert Haas writes: >> On Tue, Jun 20, 2017 at 2:34 PM, Peter Eisentraut >> wrote: >>> This was not a typo, this was intentional. > >> To me, Julien's change seems to

Re: [HACKERS] Typo in insert.sgml

2017-06-20 Thread Tom Lane
Robert Haas writes: > On Tue, Jun 20, 2017 at 2:34 PM, Peter Eisentraut > wrote: >> This was not a typo, this was intentional. > To me, Julien's change seems to make it easier to understand, but > maybe I'm misunderstanding what it's

Re: [HACKERS] Typo in insert.sgml

2017-06-20 Thread David G. Johnston
On Tuesday, June 20, 2017, Robert Haas wrote: > On Tue, Jun 20, 2017 at 2:34 PM, Peter Eisentraut > > wrote: > > On 6/18/17 03:16, Julien Rouhaud wrote: > >> Patch attached. > > > > This was not a typo, this was intentional.

Re: [HACKERS] Typo in insert.sgml

2017-06-20 Thread Julien Rouhaud
On 20/06/2017 20:34, Peter Eisentraut wrote: > On 6/18/17 03:16, Julien Rouhaud wrote: >> Patch attached. > > This was not a typo, this was intentional. > Oh, sorry. I'm not a native english speaker, that sounded really weird. -- Julien Rouhaud http://dalibo.com - http://dalibo.org --

Re: [HACKERS] Typo in insert.sgml

2017-06-20 Thread Robert Haas
On Tue, Jun 20, 2017 at 2:34 PM, Peter Eisentraut wrote: > On 6/18/17 03:16, Julien Rouhaud wrote: >> Patch attached. > > This was not a typo, this was intentional. To me, Julien's change seems to make it easier to understand, but maybe I'm misunderstanding what

Re: [HACKERS] Typo in insert.sgml

2017-06-20 Thread Peter Eisentraut
On 6/18/17 03:16, Julien Rouhaud wrote: > Patch attached. This was not a typo, this was intentional. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Typo in drop_publication.sgml

2017-06-18 Thread Julien Rouhaud
On Sun, Jun 18, 2017 at 07:42:54PM +0200, Magnus Hagander wrote: > On Sun, Jun 18, 2017 at 8:46 AM, Julien Rouhaud > wrote: > > > Patch attached. > > > > Applied, thanks. > Thanks. -- Julien Rouhaud http://dalibo.com - http://dalibo.org -- Sent via pgsql-hackers

Re: [HACKERS] Typo in drop_publication.sgml

2017-06-18 Thread Magnus Hagander
On Sun, Jun 18, 2017 at 8:46 AM, Julien Rouhaud wrote: > Patch attached. > Applied, thanks. -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/

[HACKERS] Typo in insert.sgml

2017-06-18 Thread Julien Rouhaud
Patch attached. -- Julien Rouhaud http://dalibo.com - http://dalibo.org diff --git a/doc/src/sgml/ref/insert.sgml b/doc/src/sgml/ref/insert.sgml index 94dad00870..0e327e5b2e 100644 --- a/doc/src/sgml/ref/insert.sgml +++ b/doc/src/sgml/ref/insert.sgml @@ -228,7 +228,7 @@ INSERT INTO table_name [

[HACKERS] Typo in drop_publication.sgml

2017-06-18 Thread Julien Rouhaud
Patch attached. -- Julien Rouhaud http://dalibo.com - http://dalibo.org diff --git a/doc/src/sgml/ref/drop_publication.sgml b/doc/src/sgml/ref/drop_publication.sgml index 517d142251..8e45a43982 100644 --- a/doc/src/sgml/ref/drop_publication.sgml +++ b/doc/src/sgml/ref/drop_publication.sgml @@

Re: [HACKERS] Typo in planstats.sgml

2017-06-17 Thread Julien Rouhaud
On 18/06/2017 01:03, Peter Eisentraut wrote: > On 6/17/17 05:00, Julien Rouhaud wrote: >> A "condition" is missing, patch attached. > > fixed > Thanks. -- Julien Rouhaud http://dalibo.com - http://dalibo.org -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] Typo in planstats.sgml

2017-06-17 Thread Peter Eisentraut
On 6/17/17 05:00, Julien Rouhaud wrote: > A "condition" is missing, patch attached. fixed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)

Re: [HACKERS] Typo in CREATE SUBSCRIPTION documentation

2017-06-17 Thread Julien Rouhaud
On Sat, Jun 17, 2017 at 10:24:32AM -0400, Peter Eisentraut wrote: > On 6/15/17 15:19, Julien Rouhaud wrote: > > Hi, > > > > I just found $SUBJECT, patch attached. > > fixed Thanks! -- Julien Rouhaud http://dalibo.com - http://dalibo.org -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Typo in CREATE SUBSCRIPTION documentation

2017-06-17 Thread Peter Eisentraut
On 6/15/17 15:19, Julien Rouhaud wrote: > Hi, > > I just found $SUBJECT, patch attached. fixed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list

[HACKERS] Typo in planstats.sgml

2017-06-17 Thread Julien Rouhaud
A "condition" is missing, patch attached. -- Julien Rouhaud http://dalibo.com - http://dalibo.org diff --git a/doc/src/sgml/planstats.sgml b/doc/src/sgml/planstats.sgml index 8caf297f85..838fcda6d2 100644 --- a/doc/src/sgml/planstats.sgml +++ b/doc/src/sgml/planstats.sgml @@ -501,8 +501,8 @@

[HACKERS] Typo in CREATE SUBSCRIPTION documentation

2017-06-15 Thread Julien Rouhaud
Hi, I just found $SUBJECT, patch attached. -- Julien Rouhaud http://dalibo.com - http://dalibo.org diff --git a/doc/src/sgml/ref/create_subscription.sgml b/doc/src/sgml/ref/create_subscription.sgml index 77bf87681b..3ca06fb3c3 100644 --- a/doc/src/sgml/ref/create_subscription.sgml +++

Re: [HACKERS] Typo in comment in ecpg datetime.c

2017-06-15 Thread Peter Eisentraut
On 6/15/17 04:54, Daniel Gustafsson wrote: > Spotted s/fiedls/fields/ in src/interfaces/ecpg/pgtypeslib/datetime.c per the > attached patch. fixed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via

[HACKERS] Typo in comment in ecpg datetime.c

2017-06-15 Thread Daniel Gustafsson
Spotted s/fiedls/fields/ in src/interfaces/ecpg/pgtypeslib/datetime.c per the attached patch. cheers ./daniel typo-ecpg_datetime.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Typo in BRIN documentation

2017-06-13 Thread Julien Rouhaud
On Tue, Jun 13, 2017 at 11:29:30AM -0400, Peter Eisentraut wrote: > On 6/13/17 07:53, Julien Rouhaud wrote: > > I just found this typo while doing french translation, patch attached. > > fixed > Thanks ! -- Julien Rouhaud http://dalibo.com - http://dalibo.org -- Sent via pgsql-hackers mailing

Re: [HACKERS] Typo in BRIN documentation

2017-06-13 Thread Peter Eisentraut
On 6/13/17 07:53, Julien Rouhaud wrote: > I just found this typo while doing french translation, patch attached. fixed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list

[HACKERS] Typo in BRIN documentation

2017-06-13 Thread Julien Rouhaud
Hi, I just found this typo while doing french translation, patch attached. Regards. -- Julien Rouhaud http://dalibo.com - http://dalibo.org diff --git a/doc/src/sgml/brin.sgml b/doc/src/sgml/brin.sgml index ad11109775..8dcc29925b 100644 --- a/doc/src/sgml/brin.sgml +++ b/doc/src/sgml/brin.sgml

Re: [HACKERS] Typo in xlogfuncs.c [WAS Re: Incorrect mention of pg_xlog_switch() in xlogfuncs.c]

2017-06-09 Thread Peter Eisentraut
On 5/31/17 19:59, Neha Khatri wrote: > Simplifying $subject. There are typos in xlogfuncs.c. So Either > > s/pg_xlog_switch/pg_switch_wal fixed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via

[HACKERS] Typo in xlogfuncs.c [WAS Re: Incorrect mention of pg_xlog_switch() in xlogfuncs.c]

2017-05-31 Thread Neha Khatri
Simplifying $subject. There are typos in xlogfuncs.c. So Either s/pg_xlog_switch/pg_switch_wal Or Remove "pg_xlog_switch" from the comments. Attached patches both ways. Regards, Neha On Sat, May 20, 2017 at 1:08 AM, Neha Khatri wrote: > While reading some code,

Re: [HACKERS] Typo in json.c

2017-05-18 Thread Heikki Linnakangas
On 05/18/2017 10:17 AM, Daniel Gustafsson wrote: Spotted while reading code, patch attached. Applied, thanks. - Heikki -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Typo in json.c

2017-05-18 Thread Daniel Gustafsson
Spotted while reading code, patch attached. cheers ./daniel typo-json.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in htup_details.h

2017-04-15 Thread Tom Lane
Amit Kapila writes: > Attached patch to fix $SUBJECT. Pushed, thanks. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

[HACKERS] Typo in htup_details.h

2017-04-15 Thread Amit Kapila
Attached patch to fix $SUBJECT. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com typo_htup_details.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Typo in libpq

2017-03-31 Thread Magnus Hagander
On Thu, Mar 30, 2017 at 3:48 PM, Daniel Gustafsson wrote: > There seems to be a typo in libpq as per attached, “..we will loose error > messages” should probably be “..we will lose error messages”. > Applied, thanks. -- Magnus Hagander Me: http://www.hagander.net/ Work:

[HACKERS] Typo in libpq

2017-03-30 Thread Daniel Gustafsson
There seems to be a typo in libpq as per attached, “..we will loose error messages” should probably be “..we will lose error messages”. cheers ./daniel typo-libpq-loose.diff Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] Typo in snapbuild.c

2017-03-13 Thread Magnus Hagander
On Mon, Mar 13, 2017 at 8:33 AM, Masahiko Sawada wrote: > Hi, > > Attached fixes comment typos in snapbuild.c file. > Applied, thanks. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

[HACKERS] Typo in snapbuild.c

2017-03-13 Thread Masahiko Sawada
Hi, Attached fixes comment typos in snapbuild.c file. Regards, -- Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center fix_small_typo_in_snapbuild.patch Description: Binary data -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Typo in comment in postgres_fdw.c

2017-01-27 Thread Robert Haas
On Thu, Jan 26, 2017 at 10:45 PM, Etsuro Fujita wrote: > I ran into a typo in a comment in contrib/postgres_fdw/postgres_fdw.c. > Attached is a small patch for fixing that. Committed, thanks. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise

[HACKERS] Typo in comment in postgres_fdw.c

2017-01-26 Thread Etsuro Fujita
Hi, I ran into a typo in a comment in contrib/postgres_fdw/postgres_fdw.c. Attached is a small patch for fixing that. Best regards, Etsuro Fujita diff --git a/contrib/postgres_fdw/postgres_fdw.c b/contrib/postgres_fdw/postgres_fdw.c index fbe6929..7cb9dc5 100644 ---

Re: [HACKERS] Typo in hashsearch.c

2017-01-18 Thread Robert Haas
On Fri, Jan 13, 2017 at 4:38 AM, Mithun Cy wrote: > There is a typo in comments of function _hash_first(); Adding a fix for same. Thanks. I pushed a commit including this fix and some other improvements to that comment. -- Robert Haas EnterpriseDB:

Re: [HACKERS] Typo in condition_variable.c

2017-01-16 Thread Fujii Masao
On Mon, Jan 16, 2017 at 6:34 PM, Masahiko Sawada wrote: > On Mon, Jan 16, 2017 at 6:27 PM, Fujii Masao wrote: >> On Mon, Jan 16, 2017 at 5:42 PM, Masahiko Sawada >> wrote: >>> Hi, >>> >>> Attached patch fixes comment typos in

Re: [HACKERS] Typo in condition_variable.c

2017-01-16 Thread Masahiko Sawada
On Mon, Jan 16, 2017 at 6:27 PM, Fujii Masao wrote: > On Mon, Jan 16, 2017 at 5:42 PM, Masahiko Sawada > wrote: >> Hi, >> >> Attached patch fixes comment typos in condition_variable.c > > Seems the patch still has the typo. "initiailly" should be

Re: [HACKERS] Typo in condition_variable.c

2017-01-16 Thread Fujii Masao
On Mon, Jan 16, 2017 at 5:42 PM, Masahiko Sawada wrote: > Hi, > > Attached patch fixes comment typos in condition_variable.c Seems the patch still has the typo. "initiailly" should be "initially"? Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list

[HACKERS] Typo in condition_variable.c

2017-01-16 Thread Masahiko Sawada
Hi, Attached patch fixes comment typos in condition_variable.c Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center fix_type_in_condition_variable_c.patch Description: binary/octet-stream -- Sent via pgsql-hackers mailing list

[HACKERS] Typo in hashsearch.c

2017-01-13 Thread Mithun Cy
There is a typo in comments of function _hash_first(); Adding a fix for same. -- Thanks and Regards Mithun C Y EnterpriseDB: http://www.enterprisedb.com hashsearch_typo01.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to

Re: [HACKERS] Typo in dsa.c

2017-01-11 Thread Magnus Hagander
On Wed, Jan 11, 2017 at 8:28 AM, Masahiko Sawada wrote: > Hi, > > Attached fixes comment typos in dsa.c. > Thanks, pushed! -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

[HACKERS] Typo in dsa.c

2017-01-10 Thread Masahiko Sawada
Hi, Attached fixes comment typos in dsa.c. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center fix_typo_in_dsa_c.patch Description: binary/octet-stream -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to

Re: [HACKERS] Typo in doc/src/sgml/catalogs.sgml

2016-12-12 Thread Robert Haas
On Sun, Dec 11, 2016 at 5:13 AM, Joel Jacobson wrote: > Hi, > > I found a minor typo at > https://www.postgresql.org/docs/9.6/static/catalog-pg-am.html. > > pg_catalog.pg_am. amhandler is of type "oid" according to the > documentation, but it's actually of type "regproc" in

[HACKERS] Typo in doc/src/sgml/catalogs.sgml

2016-12-11 Thread Joel Jacobson
Hi, I found a minor typo at https://www.postgresql.org/docs/9.6/static/catalog-pg-am.html. pg_catalog.pg_am. amhandler is of type "oid" according to the documentation, but it's actually of type "regproc" in reality. Compare with e.g. pg_aggregate where the columns of type "regproc" is both

Re: [HACKERS] Typo in comment

2016-11-25 Thread Magnus Hagander
On Fri, Nov 25, 2016 at 4:10 AM, Thomas Munro wrote: > Hi > > Here is a tiny patch to fix a typo in execParallel.c. > Applied, thanks. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

[HACKERS] Typo in comment

2016-11-24 Thread Thomas Munro
Hi Here is a tiny patch to fix a typo in execParallel.c. -- Thomas Munro http://www.enterprisedb.com typo.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Typo in comment in file analyze.c [master branch]

2016-11-23 Thread Tom Lane
Kostiantyn Nemchenko writes: > I've found a typo in a comment in function do_analyze_rel() in > file analyze.c [line 348, master branch]. No, "iff" is intentional there. It means "if and only if". regards, tom lane -- Sent via

[HACKERS] Typo in comment in file analyze.c [master branch]

2016-11-23 Thread Kostiantyn Nemchenko
I've found a typo in a comment in function do_analyze_rel() in file analyze.c [line 348, master branch]. Attached a patch. minor_typo_analyze_c.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Typo in event_trigger.c

2016-11-08 Thread Robert Haas
On Tue, Nov 8, 2016 at 8:28 AM, Michael Paquier wrote: > Hi all, > > I just bumped into the following: > --- a/src/backend/commands/event_trigger.c > +++ b/src/backend/commands/event_trigger.c > @@ -742,7 +742,7 @@ EventTriggerCommonSetup(Node *parsetree, > > /* >

Re: [HACKERS] Typo in event_trigger.c

2016-11-08 Thread Michael Paquier
On Wed, Nov 9, 2016 at 5:35 AM, Robert Haas wrote: > Committed. Thanks. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Typo in event_trigger.c

2016-11-08 Thread Michael Paquier
Hi all, I just bumped into the following: --- a/src/backend/commands/event_trigger.c +++ b/src/backend/commands/event_trigger.c @@ -742,7 +742,7 @@ EventTriggerCommonSetup(Node *parsetree, /* * Filter list of event triggers by command tag, and copy them into our -* memory context.

Re: [HACKERS] Typo in comment in contrib/postgres_fdw/deparse.c

2016-11-06 Thread Etsuro Fujita
On 2016/11/04 22:04, Robert Haas wrote: On Fri, Nov 4, 2016 at 7:20 AM, Etsuro Fujita wrote: I found another typo in postgres_fdw.c. Attached is a patch for fixing that. OK, committed that, too. Thanks again! Best regards, Etsuro Fujita -- Sent via

Re: [HACKERS] Typo in comment in contrib/postgres_fdw/deparse.c

2016-11-04 Thread Robert Haas
On Fri, Nov 4, 2016 at 7:20 AM, Etsuro Fujita wrote: > On 2016/11/02 5:22, Robert Haas wrote: >> On Tue, Nov 1, 2016 at 8:20 AM, Etsuro Fujita >> wrote: >>> >>> I ran into a typo in a comment in contrib/postgres_fdw/deparse.c. Please >>>

Re: [HACKERS] Typo in comment in contrib/postgres_fdw/deparse.c

2016-11-04 Thread Etsuro Fujita
On 2016/11/02 5:22, Robert Haas wrote: On Tue, Nov 1, 2016 at 8:20 AM, Etsuro Fujita wrote: I ran into a typo in a comment in contrib/postgres_fdw/deparse.c. Please find attached a patch. Committed. Thanks! I found another typo in postgres_fdw.c. Attached is

Re: [HACKERS] Typo in comment in contrib/postgres_fdw/deparse.c

2016-11-01 Thread Robert Haas
On Tue, Nov 1, 2016 at 8:20 AM, Etsuro Fujita wrote: > I ran into a typo in a comment in contrib/postgres_fdw/deparse.c. Please > find attached a patch. Committed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent

[HACKERS] Typo in comment in contrib/postgres_fdw/deparse.c

2016-11-01 Thread Etsuro Fujita
Hi, I ran into a typo in a comment in contrib/postgres_fdw/deparse.c. Please find attached a patch. Best regards, Etsuro Fujita diff --git a/contrib/postgres_fdw/deparse.c b/contrib/postgres_fdw/deparse.c index 450693a..66b059a 100644 --- a/contrib/postgres_fdw/deparse.c +++

Re: [HACKERS] Typo in pgstat.c

2016-10-26 Thread Heikki Linnakangas
On 10/21/2016 04:06 AM, vinayak wrote: Attached patch fixes a typo in pgstat.c s/addtions/additions/g Fixed, thanks. - Heikki -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in pgstat.h

2016-10-26 Thread Heikki Linnakangas
On 10/21/2016 03:55 AM, vinayak wrote: - * st_progress_command_target, and st_progress_command[]. + * st_progress_command_target, and st_progress_param[]. Attached patch fixed typo. Fixed, thanks. - Heikki -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To

[HACKERS] Typo in pgstat.c

2016-10-20 Thread vinayak
Hi, Attached patch fixes a typo in pgstat.c s/addtions/additions/g Regards, Vinayak Pokale NTT Open Source Software Center typo-pgstat-c.patch Description: application/download -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

[HACKERS] Typo in pgstat.h

2016-10-20 Thread vinayak
Hi, - * st_progress_command_target, and st_progress_command[]. + * st_progress_command_target, and st_progress_param[]. Attached patch fixed typo. Regards, Vinayak Pokale NTT Open Source Software Center typo-pgstat-h.patch Description: application/download -- Sent via

Re: [HACKERS] Typo in foreign.h

2016-10-18 Thread Robert Haas
On Wed, Oct 12, 2016 at 9:20 PM, Amit Langote wrote: > Attached fixes a minor typo: s/Thes/These/g Committed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Typo in parallel.sqml

2016-10-13 Thread Tatsuo Ishii
> Indeed. It looks like a bad copy-pasto of two sentences gathered together. Thanks! I will commit/push to master and 9.6 stable branches. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp -- Sent via pgsql-hackers

Re: [HACKERS] Typo in parallel.sqml

2016-10-13 Thread Michael Paquier
On Fri, Oct 14, 2016 at 8:41 AM, Tatsuo Ishii wrote: > diff --git a/doc/src/sgml/parallel.sgml b/doc/src/sgml/parallel.sgml > index 7f8e902..02173da 100644 > --- a/doc/src/sgml/parallel.sgml > +++ b/doc/src/sgml/parallel.sgml > @@ -339,7 +339,7 @@ EXPLAIN SELECT * FROM

[HACKERS] Typo in parallel.sqml

2016-10-13 Thread Tatsuo Ishii
I think this is a typo. Since I am not an English native speaker, I would appreciate if someone confirm this. diff --git a/doc/src/sgml/parallel.sgml b/doc/src/sgml/parallel.sgml index 7f8e902..02173da 100644 --- a/doc/src/sgml/parallel.sgml +++ b/doc/src/sgml/parallel.sgml @@ -339,7 +339,7 @@

[HACKERS] Typo in foreign.h

2016-10-12 Thread Amit Langote
Attached fixes a minor typo: s/Thes/These/g Thanks, Amit diff --git a/src/include/foreign/foreign.h b/src/include/foreign/foreign.h index 5dc2c90..143566a 100644 --- a/src/include/foreign/foreign.h +++ b/src/include/foreign/foreign.h @@ -23,7 +23,7 @@ /* * Generic option types for

Re: [HACKERS] Typo in libpq-int.h

2016-09-22 Thread Heikki Linnakangas
On 09/22/2016 04:35 PM, Daniel Gustafsson wrote: Ran into a typo in libpq-int.h while reading/hacking: - char *gsslib; /* What GSS librart to use ("gssapi" or + char *gsslib; /* What GSS library to use ("gssapi” or Patch

[HACKERS] Typo in libpq-int.h

2016-09-22 Thread Daniel Gustafsson
Ran into a typo in libpq-int.h while reading/hacking: - char *gsslib; /* What GSS librart to use ("gssapi" or + char *gsslib; /* What GSS library to use ("gssapi” or Patch attached. cheers ./daniel typo-libpq-int.diff

Re: [HACKERS] Typo in pgstat.h

2016-09-21 Thread Peter Eisentraut
On 9/21/16 10:04 AM, Michael Paquier wrote: > While going through pgstat.h I bumped into that: > - * as 4-bytes where first byte repersents the wait event class (type of > + * as 4-bytes where first byte represents the wait event class (type of Fixed. There was actually another one of the same a

[HACKERS] Typo in pgstat.h

2016-09-21 Thread Michael Paquier
Hi all, While going through pgstat.h I bumped into that: - * as 4-bytes where first byte repersents the wait event class (type of + * as 4-bytes where first byte represents the wait event class (type of Regards, -- Michael diff --git a/src/include/pgstat.h b/src/include/pgstat.h index

Re: [HACKERS] Typo in filename identification

2016-09-12 Thread Simon Riggs
On 11 September 2016 at 23:56, Daniel Gustafsson wrote: > The IDENTIFICATION filename in src/backend/storage/ipc/dsm_impl.c is > incorrectly labelling the file dsm.c. Patch fixing the typo attached. > > cheers ./daniel Applied, thanks. -- Simon Riggs

[HACKERS] Typo in filename identification

2016-09-11 Thread Daniel Gustafsson
The IDENTIFICATION filename in src/backend/storage/ipc/dsm_impl.c is incorrectly labelling the file dsm.c. Patch fixing the typo attached. cheers ./daniel typo-dsm_impl_identification.diff Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] Typo in comment to function LockHasWaitersRelation() [master branch]

2016-08-22 Thread Robert Haas
On Mon, Aug 22, 2016 at 9:01 AM, Dmitry Ivanov wrote: >> Hi hackers, >> >> I've found a typo in a comment to function LockHasWaitersRelation() [lmgr.c >> : >> 271, master branch]: >> >> This is a functiion to check > > Attached a patch. Thanks. Committed with a bit of

Re: [HACKERS] Typo in comment to function LockHasWaitersRelation() [master branch]

2016-08-22 Thread Dmitry Ivanov
> Hi hackers, > > I've found a typo in a comment to function LockHasWaitersRelation() [lmgr.c > : > 271, master branch]: > >> This is a functiion to check Attached a patch. -- Dmitry Ivanov Postgres Professional: http://www.postgrespro.com Russian Postgres Companydiff --git

[HACKERS] Typo in comment to function LockHasWaitersRelation() [master branch]

2016-08-22 Thread Dmitry Ivanov
Hi hackers, I've found a typo in a comment to function LockHasWaitersRelation() [lmgr.c : 271, master branch]: >> This is a functiion to check -- Dmitry Ivanov Postgres Professional: http://www.postgrespro.com Russian Postgres Company -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Typo Patch

2016-07-05 Thread Alvaro Herrera
CharSyam wrote: > Yes, Some typos problems, It is hard to figure them out. > But in this patch, guranteed is just misspelling of guaranteed. I agree with Robert: the sentence as a whole makes no sense: * We need to check all possible distances, so reset Lpos * to

Re: [HACKERS] Typo Patch

2016-07-05 Thread David G. Johnston
On Tue, Jul 5, 2016 at 11:54 AM, Robert Haas wrote: > On Sat, Jul 2, 2016 at 12:17 PM, CharSyam wrote: > > I fixed typos. and attached patch for this. > > Thanks. > > > > I only changed comments only in src/backend/utils/adt/tsvector_op.c > > Well,

Re: [HACKERS] Typo Patch

2016-07-05 Thread CharSyam
Yes, Some typos problems, It is hard to figure them out. But in this patch, guranteed is just misspelling of guaranteed. Thanks. 2016-07-06 0:54 GMT+09:00 Robert Haas : > On Sat, Jul 2, 2016 at 12:17 PM, CharSyam wrote: > > I fixed typos. and attached

Re: [HACKERS] Typo Patch

2016-07-05 Thread Robert Haas
On Sat, Jul 2, 2016 at 12:17 PM, CharSyam wrote: > I fixed typos. and attached patch for this. > Thanks. > > I only changed comments only in src/backend/utils/adt/tsvector_op.c Well, that's definitely a typo. However, typo or no typo, it's hard for me to figure out with any

[HACKERS] Typo Patch

2016-07-02 Thread CharSyam
Hi, I fixed typos. and attached patch for this. Thanks. I only changed comments only in src/backend/utils/adt/tsvector_op.c typos.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Typo in parallel comment of heap_delete()

2016-06-17 Thread Robert Haas
On Thu, Jun 16, 2016 at 12:32 AM, Thomas Munro wrote: > On Tue, Jun 7, 2016 at 12:00 AM, Robert Haas wrote: >> On Sun, Jun 5, 2016 at 4:39 PM, Jim Nasby wrote: >>> I'm pretty sure this is a typo... >> >> Sure is.

Re: [HACKERS] Typo in parallel comment of heap_delete()

2016-06-15 Thread Thomas Munro
On Tue, Jun 7, 2016 at 12:00 AM, Robert Haas wrote: > On Sun, Jun 5, 2016 at 4:39 PM, Jim Nasby wrote: >> I'm pretty sure this is a typo... > > Sure is. Thanks. The same typo appears in heap_update. PS Far be it from me, but postgres_fdw.c

Re: [HACKERS] Typo in pg_visibility

2016-06-08 Thread Robert Haas
On Tue, Jun 7, 2016 at 8:45 PM, Amit Langote wrote: > On 2016/06/08 9:38, Amit Langote wrote: >> Attached fixes a typo: >> >> s/PG_ALL_VISIBLE/PD_ALL_VISIBLE/g > > Oops. Made a couple of mistakes there: > > Subject: Typo in pg_visibility documentation > Patch:

Re: [HACKERS] Typo in pg_visibility

2016-06-07 Thread Amit Langote
On 2016/06/08 9:38, Amit Langote wrote: > Attached fixes a typo: > > s/PG_ALL_VISIBLE/PD_ALL_VISIBLE/g Oops. Made a couple of mistakes there: Subject: Typo in pg_visibility documentation Patch: Really attached this time. Thanks, Amit diff --git a/doc/src/sgml/pgvisibility.sgml

[HACKERS] Typo in pg_visibility

2016-06-07 Thread Amit Langote
Attached fixes a typo: s/PG_ALL_VISIBLE/PD_ALL_VISIBLE/g Thanks, Amit -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in parallel comment of heap_delete()

2016-06-06 Thread Robert Haas
On Sun, Jun 5, 2016 at 4:39 PM, Jim Nasby wrote: > I'm pretty sure this is a typo... Sure is. Thanks. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)

[HACKERS] Typo in parallel comment of heap_delete()

2016-06-05 Thread Jim Nasby
I'm pretty sure this is a typo... -- Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX Experts in Analytics, Data Architecture and PostgreSQL Data in Trouble? Get it in Treble! http://BlueTreble.com 855-TREBLE2 (855-873-2532) mobile: 512-569-9461 diff --git

Re: [HACKERS] Typo in comment in nbtree.h

2016-06-02 Thread Kevin Grittner
On Wed, Jun 1, 2016 at 4:08 PM, Thomas Munro wrote: > Maybe it should be like this? > > --- a/src/include/access/nbtree.h > +++ b/src/include/access/nbtree.h > @@ -522,7 +522,7 @@ typedef struct BTScanPosData > Buffer buf;/* if

[HACKERS] Typo in comment in nbtree.h

2016-06-01 Thread Thomas Munro
Hi Following along with a btree bug report, I saw a typo "referencd" in a comment. Also "we've" seems a bit odd here, but maybe it's just me. Maybe it should be like this? --- a/src/include/access/nbtree.h +++ b/src/include/access/nbtree.h @@ -522,7 +522,7 @@ typedef struct BTScanPosData

Re: [HACKERS] Typo in 001_initdb.pl

2016-05-23 Thread Stephen Frost
* Michael Paquier (michael.paqu...@gmail.com) wrote: > On Mon, May 23, 2016 at 5:05 PM, Tom Lane wrote: > > Michael Paquier writes: > >> I just bumped into the following typo for $subject: > >> - 'role names cannot being with "pg_"'); > >> +

  1   2   3   >