[HACKERS] uncataloged tables are a vestigial husk

2012-06-13 Thread Robert Haas
While working on some code today, I noticed that RELKIND_UNCATALOGED appears to serve no useful purpose. In the few places where we check for it at all, we treat it in exactly the same way as RELKIND_RELATION. It seems that it's only purpose is to serve as a placeholder inside each newly-created

Re: [HACKERS] uncataloged tables are a vestigial husk

2012-06-13 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: While working on some code today, I noticed that RELKIND_UNCATALOGED appears to serve no useful purpose. In the few places where we check for it at all, we treat it in exactly the same way as RELKIND_RELATION. It seems that it's only purpose is to

Re: [HACKERS] uncataloged tables are a vestigial husk

2012-06-13 Thread Robert Haas
On Wed, Jun 13, 2012 at 1:13 PM, Tom Lane t...@sss.pgh.pa.us wrote: The attached patch cleans it up by removing RELKIND_UNCATALOGED and teaching RelationBuildLocalRelation() to set the relkind itself. I think there are probably some places to fix in the docs too. catalogs.sgml doesn't include

Re: [HACKERS] uncataloged tables are a vestigial husk

2012-06-13 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Wed, Jun 13, 2012 at 1:13 PM, Tom Lane t...@sss.pgh.pa.us wrote: The attached patch cleans it up by removing RELKIND_UNCATALOGED and teaching RelationBuildLocalRelation() to set the relkind itself. I think there are probably some places to fix in