Re: [HACKERS] unused code in float8_to_char , formatting.c ?

2013-12-02 Thread Robert Haas
On Sat, Nov 30, 2013 at 9:01 PM, Bruce Momjian wrote: > On Sun, Apr 7, 2013 at 12:14:29AM -0400, Robert Haas wrote: >> On Thu, Apr 4, 2013 at 6:47 PM, Greg Jaskiewicz wrote: >> > Looking around the code Today, one of my helpful tools detected this dead >> > code. >> > As far as I can see, it is

Re: [HACKERS] unused code in float8_to_char , formatting.c ?

2013-11-30 Thread Bruce Momjian
On Sun, Apr 7, 2013 at 12:14:29AM -0400, Robert Haas wrote: > On Thu, Apr 4, 2013 at 6:47 PM, Greg Jaskiewicz wrote: > > Looking around the code Today, one of my helpful tools detected this dead > > code. > > As far as I can see, it is actually unused call to strlen() in > > formatting.c, float

Re: [HACKERS] unused code in float8_to_char , formatting.c ?

2013-04-08 Thread Greg Jaskiewicz
On 7 Apr 2013, at 05:14, Robert Haas wrote: > On Thu, Apr 4, 2013 at 6:47 PM, Greg Jaskiewicz wrote: >> Looking around the code Today, one of my helpful tools detected this dead >> code. >> As far as I can see, it is actually unused call to strlen() in formatting.c, >> float8_to_char(). > >

Re: [HACKERS] unused code in float8_to_char , formatting.c ?

2013-04-06 Thread Robert Haas
On Thu, Apr 4, 2013 at 6:47 PM, Greg Jaskiewicz wrote: > Looking around the code Today, one of my helpful tools detected this dead > code. > As far as I can see, it is actually unused call to strlen() in formatting.c, > float8_to_char(). I poked at this a little and suggest the following somewh

[HACKERS] unused code in float8_to_char , formatting.c ?

2013-04-05 Thread Greg Jaskiewicz
Hi Guys, Looking around the code Today, one of my helpful tools detected this dead code. As far as I can see, it is actually unused call to strlen() in formatting.c, float8_to_char(). Diff attached. formatting_dead_code.diff Description: Binary data -- GJ -- Sent via pgsql-hackers