Re: [HACKERS] Unused variable scanned_tuples in LVRelStats

2017-08-03 Thread Masahiko Sawada
On Fri, Aug 4, 2017 at 3:01 AM, Robert Haas wrote: > On Thu, Aug 3, 2017 at 1:10 AM, Masahiko Sawada wrote: >> So we can remove scanned_tuples from LVRelStats struct and change the >> variable name num_tuples to scanned_tuples. Attached updated

Re: [HACKERS] Unused variable scanned_tuples in LVRelStats

2017-08-03 Thread Robert Haas
On Thu, Aug 3, 2017 at 1:10 AM, Masahiko Sawada wrote: > So we can remove scanned_tuples from LVRelStats struct and change the > variable name num_tuples to scanned_tuples. Attached updated patch. On second thought, I think we should just leave this alone. scanned_tuples

Re: [HACKERS] Unused variable scanned_tuples in LVRelStats

2017-08-02 Thread Masahiko Sawada
On Wed, Aug 2, 2017 at 11:40 PM, Robert Haas wrote: > On Tue, Jul 4, 2017 at 10:13 PM, Masahiko Sawada > wrote: >> scanned_tuples variable in LVRelStats is introduced by commit b4b6923e >> but it seems to me that it's actually not used. We store

Re: [HACKERS] Unused variable scanned_tuples in LVRelStats

2017-08-02 Thread Robert Haas
On Tue, Jul 4, 2017 at 10:13 PM, Masahiko Sawada wrote: > scanned_tuples variable in LVRelStats is introduced by commit b4b6923e > but it seems to me that it's actually not used. We store num_tuples > into vacrelstats->scanned_tuples after scanned all blocks, and the >

[HACKERS] Unused variable scanned_tuples in LVRelStats

2017-07-04 Thread Masahiko Sawada
Hi, scanned_tuples variable in LVRelStats is introduced by commit b4b6923e but it seems to me that it's actually not used. We store num_tuples into vacrelstats->scanned_tuples after scanned all blocks, and the comment mentioned that saving it in order to use later but we actually use num_tuples

Re: [HACKERS] Unused variable in postgres_fdw/deparse.c

2016-10-26 Thread Kyotaro HORIGUCHI
Thank you. At Wed, 26 Oct 2016 10:20:28 -0400, Tom Lane wrote in <17387.1477491...@sss.pgh.pa.us> > Kyotaro HORIGUCHI writes: > > Hello, compiler complains about unused variable during build > > postgres_fdw without assertions

Re: [HACKERS] Unused variable in postgres_fdw/deparse.c

2016-10-26 Thread Kyotaro HORIGUCHI
Hi, At Wed, 26 Oct 2016 11:00:17 +0530, Ashutosh Bapat wrote in > On Wed, Oct 26, 2016 at 6:19 AM, Kyotaro HORIGUCHI > wrote: > Thanks for the patch and sorry

Re: [HACKERS] Unused variable in postgres_fdw/deparse.c

2016-10-26 Thread Tom Lane
Kyotaro HORIGUCHI writes: > Hello, compiler complains about unused variable during build > postgres_fdw without assertions (!--enable-cassert). > The attched patch removes it and moves into the assertion below it. Pushed, thanks. regards,

Re: [HACKERS] Unused variable in postgres_fdw/deparse.c

2016-10-25 Thread Ashutosh Bapat
On Wed, Oct 26, 2016 at 6:19 AM, Kyotaro HORIGUCHI wrote: > Hello, compiler complains about unused variable during build > postgres_fdw without assertions (!--enable-cassert). > > deparse.c: In function ‘deparseFromExpr’: > deparse.c:1029:14: warning: unused

[HACKERS] Unused variable in postgres_fdw/deparse.c

2016-10-25 Thread Kyotaro HORIGUCHI
Hello, compiler complains about unused variable during build postgres_fdw without assertions (!--enable-cassert). deparse.c: In function ‘deparseFromExpr’: deparse.c:1029:14: warning: unused variable ‘foreignrel’ [-Wunused-variable] RelOptInfo *foreignrel = context->foreignrel;

Re: [HACKERS] Unused variable in hashpage.c

2015-04-03 Thread Tom Lane
Petr Jelinek p...@2ndquadrant.com writes: my compiler complains about unused variable nblkno in _hash_splitbucket in no-assert build. It looks like relic of commit ed9cc2b5d which removed the only use of that variable besides the Assert. Fixed, thanks! regards, tom

[HACKERS] Unused variable in hashpage.c

2015-04-02 Thread Petr Jelinek
Hi, my compiler complains about unused variable nblkno in _hash_splitbucket in no-assert build. It looks like relic of commit ed9cc2b5d which removed the only use of that variable besides the Assert. Looking at the code: nblkno = start_nblkno; Assert(nblkno ==

Re: [HACKERS] unused variable

2004-07-21 Thread Bruce Momjian
Fixed in CVS. --- Gaetano Mendola wrote: Hi all, I'm compiling the last postgres CVS version and I get: vacuum.c: In function `repair_frag': vacuum.c:1528: warning: unused variable `myXID' Regards Gaetano

Re: [HACKERS] unused variable

2004-07-20 Thread Bruce Momjian
OK, it turns out myXID is only used by Assert tests, and most developers compile with Asserts. I have fixed this by defining the variable only when asserts are enabled. Patch attached and applied. --- Gaetano Mendola

[HACKERS] unused variable

2004-07-20 Thread Gaetano Mendola
Hi all, I'm compiling the last postgres CVS version and I get: vacuum.c: In function `repair_frag': vacuum.c:1528: warning: unused variable `myXID' Regards Gaetano Mendola ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to

[HACKERS] unused variable

2004-07-17 Thread Gaetano Mendola
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi all, I'm compiling the last postgres CVS version and I get: vacuum.c: In function `repair_frag': vacuum.c:1528: warning: unused variable `myXID' Regards Gaetano Mendola -BEGIN PGP SIGNATURE- Version: GnuPG v1.2.4 (MingW32) Comment: Using