Re: [HACKERS] valgrind error in subscription code

2017-04-23 Thread Andres Freund
On 2017-04-22 21:08:18 +0200, Petr Jelinek wrote: > On 22/04/17 20:31, Andres Freund wrote: > > Hi, > > > > I enabled skink / the valgrind animal to run the tap tests too (hugely > > increasing the test time :(), and that paid of: > >

Re: [HACKERS] valgrind error in subscription code

2017-04-23 Thread Petr Jelinek
On 22/04/17 21:16, Andres Freund wrote: > Hi, > > On 2017-04-22 21:08:18 +0200, Petr Jelinek wrote: >> Thanks, here is patch to fix that - I also removed the individual >> settings of everything to NULL/0/InvalidOid etc and just replaced it all >> with memset. > > Cool. > >> diff --git

Re: [HACKERS] valgrind error in subscription code

2017-04-22 Thread Andres Freund
Hi, On 2017-04-22 21:08:18 +0200, Petr Jelinek wrote: > Thanks, here is patch to fix that - I also removed the individual > settings of everything to NULL/0/InvalidOid etc and just replaced it all > with memset. Cool. > diff --git a/src/backend/replication/logical/relation.c >

Re: [HACKERS] valgrind error in subscription code

2017-04-22 Thread Petr Jelinek
On 22/04/17 20:31, Andres Freund wrote: > Hi, > > I enabled skink / the valgrind animal to run the tap tests too (hugely > increasing the test time :(), and that paid of: > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink=2017-04-22%2004%3A52%3A13 > > ==606== VALGRINDERROR-BEGIN >

[HACKERS] valgrind error in subscription code

2017-04-22 Thread Andres Freund
Hi, I enabled skink / the valgrind animal to run the tap tests too (hugely increasing the test time :(), and that paid of: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink=2017-04-22%2004%3A52%3A13 ==606== VALGRINDERROR-BEGIN ==606== Conditional jump or move depends on uninitialised