Re: [HACKERS] volatile markings to silence compilers

2011-03-17 Thread Tom Lane
Martijn van Oosterhout writes: > It appears the issue is mostly that the compiler is unable to prove > that the variables aren't changed. IME, older versions of gcc will warn about any variable that's assigned more than once, even if those assignments are before the setjmp call. Presumably this i

Re: [HACKERS] volatile markings to silence compilers

2011-03-17 Thread Robert Haas
On Thu, Mar 17, 2011 at 12:36 AM, Bruce Momjian wrote: > Looking over the release notes, we have added a few 'volatile' storage > specifications to variables which are near longjump/TRY blocks to > silence compilers.  I am worried that these specifications don't clearly > identify their purpose.  

Re: [HACKERS] volatile markings to silence compilers

2011-03-17 Thread Martijn van Oosterhout
On Thu, Mar 17, 2011 at 12:36:59AM -0400, Bruce Momjian wrote: > Looking over the release notes, we have added a few 'volatile' storage > specifications to variables which are near longjump/TRY blocks to > silence compilers. I am worried that these specifications don't clearly > identify their pur

[HACKERS] volatile markings to silence compilers

2011-03-16 Thread Bruce Momjian
Looking over the release notes, we have added a few 'volatile' storage specifications to variables which are near longjump/TRY blocks to silence compilers. I am worried that these specifications don't clearly identify their purpose. Can we rename these to use a macro for 'volatile' that will make