Re: [HACKERS] vpath builds and verbose error messages

2011-11-27 Thread Peter Eisentraut
On lör, 2011-11-26 at 10:45 -0500, Tom Lane wrote: > Peter Eisentraut writes: > > On fre, 2011-11-18 at 09:44 -0500, Tom Lane wrote: > >> It wouldn't be that hard for elog.c to do strrchr(fname, '/') or > >> something like that, > > > Here is a patch for that. I would also like to backpatch this

Re: [HACKERS] vpath builds and verbose error messages

2011-11-26 Thread Tom Lane
Peter Eisentraut writes: > On fre, 2011-11-18 at 09:44 -0500, Tom Lane wrote: >> It wouldn't be that hard for elog.c to do strrchr(fname, '/') or >> something like that, > Here is a patch for that. I would also like to backpatch this. Hmmm ... is it possible that strrchr could change errno? If

Re: [HACKERS] vpath builds and verbose error messages

2011-11-26 Thread Peter Eisentraut
On fre, 2011-11-18 at 09:44 -0500, Tom Lane wrote: > It wouldn't be that hard for elog.c to do strrchr(fname, '/') or > something like that, Here is a patch for that. I would also like to backpatch this. diff --git i/src/backend/utils/error/elog.c w/src/backend/utils/error/elog.c index 9a99fc7..

Re: [HACKERS] vpath builds and verbose error messages

2011-11-22 Thread Tom Lane
Peter Eisentraut writes: > One thing that isn't so nice about all this is that it embeds the > personal directory structure of the builder of the binary into the > shipped product. But gcc's cpp doesn't like redefining __FILE__, so the > only way to get around that altogether would be to use some

Re: [HACKERS] vpath builds and verbose error messages

2011-11-22 Thread Alvaro Herrera
Excerpts from Peter Eisentraut's message of mar nov 22 16:22:15 -0300 2011: > One thing that isn't so nice about all this is that it embeds the > personal directory structure of the builder of the binary into the > shipped product. But gcc's cpp doesn't like redefining __FILE__, so the > only wa

Re: [HACKERS] vpath builds and verbose error messages

2011-11-22 Thread Peter Eisentraut
On fre, 2011-11-18 at 09:44 -0500, Tom Lane wrote: > It wouldn't be that hard for elog.c to do strrchr(fname, '/') or > something like that, but the idea that there are hundreds of full-path > strings embedded in the executable is a bit annoying. I guess we > could > hope that the compiler is brig

Re: [HACKERS] vpath builds and verbose error messages

2011-11-18 Thread Tom Lane
Alvaro Herrera writes: > Excerpts from Peter Eisentraut's message of vie nov 18 01:34:18 -0300 2011: >> When using verbose error messages (psql \set VERBOSITY verbose) with a >> vpath build, you get this sort of thing: >> LOCATION: transformColumnRef, >> /build/buildd-postgresql-9.1_9.1.1-3-i386

Re: [HACKERS] vpath builds and verbose error messages

2011-11-18 Thread Alvaro Herrera
Excerpts from Peter Eisentraut's message of vie nov 18 01:34:18 -0300 2011: > When using verbose error messages (psql \set VERBOSITY verbose) with a > vpath build, you get this sort of thing: > > ERROR: 42703: column "foo" does not exist > LINE 1: select foo; >^ > LOCATION: tran

[HACKERS] vpath builds and verbose error messages

2011-11-17 Thread Peter Eisentraut
When using verbose error messages (psql \set VERBOSITY verbose) with a vpath build, you get this sort of thing: ERROR: 42703: column "foo" does not exist LINE 1: select foo; ^ LOCATION: transformColumnRef, /build/buildd-postgresql-9.1_9.1.1-3-i386-AP0ovQ/postgresql-9.1-9.1.1/buil