Re: [HACKERS] waitpid in pg_basebackup

2012-07-05 Thread Tom Lane
Fujii Masao writes: > On Fri, Jul 6, 2012 at 2:01 AM, Tom Lane wrote: >> I will go ahead and remove that code. > Thanks! > BTW, I was just implementing the patch ;) Patch attached. Oh, I'd already done it when I got your message :-(. Looks like we arrived at the same answers, though, except f

Re: [HACKERS] waitpid in pg_basebackup

2012-07-05 Thread Fujii Masao
On Fri, Jul 6, 2012 at 2:01 AM, Tom Lane wrote: > I wrote: >> I agree, let's drop the support for waitpid() not being present. > > BTW, some digging in the commit logs shows that postmaster.c's > existing support for using wait3 in place of waitpid was added in > commit a5494a2d92a2752c610b8b668a7

Re: [HACKERS] waitpid in pg_basebackup

2012-07-05 Thread Tom Lane
I wrote: > I agree, let's drop the support for waitpid() not being present. BTW, some digging in the commit logs shows that postmaster.c's existing support for using wait3 in place of waitpid was added in commit a5494a2d92a2752c610b8b668a7d33478e90c160, "Various patches for nextstep by GregorHoffl

Re: [HACKERS] waitpid in pg_basebackup

2012-07-04 Thread Tom Lane
Fujii Masao writes: > waitpid() is used with "#ifdef HAVE_WAITPID" in reaper(), but NOT in > BaseBackup(). > Why not? We can ensure that all platforms which PostgreSQL supports > have waitpid()? > If so, can we get rid of "#ifdef HAVE_WAITPID" in reaper()? The Single Unix Spec V2 (1997) specifies

[HACKERS] waitpid in pg_basebackup

2012-07-04 Thread Fujii Masao
Hi, waitpid() is used with "#ifdef HAVE_WAITPID" in reaper(), but NOT in BaseBackup(). Why not? We can ensure that all platforms which PostgreSQL supports have waitpid()? If so, can we get rid of "#ifdef HAVE_WAITPID" in reaper()? Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list