Re: [PATCHES] [HACKERS] Hint Bits and Write I/O

2008-06-27 Thread Heikki Linnakangas
Gregory Stark wrote: I'm also a bit concerned that *how many hint bits* isn't enough information to determine how important it is to write out the page. Agreed, that doesn't seem like a very good metric to me either. Or how many *unhinted* xmin/xmax values were found? If HTSV can hint xmin

Re: [PATCHES] [HACKERS] Hint Bits and Write I/O

2008-06-18 Thread Alvaro Herrera
Simon Riggs wrote: When running a VACUUM command we always dirty the block when setting hint bits, for a number of reasons: * VACUUM FULL expects all hint bits to be set prior to moving tuples * Setting all hint bits allows us to truncate the clog * it forces the VACUUM to write out its own

Re: [PATCHES] [HACKERS] Hint Bits and Write I/O

2008-06-18 Thread Simon Riggs
On Wed, 2008-06-18 at 14:53 +0100, Simon Riggs wrote: There is one minor strangeness in the patch, which is the change of initdb's command order when vacuuming database template1. With the previous ordering of ANALYZE; VACUUM FULL; VACUUM; the flexible hint bit setting of the ANALYZE on a