Re: [PATCHES] [HACKERS] plperl Safe restrictions

2004-12-02 Thread Greg Stark
Andrew Dunstan [EMAIL PROTECTED] writes: John wanted us to allow use of the 'locale' and 'utf8' pragmas in trusted code. You know, there's something twisted in postgres's naming scheme here. How is it that trusted languages the ones that need a sandbox? and untrusted languages the ones that

Re: [PATCHES] [HACKERS] plperl Safe restrictions

2004-12-02 Thread Rod Taylor
On Thu, 2004-12-02 at 02:21 -0500, Greg Stark wrote: Andrew Dunstan [EMAIL PROTECTED] writes: John wanted us to allow use of the 'locale' and 'utf8' pragmas in trusted code. You know, there's something twisted in postgres's naming scheme here. How is it that trusted languages the ones

Re: [PATCHES] [HACKERS] plperl Safe restrictions

2004-12-01 Thread Bruce Momjian
Uh, what was the TODO here? I forgot. --- John Hansen wrote: I think it is *way* too late in the dev cycle to be proposing this. Maybe it should be a TODO item - I at least don't have time even to think about the

Re: [PATCHES] [HACKERS] plperl Safe restrictions

2004-12-01 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: Uh, what was the TODO here? I forgot. I think we already did what we decided was safe there. regards, tom lane ---(end of broadcast)--- TIP 5: Have you checked our extensive FAQ?

Re: [PATCHES] [HACKERS] plperl Safe restrictions

2004-12-01 Thread Andrew Dunstan
Bruce Momjian said: Uh, what was the TODO here? I forgot. John wanted us to allow use of the 'locale' and 'utf8' pragmas in trusted code. If there's a TODO it would be to investigate the possibility, as I am very far from certain that there is a simple way to do it safely right now. Maybe

Re: [PATCHES] [HACKERS] plperl Safe restrictions

2004-11-16 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: It has just been brought to my attention that we are being very restrictive about what we allow to be done in trusted plperl. ... OK, based on this and some further thought, I have prepared the attached patch which does the right thing, I think,

Re: [PATCHES] [HACKERS] plperl Safe restrictions

2004-11-16 Thread John Hansen
Applied, with changes to allow srand and disallow sprintf, as per subsequent discussion. How about allowing: use utf8; use locale; ? Kind Regards, John ---(end of broadcast)--- TIP 6: Have you searched our list archives?

Re: [PATCHES] [HACKERS] plperl Safe restrictions

2004-11-16 Thread Andrew Dunstan
John Hansen wrote: Applied, with changes to allow srand and disallow sprintf, as per subsequent discussion. How about allowing: use utf8; use locale; ? I think it is *way* too late in the dev cycle to be proposing this. Maybe it should be a TODO item - I at least don't have time even

Re: [PATCHES] [HACKERS] plperl Safe restrictions

2004-11-16 Thread John Hansen
I think it is *way* too late in the dev cycle to be proposing this. Maybe it should be a TODO item - I at least don't have time even to think about the implications os using these pragmas. The effect of the first is achievable via an environment setting, I believe. If you need these

Re: [PATCHES] [HACKERS] plperl Safe restrictions

2004-11-11 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. ---

Re: [PATCHES] [HACKERS] plperl Safe restrictions

2004-11-11 Thread Bruce Momjian
Andrew Dunstan wrote: ... The patch also does some other inconsequential tidying of overlong lines, and removes some unnecessary ops in the unsafe case. These are basically cosmetic - the only significant part is replacing this: $PLContainer-permit(':base_math'); with

Re: [PATCHES] [HACKERS] plperl Safe restrictions

2004-11-11 Thread Andrew Dunstan
Bruce Momjian wrote: Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it.