Re: Install extensions using update scripts (was Re: [HACKERS] Remove superuser() checks from pgstattuple)

Pushed with adjustments for the review points. Hopefully this will make Stephen's life easier, along with others submitting contrib-module updates. We should urge anyone who submits an old-style extension update patch to consider whether they really want to bother with a new base script. At

Re: Install extensions using update scripts (was Re: [HACKERS] Remove superuser() checks from pgstattuple)

Andres Freund writes: > On 2016-09-07 09:46:32 -0400, Tom Lane wrote: >> + * If reject_indirect is true, ignore paths that go through installable >> + * versions (presumably, caller will consider starting from such versions). > Reading this I was initially confused, only

Re: Install extensions using update scripts (was Re: [HACKERS] Remove superuser() checks from pgstattuple)

On 2016-09-07 13:44:28 -0400, Tom Lane wrote: > + > +Installing Extensions using Update Scripts > + > + > + An extension that has been around for awhile will probably exist in Wanted to cry typo for 'awhile' here, but apparently that's actually a word. The German in me is pleased.

Re: Install extensions using update scripts (was Re: [HACKERS] Remove superuser() checks from pgstattuple)

Hi, On 2016-09-07 09:46:32 -0400, Tom Lane wrote: > At this point it's awfully tempting to make ALTER EXTENSION UPDATE grow > a CASCADE option to allow automatic installation of new requirements > of the new version, but I didn't do that here. Sounds like a plan. After the refactoring that

Re: Install extensions using update scripts (was Re: [HACKERS] Remove superuser() checks from pgstattuple)

I wrote: > Still no SGML doc updates. And here's a doc addition. regards, tom lane diff --git a/doc/src/sgml/extend.sgml b/doc/src/sgml/extend.sgml index df88380..1c8c420 100644 *** a/doc/src/sgml/extend.sgml --- b/doc/src/sgml/extend.sgml *** SELECT * FROM

Re: Install extensions using update scripts (was Re: [HACKERS] Remove superuser() checks from pgstattuple)

Andres Freund writes: > On 2016-09-05 22:24:09 -0400, Tom Lane wrote: >> Ordinarily I'd be willing to stick this on the queue for the next >> commitfest, but it seems like we ought to try to get it pushed now >> so that Stephen can make use of the feature for his superuser

Re: Install extensions using update scripts (was Re: [HACKERS] Remove superuser() checks from pgstattuple)

On 2016-09-05 22:24:09 -0400, Tom Lane wrote: > Ordinarily I'd be willing to stick this on the queue for the next > commitfest, but it seems like we ought to try to get it pushed now > so that Stephen can make use of the feature for his superuser changes. > Thoughts? Seems sensible to me. I can

Install extensions using update scripts (was Re: [HACKERS] Remove superuser() checks from pgstattuple)

Andres Freund writes: > On September 4, 2016 6:33:30 PM PDT, Tom Lane wrote: >> I think nearly all of the >> infrastructure for this is already there in extension.c. > Yes, it doesn't sound very hard... I poked at this a bit, and indeed it's not that