Re: NaN/Inf fix for ECPG Re: [HACKERS] out-of-scope cursor errors

2010-02-04 Thread Michael Meskes
On Thu, Feb 04, 2010 at 03:55:06PM +0100, Boszormenyi Zoltan wrote: > I added the #include to the nan_test.pgc in the hope > it fixes the Windows machines in the buildfarm. I already commited this earlier today after looking at the problem myself. But of course I'm also just hoping as I do not ha

Re: NaN/Inf fix for ECPG Re: [HACKERS] out-of-scope cursor errors

2010-02-03 Thread Michael Meskes
On Wed, Feb 03, 2010 at 10:59:57AM +0100, Boszormenyi Zoltan wrote: > Also, another oversight needs fixing on my part, for which > the patch is atttached. The INSERT statement in nan_test.pgc > contains platform dependent strings, "inf" instead of "infinity". Committed. Michael -- Michael Meske

Re: NaN/Inf fix for ECPG Re: [HACKERS] out-of-scope cursor errors

2010-02-03 Thread Boszormenyi Zoltan
Michael Meskes írta: > On Tue, Feb 02, 2010 at 03:34:24PM +0100, Boszormenyi Zoltan wrote: > >> Here's the new patch with the updated regression test. >> > > Committed. Thanks a lot. > > Michael > Tom Lane committed a fix for Windows, there was a missing #include in execute.c, but ther

Re: NaN/Inf fix for ECPG Re: [HACKERS] out-of-scope cursor errors

2010-02-02 Thread Michael Meskes
On Tue, Feb 02, 2010 at 03:34:24PM +0100, Boszormenyi Zoltan wrote: > Here's the new patch with the updated regression test. Committed. Thanks a lot. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|P

Re: NaN/Inf fix for ECPG Re: [HACKERS] out-of-scope cursor errors

2010-02-02 Thread Boszormenyi Zoltan
Michael Meskes írta: > On Sat, Jan 30, 2010 at 11:09:34AM +0100, Boszormenyi Zoltan wrote: > >> After I sent it and reread my mail, I realized that my fix >> wouldn't be enough because of the above: ECPG uses sprintf() >> for float and double, and just like in the backend, a common >> code to se

Re: NaN/Inf fix for ECPG Re: [HACKERS] out-of-scope cursor errors

2010-02-02 Thread Michael Meskes
On Sat, Jan 30, 2010 at 11:09:34AM +0100, Boszormenyi Zoltan wrote: > After I sent it and reread my mail, I realized that my fix > wouldn't be enough because of the above: ECPG uses sprintf() > for float and double, and just like in the backend, a common > code to send "NaN" and +/- "Infinity" to t

Re: NaN/Inf fix for ECPG Re: [HACKERS] out-of-scope cursor errors

2010-01-30 Thread Boszormenyi Zoltan
Boszormenyi Zoltan írta: > - different UNIX(-like) platforms write out different strings in printf() > for a double variable storing. NaN. E.g.: Linux: "nan", > Solaris: "NaN", AIX: "NaNQ" > After I sent it and reread my mail, I realized that my fix wouldn't be enough because of the above:

NaN/Inf fix for ECPG Re: [HACKERS] out-of-scope cursor errors

2010-01-29 Thread Boszormenyi Zoltan
Michael Meskes írta: > On Fri, Jan 29, 2010 at 06:32:20AM +0100, Boszormenyi Zoltan wrote: > >> I know. Patches were already posted for that, >> waiting for Michael to review and apply it. >> > > Just came back from another trip. Patch works on my system, so I committed > it. > > Michael