Re: [HACKERS] [Proposal] Table partition + join pushdown

2016-01-27 Thread Robert Haas
On Mon, Jan 25, 2016 at 9:09 PM, Kouhei Kaigai wrote: > Of course, its implementation is not graceful enough, especially, above > point because this extra filter will change expected number of rows to > be produced by inner relation, and relevant cost. > Right now, his patch calls cost_seqscan() a

Re: [HACKERS] [Proposal] Table partition + join pushdown

2016-01-25 Thread Kouhei Kaigai
> On Tue, Jan 19, 2016 at 7:59 AM, Greg Stark wrote: > > On Mon, Jan 18, 2016 at 5:55 PM, Robert Haas wrote: > >> For > >> example, suppose that x and y are numeric columns and P(x) is > >> length(x::text) == 3. Then you could have 1 in one table and 1.0 in > >> the table; they join, but P(x) is

Re: [HACKERS] [Proposal] Table partition + join pushdown

2016-01-19 Thread Robert Haas
On Tue, Jan 19, 2016 at 7:59 AM, Greg Stark wrote: > On Mon, Jan 18, 2016 at 5:55 PM, Robert Haas wrote: >> For >> example, suppose that x and y are numeric columns and P(x) is >> length(x::text) == 3. Then you could have 1 in one table and 1.0 in >> the table; they join, but P(x) is true for on

Re: [HACKERS] [Proposal] Table partition + join pushdown

2016-01-19 Thread Greg Stark
On Mon, Jan 18, 2016 at 5:55 PM, Robert Haas wrote: > For > example, suppose that x and y are numeric columns and P(x) is > length(x::text) == 3. Then you could have 1 in one table and 1.0 in > the table; they join, but P(x) is true for one and false for the > other. Fwiw, ages ago there was so

Re: [HACKERS] [Proposal] Table partition + join pushdown

2016-01-18 Thread Robert Haas
On Tue, Dec 22, 2015 at 8:36 AM, Michael Paquier wrote: > On Fri, Nov 20, 2015 at 9:05 PM, Taiki Kondo wrote: >> I created v3 patch for this feature, and v1 patch for regression tests. >> Please find attached. >> >> [blah review and replies] >> >> Please find from attached patch. > > This new pat

Re: [HACKERS] [Proposal] Table partition + join pushdown

2015-12-22 Thread Michael Paquier
On Fri, Nov 20, 2015 at 9:05 PM, Taiki Kondo wrote: > I created v3 patch for this feature, and v1 patch for regression tests. > Please find attached. > > [blah review and replies] > > Please find from attached patch. This new patch did not actually get a review, moved to next CF. -- Michael --

Re: [HACKERS] [Proposal] Table partition + join pushdown

2015-11-25 Thread Kyotaro HORIGUCHI
Hello, sorry for late response and thank you for the new patch. At Fri, 20 Nov 2015 12:05:38 +, Taiki Kondo wrote in <12a9442fbae80d4e8953883e0b84e08863f...@bpxm01gp.gisp.nec.co.jp> > > I created v3 patch for this feature, and v1 patch for regression tests. > Please find attached. I think

Re: [HACKERS] [Proposal] Table partition + join pushdown

2015-11-20 Thread Taiki Kondo
ways child table. */ - if (em->em_is_child && + if (relids != NULL && + em->em_is_child && !bms_equal(em->em_relids, relids)) continue; It is a little bit hard to u

Re: [HACKERS] [Proposal] Table partition + join pushdown

2015-11-10 Thread Kouhei Kaigai
KaiGai Kohei > -Original Message- > From: pgsql-hackers-ow...@postgresql.org > [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Taiki Kondo > Sent: Wednesday, October 21, 2015 8:07 PM > To: Kaigai Kouhei(海外 浩平); Kyotaro HORIGUCHI > Cc: pgsql-hackers@postgresql.org; Y

Re: [HACKERS] [Proposal] Table partition + join pushdown

2015-10-21 Thread Taiki Kondo
Of Taiki Kondo > Sent: Thursday, October 08, 2015 5:28 PM > To: Kyotaro HORIGUCHI > Cc: Kaigai Kouhei(海外 浩平); Iwaasa Akio(岩浅 晃郎); > pgsql-hackers@postgresql.org > Subject: Re: [HACKERS] [Proposal] Table partition + join pushdown > > Hello, Horiguchi-san. > > Thank you f

Re: [HACKERS] [Proposal] Table partition + join pushdown

2015-10-15 Thread Taiki Kondo
r designing more cleanly. Best regards, -- Taiki Kondo NEC Solution Innovators, Ltd. -Original Message- From: Kyotaro HORIGUCHI [mailto:horiguchi.kyot...@lab.ntt.co.jp] Sent: Thursday, October 08, 2015 7:04 PM To: tai-ko...@yk.jp.nec.com Cc: kai...@ak.jp.nec.com; aki-iwa...@vt.jp.nec.com

Re: [HACKERS] [Proposal] Table partition + join pushdown

2015-10-14 Thread Kouhei Kaigai
tgresql.org > Subject: Re: [HACKERS] [Proposal] Table partition + join pushdown > > Hello, Horiguchi-san. > > Thank you for your comment. > > > I got some warning on compilation on unused variables and wrong > > arguemtn type. > > OK, I'll fix it. >

Re: [HACKERS] [Proposal] Table partition + join pushdown

2015-10-08 Thread Kyotaro HORIGUCHI
Hello, thank you for the example. I could see this patch working with it. > > In make_restrictinfos_from_check_constr, the function returns > > modified constraint predicates correspond to vars under > > hashjoinable join clauses. I don't think expression_tree_mutator > > is suitable to do that s

Re: [HACKERS] [Proposal] Table partition + join pushdown

2015-10-08 Thread Taiki Kondo
ondo NEC Solution Innovators, Ltd. -Original Message- From: Kyotaro HORIGUCHI [mailto:horiguchi.kyot...@lab.ntt.co.jp] Sent: Tuesday, October 06, 2015 8:35 PM To: tai-ko...@yk.jp.nec.com Cc: kai...@ak.jp.nec.com; aki-iwa...@vt.jp.nec.com; pgsql-hackers@postgresql.org Subject: Re: [HACK

Re: [HACKERS] [Proposal] Table partition + join pushdown

2015-10-06 Thread Kyotaro HORIGUCHI
Hello. I tried to read this and had some random comments on this. -- general I got some warning on compilation on unused variables and wrong arguemtn type. I failed to have a query that this patch works on. Could you let me have some specific example for this patch? This patch needs more comme

Re: [HACKERS] [Proposal] Table partition + join pushdown

2015-10-05 Thread Taiki Kondo
September 30, 2015 11:19 PM To: Kondo Taiki(近藤 太樹) Cc: Iwaasa Akio(岩浅 晃郎); pgsql-hackers@postgresql.org Subject: RE: [HACKERS] [Proposal] Table partition + join pushdown > > * Suppose we focus on only HashJoin in the first version? > > This patch also add support on NestLoop and MergeJoin

Re: [HACKERS] [Proposal] Table partition + join pushdown

2015-09-30 Thread Kouhei Kaigai
ards, > -- > Taiki Kondo > > NEC Solution Innovators, Ltd. > > > > -----Original Message- > From: pgsql-hackers-ow...@postgresql.org > [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Kouhei Kaigai > Sent: Tuesday, September 29, 2015 11:46 AM >

Re: [HACKERS] [Proposal] Table partition + join pushdown

2015-09-29 Thread Taiki Kondo
l.org [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Kouhei Kaigai Sent: Tuesday, September 29, 2015 11:46 AM To: Taiki Kondo Cc: Akio Iwaasa; pgsql-hackers@postgresql.org Subject: Re: [HACKERS] [Proposal] Table partition + join pushdown > -Original Message- > From: pgsql-h

Re: [HACKERS] [Proposal] Table partition + join pushdown

2015-09-28 Thread Kouhei Kaigai
Subject: Re: [HACKERS] [Proposal] Table partition + join pushdown > > Hello, KaiGai-san. > > Thank you for your comment, and sorry for late response. > > The attached patch is completely rewritten from previous patch[1], at your > suggestion[2]. > Please find attached. > Th

Re: [HACKERS] [Proposal] Table partition + join pushdown

2015-09-24 Thread Taiki Kondo
Hello, KaiGai-san. Thank you for your comment, and sorry for late response. The attached patch is completely rewritten from previous patch[1], at your suggestion[2]. Please find attached. This patch contains following implementation, but I can't determine this is correct or wrong. 1. Cost es

Re: [HACKERS] [Proposal] Table partition + join pushdown

2015-08-18 Thread Kouhei Kaigai
Hello Kondo-san, I briefly checked your patch. Let me put some comments about its design and implementation, even though I have no arguments towards its concept. :-) * Construction of RelOptInfo In your patch, try_hashjoin_pushdown() called by try_hashjoin_path() constructs RelOptInfo of the joi