Re: [HACKERS] Faster setup_param_list() in plpgsql

2015-07-02 Thread Tom Lane
I wrote: > What this patch does is to remove setup_param_list() overhead for the > common case of PLPGSQL_DTYPE_VAR variables (ie, any non-composite type). > It does that by the expedient of keeping the ParamExternData image of such > a variable valid at all times. That adds a few cycles to assign

Re: [HACKERS] Faster setup_param_list() in plpgsql

2015-04-30 Thread Pavel Stehule
Review: What this patch does - it change a mechanism, how a values of variables are transmitted to SPI. In previous variant values are copied to ParamListInfo before every evaluation of any expression. New mechanism is smarter. It refresh only ROW, REC values when are marked as dirty (when these v

Re: [HACKERS] Faster setup_param_list() in plpgsql

2015-04-30 Thread Pavel Stehule
2015-04-29 9:26 GMT+02:00 Pavel Stehule : > Hi all > > I am looking on this patch. I can confirm 10-15% speedup - and the idea > behind this patch looks well. > > This patch > http://www.postgresql.org/message-id/4146.1425872...@sss.pgh.pa.us > contains two parts > > a) relative large refactoring

Re: [HACKERS] Faster setup_param_list() in plpgsql

2015-03-15 Thread Andrew Dunstan
On 03/14/2015 06:04 PM, Tom Lane wrote: Given the rather hostile response I got to http://www.postgresql.org/message-id/4146.1425872...@sss.pgh.pa.us I was not planning to bring this topic up again until 9.6 development starts. However, as I said in that thread, this work is getting done now be