Tim Bunce writes:
> On Sun, Jan 10, 2010 at 01:16:13AM -0500, Tom Lane wrote:
>> Doesn't make forcibly remove the target file if the command fails?
> Andrew, perhaps you could apply the attached to fix that. (Or I could
> bundle it into one of the split out plperl feature patches.)
Applied.
On Sun, Jan 10, 2010 at 01:16:13AM -0500, Tom Lane wrote:
> Tim Bunce writes:
> > On Sat, Jan 09, 2010 at 11:16:18PM +0200, Peter Eisentraut wrote:
> >> What's the reason for the temp file here?
>
> > Defensive. If the text2macro.pl program fails/dies then you'd be left
> > with a broken output f
Tim Bunce writes:
> On Sat, Jan 09, 2010 at 11:16:18PM +0200, Peter Eisentraut wrote:
>> What's the reason for the temp file here?
> Defensive. If the text2macro.pl program fails/dies then you'd be left
> with a broken output file with a newer timestamp, so the next make
> wouldn't rerun text2mac
On sön, 2010-01-10 at 00:03 +, Tim Bunce wrote:
> On Sat, Jan 09, 2010 at 11:49:22PM +, Tim Bunce wrote:
> > On Sat, Jan 09, 2010 at 11:16:18PM +0200, Peter Eisentraut wrote:
> > > On fre, 2010-01-08 at 12:46 +, Tim Bunce wrote:
> > > > *** 45,50
> > > > --- 45,55
> > > >
>
On Sat, Jan 09, 2010 at 11:49:22PM +, Tim Bunce wrote:
> On Sat, Jan 09, 2010 at 11:16:18PM +0200, Peter Eisentraut wrote:
> > On fre, 2010-01-08 at 12:46 +, Tim Bunce wrote:
> > > *** 45,50
> > > --- 45,55
> > >
> > > include $(top_srcdir)/src/Makefile.shlib
> > >
> > > +
On Sat, Jan 09, 2010 at 11:16:18PM +0200, Peter Eisentraut wrote:
> On fre, 2010-01-08 at 12:46 +, Tim Bunce wrote:
> > *** 45,50
> > --- 45,55
> >
> > include $(top_srcdir)/src/Makefile.shlib
> >
> > + plperl.o: perlchunks.h
> > +
> > + perlchunks.h: plc_*.pl
> > + $(P
On Fri, Jan 08, 2010 at 09:47:01PM -0500, Andrew Dunstan wrote:
> Tim Bunce wrote:
> >
> >I see you've not commited it yet, so to help out I've attached
> >a new diff, over the current CVS head, with two minor changes:
> >
> >- Removed the test, as noted above.
> >- Optimized pg_verifymbstr calls t
On fre, 2010-01-08 at 12:46 +, Tim Bunce wrote:
> *** 45,50
> --- 45,55
>
> include $(top_srcdir)/src/Makefile.shlib
>
> + plperl.o: perlchunks.h
> +
> + perlchunks.h: plc_*.pl
> + $(PERL) text2macro.pl --strip='^(\#.*|\s*)$$' plc_*.pl >
> perlchunks.htmp
> + mv p
Tim Bunce wrote:
I see you've not commited it yet, so to help out I've attached
a new diff, over the current CVS head, with two minor changes:
- Removed the test, as noted above.
- Optimized pg_verifymbstr calls to avoid unneeded strlen()s.
I have committed this with minor edits. That s
