Re: [HACKERS] Patch for PKST timezone

2010-05-16 Thread Joachim Wieland
On Wed, May 12, 2010 at 12:39 AM, Tom Lane wrote: > Joachim Wieland writes: >> Good we have found that inconsistency now, so let's add PKST. > > OK, done.  BTW, I notice that PKT was labeled "(not in zic)", which > is not the case, per this discussion.  I seem to recall having noticed > some othe

Re: [HACKERS] Patch for PKST timezone

2010-05-11 Thread Tom Lane
Joachim Wieland writes: > Good we have found that inconsistency now, so let's add PKST. OK, done. BTW, I notice that PKT was labeled "(not in zic)", which is not the case, per this discussion. I seem to recall having noticed some others that seemed to be mislabeled the same way. What process d

Re: [HACKERS] Patch for PKST timezone

2010-05-11 Thread Joachim Wieland
On Tue, May 11, 2010 at 10:45 AM, Heikki Linnakangas wrote: > I don't think we want to include all timezone names in the default > config, timezone abbreviations aren't always unique for example. But we > should include PKST because we already include PKT; it would be nasty > for an application to

Re: [HACKERS] Patch for PKST timezone

2010-05-11 Thread Tom Lane
Heikki Linnakangas writes: > Tom Lane wrote: >> I don't think that's actually it. It looks to me like the Asia/Karachi >> zone definition expects the abbreviations to be PKST and PKDT. Not sure >> whether PKT is really in use, but it is not sensible to add PKST by >> itself. > How did you come

Re: [HACKERS] Patch for PKST timezone

2010-05-11 Thread Heikki Linnakangas
Tom Lane wrote: > Heikki Linnakangas writes: >> Takahiro Itagaki wrote: >>> Should we add PKST timezone? Also, I found a list of timezones[1] >>> and we don't have 36 tznames in the list. Should we also need them? > >> I don't think we want to include all timezone names in the default >> config,

Re: [HACKERS] Patch for PKST timezone

2010-05-11 Thread Tom Lane
Heikki Linnakangas writes: > Takahiro Itagaki wrote: >> Should we add PKST timezone? Also, I found a list of timezones[1] >> and we don't have 36 tznames in the list. Should we also need them? > I don't think we want to include all timezone names in the default > config, timezone abbreviations ar

Re: [HACKERS] Patch for PKST timezone

2010-05-11 Thread Heikki Linnakangas
Takahiro Itagaki wrote: > Aftab Hussain wrote: > >> Please accept attached patch for the following problem. > > This patch has not been replied, but I can reproduce the error with: > =# SET timezone = 'Asia/Karachi'; > =# SELECT timeofday()::timestamptz; > ERROR: invalid input syntax for type t

Re: [HACKERS] Patch for PKST timezone

2010-05-11 Thread Takahiro Itagaki
Aftab Hussain wrote: > Please accept attached patch for the following problem. This patch has not been replied, but I can reproduce the error with: =# SET timezone = 'Asia/Karachi'; =# SELECT timeofday()::timestamptz; ERROR: invalid input syntax for type timestamp with time zone: "Tue May 11