Re: [HACKERS] Perl coding error in msvc build system?

2015-02-17 Thread Michael Paquier
On Tue, Feb 17, 2015 at 6:34 AM, Peter Eisentraut wrote: >> This patch been reviewed by 4 people, resulting in 2 minor suggestions >> for changes (adding an m modifier, and removing a bogus last). >> >> It has 2 clear upvotes and 0 downvotes. >> >> I think it should be revised along the lines sugg

Re: [HACKERS] Perl coding error in msvc build system?

2015-02-16 Thread Peter Eisentraut
> This patch been reviewed by 4 people, resulting in 2 minor suggestions > for changes (adding an m modifier, and removing a bogus last). > > It has 2 clear upvotes and 0 downvotes. > > I think it should be revised along the lines suggested and committed > without further ado. My patch actually

Re: [HACKERS] Perl coding error in msvc build system?

2015-02-02 Thread Robert Haas
On Fri, Jan 23, 2015 at 4:17 PM, Brar Piening wrote: > Am 23.01.2015 um 09:17 schrieb Abhijit Menon-Sen: >> At 2014-06-03 22:30:50 -0400, pete...@gmx.net wrote: >>> I'm not sure whether the following coding actually detects any errors: >>> >>> Solution.pm: >>> >>> open(P, "cl /? 2>&1 |") || d

Re: [HACKERS] Perl coding error in msvc build system?

2015-01-23 Thread Brar Piening
Am 23.01.2015 um 09:17 schrieb Abhijit Menon-Sen: At 2014-06-03 22:30:50 -0400, pete...@gmx.net wrote: I'm not sure whether the following coding actually detects any errors: Solution.pm: open(P, "cl /? 2>&1 |") || die "cl command not found"; Since nobody with a Windows system has comment

Re: [HACKERS] Perl coding error in msvc build system?

2015-01-23 Thread Andrew Dunstan
On 01/23/2015 03:00 PM, Alvaro Herrera wrote: Why is the "last;" still there? AFAICS it matters in the old coding because of the while, but I don't think there is an equivalent looping construct in the new code. You're right, I missed that. It shouldn't be there, and will produce an error l

Re: [HACKERS] Perl coding error in msvc build system?

2015-01-23 Thread Alvaro Herrera
Why is the "last;" still there? AFAICS it matters in the old coding because of the while, but I don't think there is an equivalent looping construct in the new code. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: [HACKERS] Perl coding error in msvc build system?

2015-01-23 Thread Andrew Dunstan
On 01/23/2015 03:17 AM, Abhijit Menon-Sen wrote: At 2014-06-03 22:30:50 -0400, pete...@gmx.net wrote: I'm not sure whether the following coding actually detects any errors: Solution.pm: open(P, "cl /? 2>&1 |") || die "cl command not found"; Since nobody with a Windows system has comment

Re: [HACKERS] Perl coding error in msvc build system?

2015-01-23 Thread Abhijit Menon-Sen
At 2014-06-03 22:30:50 -0400, pete...@gmx.net wrote: > > I'm not sure whether the following coding actually detects any errors: > > Solution.pm: > > open(P, "cl /? 2>&1 |") || die "cl command not found"; Since nobody with a Windows system has commented, I'm just writing to say that from a Pe