Re: [HACKERS] Synchronous replication patch v1

2008-11-10 Thread Fujii Masao
Hi, On Thu, Nov 6, 2008 at 3:59 PM, Fujii Masao <[EMAIL PROTECTED]> wrote: >> Again, I would expect this to be integrated with server. I would expect >> code to live in src/postmaster/walreceiver.c, with main logic in a file >> alongside xlog.c, perhaps xreceive.c. We would start WALReceiver when

Re: [HACKERS] Synchronous replication patch v1

2008-11-10 Thread Fujii Masao
Hi, Pavan, On Thu, Nov 6, 2008 at 9:35 PM, Pavan Deolasee <[EMAIL PROTECTED]> wrote: > On Thu, Nov 6, 2008 at 2:12 PM, Fujii Masao <[EMAIL PROTECTED]> wrote: >> >> If the database whose timeline is the same as the primary's >> exists in the standby, 2)3) getting new online-backup is not >> necessa

Re: [HACKERS] Synchronous replication patch v1

2008-11-06 Thread Pavan Deolasee
On Thu, Nov 6, 2008 at 2:12 PM, Fujii Masao <[EMAIL PROTECTED]> wrote: > > If the database whose timeline is the same as the primary's > exists in the standby, 2)3) getting new online-backup is not > necessary. For example, after the standby falls down, the > database at that time is applicable to

Re: [HACKERS] Synchronous replication patch v1

2008-11-06 Thread Fujii Masao
On Thu, Nov 6, 2008 at 3:59 PM, Fujii Masao <[EMAIL PROTECTED]> wrote: > 1) Start postgres in the primary > 2) Get an online-backup in the primary > 3) Locate the online-backup in the standby > 4) Start postgres (with walreceiver) in the standby ># Configure restore_command, host of the primary

Re: [HACKERS] Synchronous replication patch v1

2008-11-05 Thread Fujii Masao
Hi Simon, On Wed, Nov 5, 2008 at 11:01 PM, Simon Riggs <[EMAIL PROTECTED]> wrote: > I would think we would want this integrated into the server as an > additional special backend, similar to WALWriter. If it works for now, > that's fine for other testing. This is not an especially difficult > chan

Re: [HACKERS] Synchronous replication patch v1

2008-11-05 Thread Simon Riggs
Hi Fujii, Here's some initial thoughts on the structure of this. I've deliberately not yet read other comments, so we have some independent viewpoints. Sorry if that means we end up saying same thing twice. On Fri, 2008-10-31 at 20:36 +0900, Fujii Masao wrote: > 1) Walsender > > This is new pr

Re: [HACKERS] Synchronous replication patch v1

2008-11-05 Thread Fujii Masao
Hi, Simon, On Wed, Nov 5, 2008 at 7:07 PM, Simon Riggs <[EMAIL PROTECTED]> wrote: > > On Tue, 2008-11-04 at 22:59 +0900, Fujii Masao wrote: >> Hi, thank you for taking time to review the patch. >> >> On Fri, Oct 31, 2008 at 11:12 PM, Heikki Linnakangas >> <[EMAIL PROTECTED]> wrote: >> > Fujii Masa

Re: [HACKERS] Synchronous replication patch v1

2008-11-05 Thread Simon Riggs
On Tue, 2008-11-04 at 22:59 +0900, Fujii Masao wrote: > Hi, thank you for taking time to review the patch. > > On Fri, Oct 31, 2008 at 11:12 PM, Heikki Linnakangas > <[EMAIL PROTECTED]> wrote: > > Fujii Masao wrote: > >> > >> Attached is a patch for a synchronous log-shipping replication which >

Re: [HACKERS] Synchronous replication patch v1

2008-11-04 Thread Fujii Masao
On Wed, Nov 5, 2008 at 12:51 AM, Heikki Linnakangas <[EMAIL PROTECTED]> wrote: > Fujii Masao wrote: >> >> On Fri, Oct 31, 2008 at 11:12 PM, Heikki Linnakangas >> <[EMAIL PROTECTED]> wrote: >>> >>> AFAICS, there's no security, at all. Anyone that can log in, can become a >>> WAL sender, and receive

Re: [HACKERS] Synchronous replication patch v1

2008-11-04 Thread Heikki Linnakangas
Fujii Masao wrote: On Fri, Oct 31, 2008 at 11:12 PM, Heikki Linnakangas <[EMAIL PROTECTED]> wrote: AFAICS, there's no security, at all. Anyone that can log in, can become a WAL sender, and receive all WAL for the whole cluster. One simple solution is to define the database only for replication

Re: [HACKERS] Synchronous replication patch v1

2008-11-04 Thread Fujii Masao
Hi, thank you for taking time to review the patch. On Fri, Oct 31, 2008 at 11:12 PM, Heikki Linnakangas <[EMAIL PROTECTED]> wrote: > Fujii Masao wrote: >> >> Attached is a patch for a synchronous log-shipping replication which >> was discussed just a month ago. I would like you to review this patc

Re: [HACKERS] Synchronous replication patch v1

2008-11-04 Thread Fujii Masao
On Fri, Oct 31, 2008 at 10:15 PM, Heikki Linnakangas <[EMAIL PROTECTED]> wrote: > Fujii Masao wrote: >> >> And, there are some problems in this patch; >> >> * This patch is somewhat big, though it should be subdivided for >> review. >> >> * Source code comments and documents are insufficient. >>

Re: [HACKERS] Synchronous replication patch v1

2008-10-31 Thread Heikki Linnakangas
Fujii Masao wrote: Attached is a patch for a synchronous log-shipping replication which was discussed just a month ago. I would like you to review this patch in Nov commit fest. Here's some first quick comments: AFAICS, there's no security, at all. Anyone that can log in, can become a WAL sen

Re: [HACKERS] Synchronous replication patch v1

2008-10-31 Thread Heikki Linnakangas
Fujii Masao wrote: And, there are some problems in this patch; * This patch is somewhat big, though it should be subdivided for review. * Source code comments and documents are insufficient. Is it against the rule of commit fest to add such a status patch into review-queue? If so, I would a