Re: [HACKERS] codlin_month is up and complain - PL/Python crash

2010-02-18 Thread Tom Lane
Zdenek Kotala writes: > Dne 17.02.10 18:39, Peter Eisentraut napsal(a): >> FWIW, this is a Sun Studio build that is complaining here. > Yes It is SS12. I add volatile keyword and problem disappears. OK, I've applied that change in CVS. Please change codlin_moth back to the higher optimization s

Re: [HACKERS] codlin_month is up and complain - PL/Python crash

2010-02-18 Thread Zdenek Kotala
Dne 17.02.10 18:39, Peter Eisentraut napsal(a): On ons, 2010-02-17 at 11:26 -0500, Tom Lane wrote: But the behavior gcc appears to exhibit is that it won't warn about variables that are only assigned once before the PG_TRY is entered, and that seems reasonable to me since such a variable ought t

Re: [HACKERS] codlin_month is up and complain - PL/Python crash

2010-02-17 Thread Peter Eisentraut
On ons, 2010-02-17 at 11:26 -0500, Tom Lane wrote: > But the behavior gcc appears to exhibit is that it won't warn about > variables that are only assigned once before the PG_TRY is entered, > and that seems reasonable to me since such a variable ought to have > the correct value either way. FWIW

Re: [HACKERS] codlin_month is up and complain - PL/Python crash

2010-02-17 Thread Tom Lane
Peter Eisentraut writes: > On ons, 2010-02-17 at 11:05 -0500, Tom Lane wrote: >> Since oldcontext is only set in the one place, it really shouldn't >> require "volatile" decoration, but maybe it does. > It is my understanding that local automatic variables may be clobbered > by [sig]longjmp unles

Re: [HACKERS] codlin_month is up and complain - PL/Python crash

2010-02-17 Thread Peter Eisentraut
On ons, 2010-02-17 at 11:05 -0500, Tom Lane wrote: > All of the MemoryContextSwitchTo calls in plpython seem to be in > patterns like this: > > MemoryContext oldcontext; > > oldcontext = CurrentMemoryContext; > PG_TRY(); > { > ... do something ... > } > PG_CATCH();

Re: [HACKERS] codlin_month is up and complain - PL/Python crash

2010-02-17 Thread Tom Lane
Zdenek Kotala writes: > I revived codlin_month and it falls during PL/Python test: > http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=codlin_moth&dt=2010-02-16%2015:09:05 All of the MemoryContextSwitchTo calls in plpython seem to be in patterns like this: MemoryContext oldcontext; oldc