Re: [HACKERS] is it bug? - printing boolean domains in sql/xml function

2013-06-24 Thread Szymon Guz
On 14 March 2013 03:45, Peter Eisentraut pete...@gmx.net wrote: On Mon, 2013-03-04 at 08:35 +0100, Pavel Stehule wrote: in this use case I am think so some regression test is important - It should not be mine, but missing more explicit regression test is reason, why this bug was not

Re: [HACKERS] is it bug? - printing boolean domains in sql/xml function

2013-06-24 Thread Pavel Stehule
Hello you can try fresh patch git format-patch -1 788bce13d3249ddbcdf3443ee078145f4888ab45 regards Pavel 2013/6/24 Szymon Guz mabew...@gmail.com: On 14 March 2013 03:45, Peter Eisentraut pete...@gmx.net wrote: On Mon, 2013-03-04 at 08:35 +0100, Pavel Stehule wrote: in this use case I am

Re: [HACKERS] is it bug? - printing boolean domains in sql/xml function

2013-06-24 Thread Pavel Stehule
2013/6/24 Pavel Stehule pavel.steh...@gmail.com: Hello you can try fresh patch git format-patch -1 788bce13d3249ddbcdf3443ee078145f4888ab45 and git format-patch -1 bc61878682051678ade5f59da7bfd90ab72ce13b regards Pavel 2013/6/24 Szymon Guz mabew...@gmail.com: On 14 March 2013 03:45,

Re: [HACKERS] is it bug? - printing boolean domains in sql/xml function

2013-03-13 Thread Peter Eisentraut
On Mon, 2013-03-04 at 08:35 +0100, Pavel Stehule wrote: in this use case I am think so some regression test is important - It should not be mine, but missing more explicit regression test is reason, why this bug was not detected some years. I've added the tests. -- Sent via pgsql-hackers

Re: [HACKERS] is it bug? - printing boolean domains in sql/xml function

2013-03-03 Thread Tom Lane
Pavel Stehule pavel.steh...@gmail.com writes: here is patch Applied, though without the regression test changes, because (a) that didn't really seem necessary, and (b) I didn't feel like updating xmlmap_1.out. regards, tom lane -- Sent via pgsql-hackers mailing list

Re: [HACKERS] is it bug? - printing boolean domains in sql/xml function

2013-03-03 Thread Pavel Stehule
Hello 2013/3/4 Tom Lane t...@sss.pgh.pa.us: Pavel Stehule pavel.steh...@gmail.com writes: here is patch Applied, though without the regression test changes, because (a) that didn't really seem necessary, and (b) I didn't feel like updating xmlmap_1.out. thank you for commit in this use

Re: [HACKERS] is it bug? - printing boolean domains in sql/xml function

2013-02-21 Thread Pavel Stehule
Hello here is patch where it should be pushed - 9.3 or 9.4 ? I vote 9.3 - I know a users, that should to do workarounds (he should not to use domains) now, so early is better. And this patch is one line size patch Regards Pavel 2013/2/16 Pavel Stehule pavel.steh...@gmail.com: 2013/2/16

Re: [HACKERS] is it bug? - printing boolean domains in sql/xml function

2013-02-21 Thread Pavel Stehule
pink Peter as xml feature commiter. Regards Pavel 2013/2/21 Pavel Stehule pavel.steh...@gmail.com: Hello here is patch where it should be pushed - 9.3 or 9.4 ? I vote 9.3 - I know a users, that should to do workarounds (he should not to use domains) now, so early is better. And this

Re: [HACKERS] is it bug? - printing boolean domains in sql/xml function

2013-02-16 Thread Noah Misch
On Sun, Jan 13, 2013 at 07:54:11AM +0100, Pavel Stehule wrote: related to http://www.postgresql.org/message-id/cafj8prdtavfnrazwet+ewmfrbdzffva8w17kk_e12fb6t-z...@mail.gmail.com boolean domains is serialised to string different than boolean postgres=# CREATE DOMAIN booldomain as bool;

Re: [HACKERS] is it bug? - printing boolean domains in sql/xml function

2013-02-16 Thread Pavel Stehule
2013/2/16 Noah Misch n...@leadboat.com: On Sun, Jan 13, 2013 at 07:54:11AM +0100, Pavel Stehule wrote: related to http://www.postgresql.org/message-id/cafj8prdtavfnrazwet+ewmfrbdzffva8w17kk_e12fb6t-z...@mail.gmail.com boolean domains is serialised to string different than boolean