On Fri, Jul 31, 2009 at 5:36 PM, Andres Freund wrote:
> Hi Robert,
>
> On Friday 31 July 2009 23:13:54 Robert Haas wrote:
>> On Sat, Jul 18, 2009 at 10:29 PM, Andres Freund wrote:
>> I have posted a new version of this patch on a separate thread; do you
>> have time to re-review?
> Yes, I have seen
On Fri, Jul 31, 2009 at 6:04 PM, Andres Freund wrote:
> I am quite happy that the annoyance over a patch of mine "helped" you starting
> to work on this ;-)
> Thanks for all the work.
You're welcome, thanks for all your reviewing. For the record, I
wasn't annoyed BY the patch; I was annoyed by th
On Friday 31 July 2009 23:13:54 Robert Haas wrote:
> On Sat, Jul 18, 2009 at 10:29 PM, Andres Freund wrote:
> > One part where I find the code flow ugly is 'did_boilerplate' in
> > report_triggers/its callsites.
> > I can see why it is done that way, but its not exactly obvious to read
> > when you
Hi Robert,
On Friday 31 July 2009 23:13:54 Robert Haas wrote:
> On Sat, Jul 18, 2009 at 10:29 PM, Andres Freund wrote:
> I have posted a new version of this patch on a separate thread; do you
> have time to re-review?
Yes, I have seen it. I plan to spent some time on it tonight and/or tomorrow.
On Sat, Jul 18, 2009 at 10:29 PM, Andres Freund wrote:
> One part where I find the code flow ugly is 'did_boilerplate' in
> report_triggers/its callsites.
> I can see why it is done that way, but its not exactly obvious to read when
> you want to find out how the format looks.
Suggestions?
> Anot
Hi Robert, Hi All,
On Sunday 19 July 2009 04:29:42 Andres Freund wrote:
> I did not yet look at the contrib/autoexplain portions. Will do that on
> Monday or so.
Early Monday:
Looks fine, except that the new "auto_explain.log_format" parameter is not
documented.
Andres
--
Sent via pgsql-hacker
