On Friday, May 25, 2012 05:19:28 PM Tom Lane wrote:
Andres Freund and...@2ndquadrant.com writes:
On Friday, May 25, 2012 04:03:49 PM Peter Geoghegan wrote:
Where do you suggest the file be written to?
One could argue stats_temp_directory would be the correct place.
No, that would be
On Thu, May 24, 2012 at 2:19 PM, Magnus Hagander mag...@hagander.net wrote:
On Thu, May 24, 2012 at 2:16 PM, Peter Geoghegan pe...@2ndquadrant.com
wrote:
On 24 May 2012 12:42, Magnus Hagander mag...@hagander.net wrote:
What actually happens if it tries to repalloc() something huge? palloc
On 25 May 2012 14:13, Magnus Hagander mag...@hagander.net wrote:
Here's a patch that does the two easy fixes:
1) writes the file to a temp file and rename()s it over the main file
as it writes down. This removes the (small) risk of corruption because
of a crash during write
2) unlinks the
On Friday, May 25, 2012 04:03:49 PM Peter Geoghegan wrote:
I still think we should consider the placement of this file to not be
in the global/ directory, but this is a quick (back-patchable) fix...
Where do you suggest the file be written to?
One could argue stats_temp_directory would be
Peter Geoghegan pe...@2ndquadrant.com writes:
On 25 May 2012 14:13, Magnus Hagander mag...@hagander.net wrote:
I still think we should consider the placement of this file to not be
in the global/ directory, but this is a quick (back-patchable) fix...
Where do you suggest the file be written
On Fri, May 25, 2012 at 4:09 PM, Tom Lane t...@sss.pgh.pa.us wrote:
Peter Geoghegan pe...@2ndquadrant.com writes:
On 25 May 2012 14:13, Magnus Hagander mag...@hagander.net wrote:
I still think we should consider the placement of this file to not be
in the global/ directory, but this is a quick
Magnus Hagander mag...@hagander.net writes:
On Fri, May 25, 2012 at 4:09 PM, Tom Lane t...@sss.pgh.pa.us wrote:
Given that pgstats keeps its permanent file in global/, I think the
argument that pg_stat_statements should not do likewise is pretty thin.
Fair enough. As long as the file is
Andres Freund and...@2ndquadrant.com writes:
On Friday, May 25, 2012 04:03:49 PM Peter Geoghegan wrote:
Where do you suggest the file be written to?
One could argue stats_temp_directory would be the correct place.
No, that would be exactly the *wrong* place, because that directory can
be on a
On 5/25/12 8:19 AM, Tom Lane wrote:
Andres Freund and...@2ndquadrant.com writes:
On Friday, May 25, 2012 04:03:49 PM Peter Geoghegan wrote:
Where do you suggest the file be written to?
One could argue stats_temp_directory would be the correct place.
No, that would be exactly the *wrong*
On Fri, May 25, 2012 at 6:49 PM, Josh Berkus j...@agliodbs.com wrote:
On 5/25/12 8:19 AM, Tom Lane wrote:
Andres Freund and...@2ndquadrant.com writes:
On Friday, May 25, 2012 04:03:49 PM Peter Geoghegan wrote:
Where do you suggest the file be written to?
One could argue stats_temp_directory
Why would they want that? PSS only writes the tempfile on shutdown and
reads it on startup. Unlike pgstats which reads and writes it all the
time.
Ah, ok! Didn't know that.
--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com
--
Sent via pgsql-hackers mailing list
On 24 May 2012 11:43, Magnus Hagander mag...@hagander.net wrote:
In general, should a contrib module really store data in the global/
directory? Seems pretty ugly to me...
I think the case could be made for moving pg_stat_statements into
core, as an optionally enabled view, like
On Thu, May 24, 2012 at 1:36 PM, Peter Geoghegan pe...@2ndquadrant.com wrote:
On 24 May 2012 11:43, Magnus Hagander mag...@hagander.net wrote:
In general, should a contrib module really store data in the global/
directory? Seems pretty ugly to me...
I think the case could be made for moving
On 24 May 2012 12:42, Magnus Hagander mag...@hagander.net wrote:
What actually happens if it tries to repalloc() something huge? palloc
will throw an elog(ERROR), and since this happens during postmaster
startup, are you sure it won't prevent the server from starting?
Oh, yes, missed that.
On Thu, May 24, 2012 at 2:16 PM, Peter Geoghegan pe...@2ndquadrant.com wrote:
On 24 May 2012 12:42, Magnus Hagander mag...@hagander.net wrote:
What actually happens if it tries to repalloc() something huge? palloc
will throw an elog(ERROR), and since this happens during postmaster
startup, are
15 matches
Mail list logo
