Re: [HACKERS] pgbench filler columns

2013-09-29 Thread Fujii Masao
On Fri, Sep 27, 2013 at 4:03 PM, Pavan Deolasee wrote: > On Thu, Sep 26, 2013 at 7:20 PM, Noah Misch wrote: >> >> On Thu, Sep 26, 2013 at 03:23:30PM +0530, Pavan Deolasee wrote: >> >> > Should we just fix the comment and say its applicable for all tables >> > except >> > accounts ? >> >> Please d

Re: [HACKERS] pgbench filler columns

2013-09-27 Thread Pavan Deolasee
On Thu, Sep 26, 2013 at 7:20 PM, Noah Misch wrote: > On Thu, Sep 26, 2013 at 03:23:30PM +0530, Pavan Deolasee wrote: > > > Should we just fix the comment and say its applicable for all tables > except > > accounts ? > > Please do. > > How about something like this ? Patch attached. Thanks, Pavan

Re: [HACKERS] pgbench filler columns

2013-09-26 Thread Noah Misch
On Thu, Sep 26, 2013 at 03:23:30PM +0530, Pavan Deolasee wrote: > On Thu, Sep 26, 2013 at 2:05 PM, Pavan Deolasee > wrote: > > > While looking at the compressibility of WAL files generated by pgbench, > > which is close to 90%, I first thought its because of the "filler" column > > in the account

Re: [HACKERS] pgbench filler columns

2013-09-26 Thread Pavan Deolasee
On Thu, Sep 26, 2013 at 2:05 PM, Pavan Deolasee wrote: > While looking at the compressibility of WAL files generated by pgbench, > which is close to 90%, I first thought its because of the "filler" column > in the accounts table. But a comment in pgbench.c says: > > /* > * Note: TPC-B req