Kaigai
Sent: Tuesday, March 03, 2015 6:31 PM
To: Kaigai Kouhei(海外 浩平); Robert Haas
Cc: Tom Lane; pgsql-hackers@postgreSQL.org; Shigeru Hanada
Subject: Re: Custom/Foreign-Join-APIs (Re: [HACKERS] [v9.5] Custom Plan API)
The attached version of custom/foreign-join interface patch
fixes up
@postgreSQL.org; Shigeru Hanada
Subject: Re: Custom/Foreign-Join-APIs (Re: [HACKERS] [v9.5] Custom Plan
API)
On Fri, Jan 9, 2015 at 10:51 AM, Kouhei Kaigai kai...@ak.jp.nec.com
wrote:
When custom-scan node replaced a join-plan, it shall have at least
two child plan-nodes. The callback
On Fri, Feb 13, 2015 at 6:12 PM, Michael Paquier michael.paqu...@gmail.com
wrote:
On Fri, Feb 13, 2015 at 4:59 PM, Kouhei Kaigai kai...@ak.jp.nec.com
wrote:
Where are we on this? AFAIK, we have now a feature with no documentation
and no example in-core to test those custom routine APIs,
On Fri, Feb 13, 2015 at 4:59 PM, Kouhei Kaigai kai...@ak.jp.nec.com wrote:
Where are we on this? AFAIK, we have now a feature with no documentation
and no example in-core to test those custom routine APIs, hence moved to
next CF.
Now Hanada-san is working on the example module that use
4:38 PM
To: Kaigai Kouhei(海外 浩平)
Cc: Robert Haas; Tom Lane; pgsql-hackers@postgreSQL.org; Shigeru Hanada
Subject: ##freemail## Re: Custom/Foreign-Join-APIs (Re: [HACKERS] [v9.5]
Custom Plan API)
On Thu, Jan 15, 2015 at 8:02 AM, Kouhei Kaigai kai...@ak.jp.nec.com wrote:
On Fri
]
Sent: Friday, February 13, 2015 6:17 PM
To: Kaigai Kouhei(海外 浩平)
Cc: Robert Haas; Tom Lane; pgsql-hackers@postgreSQL.org; Shigeru Hanada
Subject: Re: Custom/Foreign-Join-APIs (Re: [HACKERS] [v9.5] Custom Plan
API)
On Fri, Feb 13, 2015 at 6:12 PM, Michael Paquier michael.paqu
On Thu, Jan 15, 2015 at 8:02 AM, Kouhei Kaigai kai...@ak.jp.nec.com wrote:
On Fri, Jan 9, 2015 at 10:51 AM, Kouhei Kaigai kai...@ak.jp.nec.com
wrote:
When custom-scan node replaced a join-plan, it shall have at least two
child plan-nodes. The callback handler of PlanCustomPath needs to
/Foreign-Join-APIs (Re: [HACKERS] [v9.5]
Custom Plan API)
On Fri, Jan 9, 2015 at 10:51 AM, Kouhei Kaigai kai...@ak.jp.nec.com wrote:
When custom-scan node replaced a join-plan, it shall have at least two
child plan-nodes. The callback handler of PlanCustomPath needs to be
able to call
On Fri, Jan 9, 2015 at 10:51 AM, Kouhei Kaigai kai...@ak.jp.nec.com wrote:
When custom-scan node replaced a join-plan, it shall have at least two
child plan-nodes. The callback handler of PlanCustomPath needs to be
able to call create_plan_recurse() to transform the underlying path-nodes
to
On 11/01/15 08:56, Kohei KaiGai wrote:
2015-01-11 10:40 GMT+09:00 Jim Nasby jim.na...@bluetreble.com:
Yeah there are actually several places in the code where relid means
index in range table and not oid of relation, it still manages to
confuse
me. Nothing this patch can do about that.
Well,
Petr Jelinek p...@2ndquadrant.com writes:
On 11/01/15 08:56, Kohei KaiGai wrote:
2015-01-11 10:40 GMT+09:00 Jim Nasby jim.na...@bluetreble.com:
Yeah there are actually several places in the code where relid means
index in range table and not oid of relation, it still manages to
confuse me.
On 1/9/15, 8:51 PM, Kohei KaiGai wrote:
2015-01-10 9:56 GMT+09:00 Jim Nasby jim.na...@bluetreble.com:
On 1/9/15, 6:54 PM, Jim Nasby wrote:
On 1/9/15, 6:44 PM, Petr Jelinek wrote:
Yep, I had a same impression when I looked at the code first time,
however, it is defined as below. Not a
2015-01-11 10:40 GMT+09:00 Jim Nasby jim.na...@bluetreble.com:
On 1/9/15, 8:51 PM, Kohei KaiGai wrote:
2015-01-10 9:56 GMT+09:00 Jim Nasby jim.na...@bluetreble.com:
On 1/9/15, 6:54 PM, Jim Nasby wrote:
On 1/9/15, 6:44 PM, Petr Jelinek wrote:
Yep, I had a same impression when I looked
On 1/9/15, 6:54 PM, Jim Nasby wrote:
On 1/9/15, 6:44 PM, Petr Jelinek wrote:
Yep, I had a same impression when I looked at the code first time,
however, it is defined as below. Not a manner of custom-scan itself.
/*
* ==
* Scan nodes
* ==
*/
typedef struct Scan
{
On 1/9/15, 6:44 PM, Petr Jelinek wrote:
Yep, I had a same impression when I looked at the code first time,
however, it is defined as below. Not a manner of custom-scan itself.
/*
* ==
* Scan nodes
* ==
*/
typedef struct Scan
{
Planplan;
Index
On 10/01/15 01:19, Kohei KaiGai wrote:
2015-01-10 8:18 GMT+09:00 Jim Nasby jim.na...@bluetreble.com:
On 1/6/15, 5:43 PM, Kouhei Kaigai wrote:
scan_relid != InvalidOid
Ideally, they should be OidIsValid(scan_relid)
Scan.scanrelid is an index of range-tables list, not an object-id.
So,
2015-01-10 9:56 GMT+09:00 Jim Nasby jim.na...@bluetreble.com:
On 1/9/15, 6:54 PM, Jim Nasby wrote:
On 1/9/15, 6:44 PM, Petr Jelinek wrote:
Yep, I had a same impression when I looked at the code first time,
however, it is defined as below. Not a manner of custom-scan itself.
/*
*
2015-01-10 8:18 GMT+09:00 Jim Nasby jim.na...@bluetreble.com:
On 1/6/15, 5:43 PM, Kouhei Kaigai wrote:
scan_relid != InvalidOid
Ideally, they should be OidIsValid(scan_relid)
Scan.scanrelid is an index of range-tables list, not an object-id.
So, InvalidOid or OidIsValid() are not a
On Tue, Jan 6, 2015 at 9:17 AM, Kouhei Kaigai kai...@ak.jp.nec.com wrote:
The attached patch is newer revision of custom-/foreign-join
interface.
It seems that the basic purpose of this patch is to allow a foreign scan
or custom scan to have scanrelid == 0, reflecting the case where we
On 1/6/15, 5:43 PM, Kouhei Kaigai wrote:
scan_relid != InvalidOid
Ideally, they should be OidIsValid(scan_relid)
Scan.scanrelid is an index of range-tables list, not an object-id.
So, InvalidOid or OidIsValid() are not a good choice.
I think the name needs to change then; scan_relid
On Tue, Jan 6, 2015 at 9:17 AM, Kouhei Kaigai kai...@ak.jp.nec.com wrote:
The attached patch is newer revision of custom-/foreign-join
interface.
It seems that the basic purpose of this patch is to allow a foreign
scan or custom scan to have scanrelid == 0, reflecting the case where
we are
...@2ndquadrant.com]
Sent: Wednesday, January 07, 2015 8:24 AM
To: Jim Nasby; Kaigai Kouhei(海外 浩平); Robert Haas
Cc: Tom Lane; pgsql-hackers@postgreSQL.org; Shigeru Hanada
Subject: Re: Custom/Foreign-Join-APIs (Re: [HACKERS] [v9.5] Custom Plan
API)
On 07/01/15 00:05, Jim Nasby wrote:
On 1/6/15
On 07/01/15 00:05, Jim Nasby wrote:
On 1/6/15, 8:17 AM, Kouhei Kaigai wrote:
The attached patch is newer revision of custom-/foreign-join
interface.
Shouldn't instances of
scan_relid 0
be
scan_relid != InvalidOid
Ideally, they should be OidIsValid(scan_relid)
--
Petr Jelinek
On 1/6/15, 8:17 AM, Kouhei Kaigai wrote:
The attached patch is newer revision of custom-/foreign-join
interface.
Shouldn't instances of
scan_relid 0
be
scan_relid != InvalidOid
?
--
Jim Nasby, Data Architect, Blue Treble Consulting
Data in Trouble? Get it in Treble! http://BlueTreble.com
101 - 124 of 124 matches
Mail list logo
