Re: [HACKERS] Alpha 1 release notes

2009-08-11 Thread Josh Berkus
On 8/11/09 3:27 PM, Peter Eisentraut wrote: OK, since there was no clear consensus or volunteer for preparing release notes for alpha 1, I have started something. Let me know what you think. Actually, the consensus was that Bruce was not going to share, so Robert and I didn't want to bother

Re: [HACKERS] WIP: getting rid of the pg_database flat file

2009-08-11 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: Tom Lane wrote: I'd also like to look into getting rid of the pg_auth flat file. That would be sad for many users of pgbouncer. Really? And how would pgbouncer be depending on that? regards, tom lane -- Sent via

Re: [HACKERS] Collation

2009-08-11 Thread Alvaro Herrera
David Fetter wrote: Folks, While trying unsuccessfully to help someone in IRC, they pointed me to this: http://www.flexiguided.de/publications.pgcollkey.en.html Is anybody working with the kind people of FlexiGuided GmbH to see about integrating this feature more tightly with

Re: [HACKERS] WIP: getting rid of the pg_database flat file

2009-08-11 Thread Andres Freund
On Wednesday 12 August 2009 02:30:53 Tom Lane wrote: Andrew Dunstan and...@dunslane.net writes: Tom Lane wrote: I'd also like to look into getting rid of the pg_auth flat file. That would be sad for many users of pgbouncer. Really? And how would pgbouncer be depending on that? One can

Re: [HACKERS] WIP: getting rid of the pg_database flat file

2009-08-11 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan and...@dunslane.net writes: Tom Lane wrote: I'd also like to look into getting rid of the pg_auth flat file. That would be sad for many users of pgbouncer. Really? And how would pgbouncer be depending on that? auth_file

Re: [HACKERS] dependencies for generated header files

2009-08-11 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Tue, Aug 11, 2009 at 4:38 PM, Peter Eisentrautpete...@gmx.net wrote: I'm not convinced by this use case. Well, my original motivation for developing this patch was that I often go into a subdirectory and start hacking on a .c file and then type

Re: [HACKERS] dependencies for generated header files

2009-08-11 Thread Robert Haas
On Tue, Aug 11, 2009 at 9:00 PM, Tom Lanet...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Tue, Aug 11, 2009 at 4:38 PM, Peter Eisentrautpete...@gmx.net wrote: I'm not convinced by this use case. Well, my original motivation for developing this patch was that I often go

Re: [HACKERS] dependencies for generated header files

2009-08-11 Thread Robert Haas
On Tue, Aug 11, 2009 at 5:56 PM, Alvaro Herreraalvhe...@commandprompt.com wrote: Robert Haas escribió: *shrug*  You don't have to accept the patch, but I'm unclear as to how make from a subdirectory will ever work reliably without something like this.  The problem occurs when .c files have

Re: [HACKERS] Alpha 1 release notes

2009-08-11 Thread Robert Haas
On Tue, Aug 11, 2009 at 8:32 PM, Alvaro Herreraalvhe...@commandprompt.com wrote: Mike wrote: The thing that caused me the most trouble was that the , wasn't very noticeable sitting near the end of this line: EXPLAIN [ ( { ANALYZE boolean | VERBOSE boolean | COSTS boolean | FORMAT { TEXT |

Re: [HACKERS] pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY)

2009-08-11 Thread Tom Lane
Greg Stark gsst...@mit.edu writes: What would happen if we ran pgindent immediately after every commit? So nobody would ever see a checkout that wasn't pgindent-clean? The only losers I see would be people working on multi-part patches. ... which we're trying to encourage ... Actually, the

Re: [HACKERS] WIP: getting rid of the pg_database flat file

2009-08-11 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: Tom Lane wrote: Really? And how would pgbouncer be depending on that? auth_file The name of the file to load user names and passwords from. The file format is the same as the PostgreSQL pg_auth/pg_pwd file, so this setting can be

Re: [HACKERS] dependencies for generated header files

2009-08-11 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Tue, Aug 11, 2009 at 9:00 PM, Tom Lanet...@sss.pgh.pa.us wrote: Surely the answer to that is you should be configuring with --enable-depend. Uhm, the point is that this is broken even with ---enable-depend. Oh, okay, but that's only for

Re: [HACKERS] Alpha 1 release notes

2009-08-11 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: Hmm, I thought we had some examples in there, but now that I look we only have an example for COSTS OFF, not for FORMAT. That does seem like an oversight. I thought about adding one when I committed the patch, but concluded that there was no point

[HACKERS] Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY)

2009-08-11 Thread Robert Haas
On Tue, Aug 11, 2009 at 8:10 PM, Greg Starkgsst...@mit.edu wrote: Of course in all likelihood tom would have rewritten their first patch anyways... Maybe I'm taking life too seriously at the moment, but I find this comment kind of snide and unhelpful. I just went through the experience of

Re: [HACKERS] Hot standby?

2009-08-11 Thread Greg Stark
On Tue, Aug 11, 2009 at 10:13 PM, Robert Haasrobertmh...@gmail.com wrote: On Tue, Aug 11, 2009 at 4:07 PM, Josh Berkusj...@agliodbs.com wrote: So really, the streaming replication patch should be called hot standby, No.  AIUI, hot standby means that when your primary falls over, the

Re: [HACKERS] dependencies for generated header files

2009-08-11 Thread Alvaro Herrera
Robert Haas escribió: Given that the anum.h stuff is gone, vastly might be an overstatement. I'm pretty surprised to find out that people don't like the idea of having dependencies be correct from anywhere in the tree. Even if I'm the only developer who does partial builds, the cost seems

Re: [HACKERS] Hot standby and synchronous replication status

2009-08-11 Thread Fujii Masao
Hi, On Wed, Aug 12, 2009 at 6:50 AM, Robert Haasrobertmh...@gmail.com wrote: I don't really know how you COULD pick a safe default location. Presumably any location that's in the default postgresql.conf file would be under $PGDATA, which kind of defeats the purpose of the whole thing.  In

[HACKERS] Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY)

2009-08-11 Thread Bruce Momjian
Robert Haas wrote: What is a bit frustrating to me is that a number of Tom's changes to the first two patches were trivial whitespace changes that required me to rebase for no obvious reason. Either those changes were made accidentally as Tom was fooling around with what I had done, or they

Re: [HACKERS] Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY)

2009-08-11 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian br...@momjian.us writes: I compared 8.3 CVS against 8.4 CVS and see the removal of a column in pg_amop.h for exacly the lines you listed: Ah. The removal of amopreqcheck was so long ago I'd forgotten about it ;-) Yeah, the column additions/removals since 8.3

Re: [HACKERS] dependencies for generated header files

2009-08-11 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: Given that the anum.h stuff is gone, vastly might be an overstatement. I'm pretty surprised to find out that people don't like the idea of having dependencies be correct from anywhere in the tree. Even if I'm the only developer who does partial

Re: [HACKERS] WIP: getting rid of the pg_database flat file

2009-08-11 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: Tom Lane wrote: To actually get rid of the pg_database flat file, we'd need to take the further step of teaching the AV launcher to read pg_database for itself, or else refactor things so that the AV workers can do that for it. (Alvaro, any

Re: [HACKERS] Hot standby?

2009-08-11 Thread Greg Stark
As I see it we potentially have the following modes to deal with: Archive file mode asynchronous archive Archive file mode asynchronous standby slave Streaming mode asynchronous standby slave Streaming mode synchronousstandby slave Archive file mode asynchronous

Re: [HACKERS] dependencies for generated header files

2009-08-11 Thread Robert Haas
On Tue, Aug 11, 2009 at 9:19 PM, Tom Lanet...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Tue, Aug 11, 2009 at 9:00 PM, Tom Lanet...@sss.pgh.pa.us wrote: Surely the answer to that is you should be configuring with --enable-depend. Uhm, the point is that this is broken

Re: [HACKERS] WIP: getting rid of the pg_database flat file

2009-08-11 Thread Alvaro Herrera
Tom Lane wrote: To actually get rid of the pg_database flat file, we'd need to take the further step of teaching the AV launcher to read pg_database for itself, or else refactor things so that the AV workers can do that for it. (Alvaro, any comments about the best way to proceed there?) Hmm.

Re: [HACKERS] Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY)

2009-08-11 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: I compared 8.3 CVS against 8.4 CVS and see the removal of a column in pg_amop.h for exacly the lines you listed: Ah. The removal of amopreqcheck was so long ago I'd forgotten about it ;-) Yeah, the column additions/removals since 8.3 would give pgindent

Re: [HACKERS] Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY)

2009-08-11 Thread Andrew Dunstan
Robert Haas wrote: On Tue, Aug 11, 2009 at 8:10 PM, Greg Starkgsst...@mit.edu wrote: Of course in all likelihood tom would have rewritten their first patch anyways... Maybe I'm taking life too seriously at the moment, but I find this comment kind of snide and unhelpful. Yes,

Re: [HACKERS] pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY)

2009-08-11 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: What is a bit frustrating to me is that a number of Tom's changes to the first two patches were trivial whitespace changes that required me to rebase for no obvious reason. Either those changes were made accidentally as Tom was fooling around with

[HACKERS] Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY)

2009-08-11 Thread Robert Haas
On Tue, Aug 11, 2009 at 10:08 PM, Tom Lanet...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: What is a bit frustrating to me is that a number of Tom's changes to the first two patches were trivial whitespace changes that required me to rebase for no obvious reason.   Either

[HACKERS] TODO: fix priority of ordering of read and write light-weight locks

2009-08-11 Thread Jeff Janes
The wiki todo has the topic Fix priority ordering of read and write light-weight locks and references http://archives.postgresql.org/pgsql-hackers/2004-11/msg00893.php (lwlocks and starvation) Having read the referenced discussion, I'm trying to figure out what remains to be done. Tom proposed a

Re: [HACKERS] Hot standby?

2009-08-11 Thread Robert Haas
On Tue, Aug 11, 2009 at 9:44 PM, Greg Starkgsst...@mit.edu wrote: On Tue, Aug 11, 2009 at 10:13 PM, Robert Haasrobertmh...@gmail.com wrote: On Tue, Aug 11, 2009 at 4:07 PM, Josh Berkusj...@agliodbs.com wrote: So really, the streaming replication patch should be called hot standby, No.  AIUI,

Re: [HACKERS] pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY)

2009-08-11 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Tue, Aug 11, 2009 at 10:08 PM, Tom Lanet...@sss.pgh.pa.us wrote: If that's not it, you'd need to mention details. Well, one thing I've noticed is that when a function prototype wraps around to the next line, you often change the number of spaces in

Re: [HACKERS] Hot standby?

2009-08-11 Thread Mark Mielke
On 08/11/2009 11:19 PM, Robert Haas wrote: On Tue, Aug 11, 2009 at 9:44 PM, Greg Starkgsst...@mit.edu wrote: No! This is *not* what hot standby means, at least not in the Oracle world. I'm perplexed by this. For example: http://en.wikipedia.org/wiki/Hot_standby Admittedly,

Re: [HACKERS] pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY)

2009-08-11 Thread Alvaro Herrera
Tom Lane escribió: Ah. That's a bit idiosyncratic to pgindent. What it does for a function definition makes sense, I think: it lines up all the parameters to start in the same column: static int myfunction(int foo, int bar) What is not obvious is that the same amount of

Re: [HACKERS] TODO: fix priority of ordering of read and write light-weight locks

2009-08-11 Thread Tom Lane
Jeff Janes jeff.ja...@gmail.com writes: The wiki todo has the topic Fix priority ordering of read and write light-weight locks and references http://archives.postgresql.org/pgsql-hackers/2004-11/msg00893.php (lwlocks and starvation) Having read the referenced discussion, I'm trying to figure

Re: [HACKERS] pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY)

2009-08-11 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: The reason this is like this is that the indent binary modifies the prototype exactly like the function definition, and then the awk program that's used in the pipeline pulls up the second line: # Move prototype names to the same line as

<    1   2