Re: [HACKERS] Parallel Seq Scan

2015-01-01 Thread Fabrízio de Royes Mello
bgworker before we could start parallel plan execution. Can we check the number of free bgworkers slots to set the max workers? Regards, Fabrízio Mello -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

2015-02-03 Thread Fabrízio de Royes Mello
, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http://br.linkedin.com/in/fabriziomello Twitter: http://twitter.com/fabriziomello Github: http://github.com/fabriziomello

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

2015-02-03 Thread Fabrízio de Royes Mello
). Makes sense... +1 Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http://br.linkedin.com/in/fabriziomello Twitter: http://twitter.com/fabriziomello Github: http://github.com/fabriziomello

Re: [HACKERS] TODO : Allow parallel cores to be used by vacuumdb [ WIP ]

2015-01-29 Thread Fabrízio de Royes Mello
| There are a warning in the docs to be careful to use the -f (full) option and -j. Regards, Fabrízio -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http://br.linkedin.com/in/fabriziomello Twitter

Re: [HACKERS] Providing catalog view to pg_hba.conf file - Patch submission

2015-01-29 Thread Fabrízio de Royes Mello
to manipulate HBA entries like we did with ALTER SYSTEM. It's just some thoughts about it. Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http://br.linkedin.com/in/fabriziomello Twitter: http

Re: [HACKERS] Providing catalog view to pg_hba.conf file - Patch submission

2015-01-28 Thread Fabrízio de Royes Mello
file? Imagine if we are able to manipulate the HBA file using INSERT/UPDATE/DELETE. Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http://br.linkedin.com/in/fabriziomello Twitter: http

Re: [HACKERS] [pgsql-advocacy] GSoC 2015 - mentors, students and admins.

2015-02-10 Thread Fabrízio de Royes Mello
. I'm interested to participate as student again. Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http://br.linkedin.com/in/fabriziomello Twitter: http://twitter.com/fabriziomello Github: http

Re: [HACKERS] Index-only scans for GiST.

2015-02-12 Thread Fabrízio de Royes Mello
. Anastasia provided a documentation patch in the first email. Yeah, but it's a good practice send all the patches together. Will make the life of the reviewers better ;-) Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http

Re: [HACKERS] event trigger test exception message

2015-01-04 Thread Fabrízio de Royes Mello
any other reason, the Sir does seem a bit sexist - we have no idea of the gender of the reader. Probably just 'sorry, no rewrite allowed' would suffice. +1 -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io

Re: [HACKERS] Can pg_dump make use of CURRENT/SESSION_USER

2015-03-18 Thread Fabrízio de Royes Mello
... because that will let us dump per-database user options too.) +1 for both of those ideas. Can you explain more about this idea? Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http

Re: [HACKERS] Can pg_dump make use of CURRENT/SESSION_USER

2015-03-18 Thread Fabrízio de Royes Mello
On Wed, Mar 18, 2015 at 2:42 PM, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: On Wed, Mar 18, 2015 at 2:24 PM, Robert Haas robertmh...@gmail.com wrote: On Wed, Mar 18, 2015 at 1:23 PM, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: If we ever implement something

Re: [HACKERS] Can pg_dump make use of CURRENT/SESSION_USER

2015-03-18 Thread Fabrízio de Royes Mello
On Wed, Mar 18, 2015 at 3:13 PM, Robert Haas robertmh...@gmail.com wrote: On Wed, Mar 18, 2015 at 2:09 PM, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: Just one last doubt. Do we expose a new function called current_database like current_catalog, current_user, ... ? Why would we

Re: [HACKERS] Can pg_dump make use of CURRENT/SESSION_USER

2015-03-18 Thread Fabrízio de Royes Mello
. But that would have nothing to do with the proposed patch anyway, because the bits of syntax in question are not expressions and you should not try to turn them into things that would call functions. Yeah... I'll focus on the current scope. Thanks, -- Fabrízio de Royes Mello Consultoria/Coaching

Re: [HACKERS] Can pg_dump make use of CURRENT/SESSION_USER

2015-03-18 Thread Fabrízio de Royes Mello
On Wed, Mar 18, 2015 at 2:24 PM, Robert Haas robertmh...@gmail.com wrote: On Wed, Mar 18, 2015 at 1:23 PM, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: If we ever implement something like COMMENT ON CURRENT_DATABASE IS ... it will be useful, because you will be able

Re: [HACKERS] Order of enforcement of CHECK constraints?

2015-03-20 Thread Fabrízio de Royes Mello
suggesting that this would become documented behavior? I think they should be executed in alphabetical order like triggers. Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http

Re: [HACKERS] Strange debug message of walreciver?

2015-03-07 Thread Fabrízio de Royes Mello
receipttime 2015-03-08 00:17:21.450294-03 replication apply delay -1936495702 ms transfer latency 0 ms Maybe we should check before and return zero from GetReplicationApplyDelay. The attached patch implement it. Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http

Re: [HACKERS] Strange debug message of walreciver?

2015-03-08 Thread Fabrízio de Royes Mello
the delay data is not available? elog(DEBUG2, sendtime %s receipttime %s replication apply delay (N/A) transfer latency %d ms, Makes sense. Attached patch implement what you suggested. Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br

Re: [HACKERS] Error with index on unlogged table

2015-03-25 Thread Fabrízio de Royes Mello
a regression test to this end? Seems like something worth testing. I'm checking it and adding some regression tests. Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http://br.linkedin.com

Re: [HACKERS] Error with index on unlogged table

2015-03-25 Thread Fabrízio de Royes Mello
On Wed, Mar 25, 2015 at 12:46 PM, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: On Wed, Mar 25, 2015 at 10:53 AM, Andres Freund and...@2ndquadrant.com wrote: Did you check whether a similar bug was made in other places of 85b506bb? Could you additionally add a regression test

Re: [HACKERS] Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. );

2015-03-31 Thread Fabrízio de Royes Mello
On Mon, Mar 30, 2015 at 8:14 PM, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: On Mon, Mar 30, 2015 at 7:41 PM, Jim Nasby jim.na...@bluetreble.com wrote: On 3/27/15 2:23 PM, Fabrízio de Royes Mello wrote: Hi all, I'm tweaking some autovacuum settings in a table with high

Re: [HACKERS] Order of enforcement of CHECK constraints?

2015-03-23 Thread Fabrízio de Royes Mello
, + conscan = systable_beginscan(conrel, ConstraintNameNspIndexId, true, Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http://br.linkedin.com/in/fabriziomello Twitter: http://twitter.com

Re: [HACKERS] GSoC idea - Simulated annealing to search for query plans

2015-02-26 Thread Fabrízio de Royes Mello
. Yea, it was Jan Urbański (CCed). And the project link: https://github.com/wulczer/saio Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http://br.linkedin.com/in/fabriziomello Twitter: http

[HACKERS] Add CINE for ALTER TABLE ... ADD COLUMN

2015-02-26 Thread Fabrízio de Royes Mello
Hi all, This simple patch add CINE for ALTER TABLE ... ADD COLUMN. So now we can: ALTER TABLE foo ADD COLUMN IF NOT EXISTS c1 integer; and/or ... ALTER TABLE foo ADD COLUMN IF NOT EXISTS c1 integer, ADD COLUMN c2 integer; Regards, -- Fabrízio de Royes Mello Consultoria/Coaching

[HACKERS] Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. );

2015-03-27 Thread Fabrízio de Royes Mello
reloptions if we just touch in pg_class tuples (RowExclusiveLock) ? Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http://br.linkedin.com/in/fabriziomello Twitter: http://twitter.com

Re: [HACKERS] Order of enforcement of CHECK constraints?

2015-03-24 Thread Fabrízio de Royes Mello
(0,0); ERROR: new row for relation foo violates check constraint aa DETAIL: Failing row contains (0, 0). Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http://br.linkedin.com

Re: [HACKERS] Order of enforcement of CHECK constraints?

2015-03-24 Thread Fabrízio de Royes Mello
On Tue, Mar 24, 2015 at 4:28 PM, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: On Mon, Mar 23, 2015 at 12:33 PM, Tom Lane t...@sss.pgh.pa.us wrote: =?UTF-8?Q?Fabr=C3=ADzio_de_Royes_Mello?= fabriziome...@gmail.com writes: On Fri, Mar 20, 2015 at 4:37 PM, Tom Lane t

[HACKERS] GSoC 2015 proposal: Improve the performance of “ALTER TABLE .. SET LOGGED / UNLOGGED” statement

2015-03-25 Thread Fabrízio de Royes Mello
/09 for final evaluation and maybe will be committed to 9.6 version (webpage don’t created yet) August 18 - August 21 * do the adjustments based on the community feedback during the commitfest 2015/09 * final mentor review ** About the proponent ** Fabrízio de Royes Mello e-mail: fabriziome

Re: [HACKERS] Add CINE for ALTER TABLE ... ADD COLUMN

2015-04-23 Thread Fabrízio de Royes Mello
needs a rebase. Done! Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http://br.linkedin.com/in/fabriziomello Twitter: http://twitter.com/fabriziomello Github: http://github.com/fabriziomello

Re: [HACKERS] Can pg_dump make use of CURRENT/SESSION_USER

2015-04-25 Thread Fabrízio de Royes Mello
On Wed, Mar 18, 2015 at 2:24 PM, Robert Haas robertmh...@gmail.com wrote: On Wed, Mar 18, 2015 at 1:23 PM, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: If we ever implement something like COMMENT ON CURRENT_DATABASE IS ... it will be useful, because you will be able

Re: [HACKERS] Can pg_dump make use of CURRENT/SESSION_USER

2015-04-28 Thread Fabrízio de Royes Mello
On Tue, Apr 28, 2015 at 1:07 PM, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: On Tue, Apr 28, 2015 at 9:38 AM, Robert Haas robertmh...@gmail.com wrote: On Sat, Apr 25, 2015 at 8:05 AM, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: If we ever implement something

Re: [HACKERS] Can pg_dump make use of CURRENT/SESSION_USER

2015-04-28 Thread Fabrízio de Royes Mello
On Tue, Apr 28, 2015 at 9:38 AM, Robert Haas robertmh...@gmail.com wrote: On Sat, Apr 25, 2015 at 8:05 AM, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: If we ever implement something like COMMENT ON CURRENT_DATABASE IS ... it will be useful, because you

Re: [HACKERS] Can pg_dump make use of CURRENT/SESSION_USER

2015-04-29 Thread Fabrízio de Royes Mello
On Wed, Apr 29, 2015 at 1:14 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Fabrízio de Royes Mello wrote: Looking at the patch again I realize the code is very ugly, so I'll rework the patch. Yes, I think get_object_address should figure out what to do with the representation

Re: [HACKERS] PL/pgSQL, RAISE and error context

2015-04-27 Thread Fabrízio de Royes Mello
, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http://br.linkedin.com/in/fabriziomello Twitter: http://twitter.com/fabriziomello Github: http://github.com/fabriziomello

Re: [HACKERS] cache invalidation for PL/pgsql functions

2015-05-01 Thread Fabrízio de Royes Mello
to be extended in some way to support a new callback. IMHO we need a way to DISCARD run a cleanup code for each installed extension. Maybe with a new option like DISCARD EXTENSIONS. So each extension could have and register your own cleanup code. Regards, -- Fabrízio de Royes Mello Consultoria

Re: [HACKERS] psql :: support for \ev viewname and \sv viewname

2015-05-04 Thread Fabrízio de Royes Mello
ahead with this work. :-( I'll do some reviews. Regards, [1] http://softwarelivre.org/fisl13?lang=en [2] https://github.com/lhcezar/postgres/commit/b4bfc3b17b4a32850d6035165209b2b82746190a -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

2015-04-30 Thread Fabrízio de Royes Mello
] { INDEX | ... } name Thought? Looks good to me. Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http://br.linkedin.com/in/fabriziomello Twitter: http://twitter.com/fabriziomello Github: http

Re: [HACKERS] add -s to vacuumdb

2015-05-05 Thread Fabrízio de Royes Mello
to finish it. I know it's another thing but the internal refactoring in vacuumdb to support it enable us to add --system and --schema options also. Regards, [1] http://www.postgresql.org/message-id/CAFcNs+pHJLmLM9n=b6aofv3xppwhq+znnejv9ukvpnszyeg...@mail.gmail.com -- Fabrízio de Royes Mello

Re: [HACKERS] deparsing utility commands

2015-05-08 Thread Fabrízio de Royes Mello
this is push-able. Here is a complete version. Barring serious problems, I intend to commit this on Monday. You forgot to attach the patches! Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

2015-05-08 Thread Fabrízio de Royes Mello
On Fri, May 8, 2015 at 4:23 PM, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: On Thu, May 7, 2015 at 7:55 PM, Sawada Masahiko sawada.m...@gmail.com wrote: On 5/7/15, Sawada Masahiko sawada.m...@gmail.com wrote: On Wed, May 6, 2015 at 5:42 AM, Robert Haas robertmh...@gmail.com

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

2015-05-08 Thread Fabrízio de Royes Mello
const char *const list_REINDEX[] = {TABLE, INDEX, SYSTEM, SCHEMA, DATABASE, NULL}; COMPLETE_WITH_LIST(list_REINDEX); The attached fix it and now seems good to me. Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

2015-05-13 Thread Fabrízio de Royes Mello
, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http://br.linkedin.com/in/fabriziomello Twitter: http://twitter.com/fabriziomello Github: http://github.com/fabriziomello

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

2015-04-06 Thread Fabrízio de Royes Mello
and organization is ok 6) You should add the new field ReindexStmt-verbose to src/backend/nodes/copyfuncs.c Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http://br.linkedin.com/in/fabriziomello

[HACKERS] Re: [HACKERS] GSoC 2015 proposal: Improve the performance of “ALTER TABLE .. SET LOGGED / UNLOGGED” statement

2015-04-05 Thread Fabrízio de Royes Mello
On Thu, Apr 2, 2015 at 3:24 PM, Robert Haas robertmh...@gmail.com wrote: On Wed, Mar 25, 2015 at 9:46 PM, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: http://www.postgresql.org/message-id/ca+tgmozm+-0r7h0edpzzjbokvvq+gavkchmno4fypveccw-...@mail.gmail.com I like the idea

Re: [HACKERS] Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. );

2015-04-05 Thread Fabrízio de Royes Mello
On Wed, Apr 1, 2015 at 1:45 AM, Noah Misch n...@leadboat.com wrote: On Tue, Mar 31, 2015 at 01:17:03PM -0400, Robert Haas wrote: On Tue, Mar 31, 2015 at 9:11 AM, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: Attached a very WIP patch to reduce lock level when setting autovacuum

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

2015-04-07 Thread Fabrízio de Royes Mello
On Tue, Apr 7, 2015 at 7:22 AM, Sawada Masahiko sawada.m...@gmail.com wrote: Thank you for your reviewing. I modified the patch and attached latest version patch(v7). Please have a look it. Looks good to me. Attached patch (v8) just fix a tab indentation in gram.y. Regards, -- Fabrízio de

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

2015-04-07 Thread Fabrízio de Royes Mello
On Tue, Apr 7, 2015 at 1:04 PM, Sawada Masahiko sawada.m...@gmail.com wrote: On Tue, Apr 7, 2015 at 10:12 PM, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: On Tue, Apr 7, 2015 at 7:22 AM, Sawada Masahiko sawada.m...@gmail.com wrote: Thank you for your reviewing. I modified

Re: [HACKERS] Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. );

2015-04-07 Thread Fabrízio de Royes Mello
On Mon, Apr 6, 2015 at 12:53 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Fabrízio de Royes Mello wrote: Ok guys. The attached patch refactor the reloptions adding a new field lockmode in relopt_gen struct and a new method to determine the required lock level from an option list

Re: [HACKERS] Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. );

2015-04-07 Thread Fabrízio de Royes Mello
On Tue, Apr 7, 2015 at 10:15 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Fabrízio de Royes Mello wrote: On Mon, Apr 6, 2015 at 12:53 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Fabrízio de Royes Mello wrote: Ok guys. The attached patch refactor the reloptions

Re: [HACKERS] Removal of FORCE option in REINDEX

2015-04-07 Thread Fabrízio de Royes Mello
keeping supporting it. Thought? +1 -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http://br.linkedin.com/in/fabriziomello Twitter: http://twitter.com/fabriziomello Github: http://github.com

Re: [HACKERS] Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. );

2015-04-10 Thread Fabrízio de Royes Mello
On Tue, Apr 7, 2015 at 10:57 PM, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: On Tue, Apr 7, 2015 at 10:15 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Fabrízio de Royes Mello wrote: On Mon, Apr 6, 2015 at 12:53 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote

Re: [HACKERS] Change pg_cancel_*() to ignore current backend

2015-05-19 Thread Fabrízio de Royes Mello
functions: allow_own_pid DEFAULT false. To me that seems better than an entirely separate set of functions. +1 to add a second parameter to current functions. -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io

Re: [HACKERS] Change pg_cancel_*() to ignore current backend

2015-05-20 Thread Fabrízio de Royes Mello
On Wed, May 20, 2015 at 2:40 AM, Jim Nasby jim.na...@bluetreble.com wrote: On 5/19/15 9:19 PM, Fabrízio de Royes Mello wrote: We could add a second parameter to the current functions: allow_own_pid DEFAULT false. To me that seems better than an entirely separate set of functions

Re: [HACKERS] Add CINE for ALTER TABLE ... ADD COLUMN

2015-06-25 Thread Fabrízio de Royes Mello
On Wed, Jun 24, 2015 at 3:36 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Fabrízio de Royes Mello wrote: Another rebased version. There are a number of unrelated whitespace changes in this patch; also please update the comment on top of check_for_column_name_collision. Sorry, bad

Re: [HACKERS] Add CINE for ALTER TABLE ... ADD COLUMN

2015-06-24 Thread Fabrízio de Royes Mello
On Thu, Apr 23, 2015 at 12:05 PM, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: On Wed, Apr 22, 2015 at 3:48 PM, Payal Singh pa...@omniti.com wrote: The following review has been posted through the commitfest application: make installcheck-world: tested, failed Implements

[HACKERS] Re: [HACKERS] GSoC 2015 proposal: Improve the performance of “ALTER TABLE .. SET LOGGED / UNLOGGED” statement

2015-07-03 Thread Fabrízio de Royes Mello
On Thu, Apr 2, 2015 at 3:24 PM, Robert Haas robertmh...@gmail.com wrote: On Wed, Mar 25, 2015 at 9:46 PM, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: http://www.postgresql.org/message-id/ca+tgmozm+-0r7h0edpzzjbokvvq+gavkchmno4fypveccw-...@mail.gmail.com I like the idea

[HACKERS] Missing -i / --ignore-version in pg_dump help

2015-05-22 Thread Fabrízio de Royes Mello
Hi all, There are some reason to -i, --ignore-version option doesn't appear in pg_dump help? Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http://br.linkedin.com/in/fabriziomello Twitter

[HACKERS] Add some spaces to ALTER TABLE doc

2015-05-22 Thread Fabrízio de Royes Mello
Hi all, The attached add some spaces to better visualization of the ALTER TABLE doc. Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http://br.linkedin.com/in/fabriziomello Twitter: http

Re: [HACKERS] Missing -i / --ignore-version in pg_dump help

2015-05-22 Thread Fabrízio de Royes Mello
On Fri, May 22, 2015 at 9:20 AM, Fujii Masao masao.fu...@gmail.com wrote: On Fri, May 22, 2015 at 8:59 PM, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: Hi all, There are some reason to -i, --ignore-version option doesn't appear in pg_dump help? Because it's obsolete option

Re: [HACKERS] Change pg_cancel_*() to ignore current backend

2015-05-22 Thread Fabrízio de Royes Mello
a second parameter and -1 to break backward compatibility with the default = true. Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http://br.linkedin.com/in/fabriziomello Twitter: http

[HACKERS] Re: [HACKERS] GSoC 2015 proposal: Improve the performance of “ALTER TABLE .. SET LOGGED / UNLOGGED” statement

2015-07-07 Thread Fabrízio de Royes Mello
On Fri, Jul 3, 2015 at 9:29 AM, Ashutosh Bapat ashutosh.ba...@enterprisedb.com wrote: On Fri, Jul 3, 2015 at 4:48 PM, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: On Thu, Apr 2, 2015 at 3:24 PM, Robert Haas robertmh...@gmail.com wrote: On Wed, Mar 25, 2015 at 9:46 PM

Re: [HACKERS] Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. );

2015-08-03 Thread Fabrízio de Royes Mello
://www.zenvia.com.br) -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http://br.linkedin.com/in/fabriziomello Twitter: http://twitter.com/fabriziomello Github: http://github.com/fabriziomello

Re: [HACKERS] Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. );

2015-08-04 Thread Fabrízio de Royes Mello
) -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http://br.linkedin.com/in/fabriziomello Twitter: http://twitter.com/fabriziomello Github: http://github.com/fabriziomello diff --git a/doc/src/sgml/ref

Re: [HACKERS] Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. );

2015-07-31 Thread Fabrízio de Royes Mello
On Fri, Jul 31, 2015 at 10:01 AM, Michael Paquier michael.paqu...@gmail.com wrote: On Fri, Jul 31, 2015 at 11:41 AM, Fabrízio de Royes Mello wrote: We usually don't compare lock values that way, i.e. there's not guaranteed to be a strict monotonicity between lock levels. I don't really

Re: [HACKERS] Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. );

2015-07-30 Thread Fabrízio de Royes Mello
to compare lock values to get the highest lock level? Perhaps creating a function to compare lock levels? Regards, *** This work is funded by Zenvia Mobile Results (http://www.zenvia.com.br) -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http

Re: [HACKERS] Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. );

2015-07-30 Thread Fabrízio de Royes Mello
suggestions. Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http://br.linkedin.com/in/fabriziomello Twitter: http://twitter.com/fabriziomello Github: http://github.com/fabriziomello diff

Re: [HACKERS] Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. );

2015-08-05 Thread Fabrízio de Royes Mello
-levels used for DDL are, and will always be, self-exclusive, so why all this hand-wringing? New version attached with suggested changes. Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http

Re: [HACKERS] Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. );

2015-08-06 Thread Fabrízio de Royes Mello
On Wed, Aug 5, 2015 at 9:21 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Thu, Aug 6, 2015 at 3:06 AM, Fabrízio de Royes Mello wrote: On Wed, Aug 5, 2015 at 9:31 AM, Robert Haas wrote: Agreed. I think we're making a mountain out of a molehill here. As long as the locks

Re: [HACKERS] Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. );

2015-07-23 Thread Fabrízio de Royes Mello
is funded by Zenvia Mobile Results (http://www.zenvia.com.br) -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http://br.linkedin.com/in/fabriziomello Twitter: http://twitter.com/fabriziomello Github: http

Re: [HACKERS] security labels on databases are bad for dump restore

2015-07-22 Thread Fabrízio de Royes Mello
://commitfest.postgresql.org/5/229/ Unfortunately this code is a bit weird and will be better to move to the next commitfest (I have no time to improve it yet), so we can join efforts and implement all ideas and make the reviewers life easier with a more consistency patch. Seems reasonable? Regards, -- Fabrízio de

Re: [HACKERS] Add CINE for ALTER TABLE ... ADD COLUMN

2015-07-22 Thread Fabrízio de Royes Mello
exist if if_not_exists is true. Improved the comment. Except that the implementation looks sane to me. Thank you for the review. Att, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http

Re: [HACKERS] proposal: multiple psql option -c

2015-07-16 Thread Fabrízio de Royes Mello
, notes, comments? Why you want it if we already have the -f option that cover this use case? Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http://br.linkedin.com/in/fabriziomello Twitter

Re: [HACKERS] Commitfest remaining Needs Review items

2015-08-25 Thread Fabrízio de Royes Mello
. Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http://br.linkedin.com/in/fabriziomello Twitter: http://twitter.com/fabriziomello Github: http://github.com/fabriziomello

Re: [HACKERS] Getting sorted data from foreign server

2015-10-27 Thread Fabrízio de Royes Mello
ss we will benefit from the >> sort, and clearly that's not what happened here. >> > > PFA patch with the default multiplication factor for sort bumped up to 1.2. > +/* If no remote estimates, assume a sort costs 10% extra */ +#define DEFAULT_FDW_SORT_MULTIPLIE

Re: [HACKERS] Git cartoon

2015-11-09 Thread Fabrízio de Royes Mello
Em segunda-feira, 9 de novembro de 2015, Albe Laurenz < laurenz.a...@wien.gv.at> escreveu: > Fabrízio de Royes Mello wrote: > > Em domingo, 8 de novembro de 2015, Bruce Momjian <br...@momjian.us > <javascript:;>> escreveu: > >> This git cartoon was too fun

Re: [HACKERS] Git cartoon

2015-11-07 Thread Fabrízio de Royes Mello
Em domingo, 8 de novembro de 2015, Bruce Momjian <br...@momjian.us> escreveu: > This git cartoon was too funny not to share: > > http://xkcd.com/1597/ > > Maybe we need it on our git wiki page. ;-) > I think we need our own cartoon with a funny DB story. --

Re: [HACKERS] proposal: DROP DATABASE variant that kills active sessions

2015-10-16 Thread Fabrízio de Royes Mello
be any interest. > > I think this would be a useful feature. What would one do about > prepared transactions? > Isn't "rollback all prepared" before an option? Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.b

[HACKERS] Re: [HACKERS] GSoC 2015 proposal: Improve the performance of “ALTER TABLE .. SET LOGGED / UNLOGGED” statement

2015-07-08 Thread Fabrízio de Royes Mello
checking the datafiles with the stamped init fork ( _init_XID, or something else) Is this reasonable? Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http://br.linkedin.com/in/fabriziomello Twitter

[HACKERS] Re: [HACKERS] Re: [HACKERS] GSoC 2015 proposal: Improve the performance of “ALTER TABLE .. SET LOGGED / UNLOGGED” statement

2015-07-08 Thread Fabrízio de Royes Mello
On Wed, Jul 8, 2015 at 10:53 AM, Andres Freund and...@anarazel.de wrote: On 2015-07-03 08:18:09 -0300, Fabrízio de Royes Mello wrote: *** ALTER TABLE changes ... Without going into the specifics of this change: Are we actually sure this feature warrants the complexity it'll introduce? I'm

[HACKERS] Re: [HACKERS] Re: [HACKERS] GSoC 2015 proposal: Improve the performance of “ALTER TABLE .. SET LOGGED / UNLOGGED” statement

2015-07-09 Thread Fabrízio de Royes Mello
On Thu, Jul 9, 2015 at 10:56 AM, Andres Freund and...@anarazel.de wrote: On 2015-07-09 10:39:35 -0300, Fabrízio de Royes Mello wrote: If the wal_level=minimal we don't need to force the wal log of the contents. If the wal_level != minimal we need just to xlog all the pages, but in both

[HACKERS] Re: [HACKERS] Re: [HACKERS] GSoC 2015 proposal: Improve the performance of “ALTER TABLE .. SET LOGGED / UNLOGGED” statement

2015-07-09 Thread Fabrízio de Royes Mello
On Wed, Jul 8, 2015 at 11:37 AM, Andres Freund and...@anarazel.de wrote: On 2015-07-08 10:58:51 -0300, Fabrízio de Royes Mello wrote: Think in an ETL job that can be use an unlogged table to improve the load performance, but this job create a large table and to guarantee the data

Re: [HACKERS] Is this a bug?

2015-08-26 Thread Fabrízio de Royes Mello
-- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL Timbira: http://www.timbira.com.br Blog: http://fabriziomello.github.io Linkedin: http://br.linkedin.com/in/fabriziomello Twitter: http://twitter.com/fabriziomello Github: http://github.com/fabriziomello

Re: [HACKERS] Is this a bug?

2015-08-26 Thread Fabrízio de Royes Mello
On Wed, Aug 26, 2015 at 4:30 PM, Andres Freund and...@anarazel.de wrote: On 2015-08-26 16:24:31 -0300, Fabrízio de Royes Mello wrote: Why this patch was reverted one day after applied [1]? I didn't see any discussion around it. http://www.postgresql.org/message-id/23918.1409010

Re: [HACKERS] Is this a bug?

2015-08-26 Thread Fabrízio de Royes Mello
On Wed, Aug 26, 2015 at 4:31 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Fabrízio de Royes Mello wrote: Why this patch was reverted one day after applied [1]? I didn't see any discussion around it. Contributors whose patches are getting committed should really subscribe to pgsql

Re: [HACKERS] Can pg_dump make use of CURRENT/SESSION_USER

2015-09-03 Thread Fabrízio de Royes Mello
My intention was move to next commitfest and finish the "rework", but I didn't finish it due some other professional priorities. Sorry by the noise. > I'm marking the patch as returned with feedback again. Once there's a > new patch we can deal with it in the appropriate commitfest.

Re: [HACKERS] Patch: fix lock contention for HASHHDR.mutex

2016-01-02 Thread Fabrízio de Royes Mello
unning configure with --enable-depend should avoid this problem. >> >> I still maintain that --enable-depend should be on by default. We're > > > +1 > +1, I always use it. -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br

Re: [HACKERS] blocking the alter role command

2016-01-12 Thread Fabrízio de Royes Mello
a lot. > You should implement an extension using ProcessUtility_hook todo that. See an example in [1] Regards, [1] https://github.com/michaelpq/pg_plugins/tree/master/hook_utility -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br

Re: [HACKERS] hstore: add hstore_length function

2016-06-06 Thread Fabrízio de Royes Mello
tion use 'uint32' instead of 'int' ?? + int count = HS_COUNT(hs); + + PG_RETURN_INT32(count); maybe + uint32 count = HS_COUNT(hs); + + PG_RETURN_UINT32(count); Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >&

Re: [HACKERS] [PROPOSAL] Move all am-related reloption code into src/backend/access/[am-name] and get rid of relopt_kind

2016-05-25 Thread Fabrízio de Royes Mello
Regards, [1] https://www.postgresql.org/message-id/cafj8prcx_vdcsdbumknhhyr_-n_ctl84_7r+-bj17hckt_m...@mail.gmail.com [2] https://www.postgresql.org/message-id/ca+tgmoznfdqt2kotx38yjus3f_avisclxawbmpdwxhyxrg_...@mail.gmail.com -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL &

[HACKERS] Reduce lock levels others reloptions in ALTER TABLE

2016-02-29 Thread Fabrízio de Royes Mello
- n_distinct - n_distinct_inherited - buffering Att, [1] http://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=47167b7907a802ed39b179c8780b76359468f076 [2] http://www.postgresql.org/message-id/20150731022857.gc11...@alap3.anarazel.de -- Fabrízio de Royes Mello Consultoria/Coaching

Re: [HACKERS] Reduce lock levels others reloptions in ALTER TABLE

2016-02-29 Thread Fabrízio de Royes Mello
On Mon, Feb 29, 2016 at 2:58 PM, Fabrízio de Royes Mello < fabriziome...@gmail.com> wrote: > > Hi all, > > Some time ago we added [1] the infrastructure to allow different lock levels for relation options. > > So per discussion [2] the attached patch

Re: [HACKERS] Publish autovacuum informations

2016-02-29 Thread Fabrízio de Royes Mello
vacuum.so '/data/home/fabrizio/pgsql/lib/pg_stat_autovacuum.so' /usr/bin/install -c -m 644 .//pg_stat_autovacuum.control '/data/home/fabrizio/pgsql/share/extension/' /usr/bin/install -c -m 644 .//pg_stat_autovacuum--0.0.1.sql '/data/home/fabrizio/pgsql/share/extension/' /usr/bin/install -

Re: [HACKERS] PostgreSQL extension API? Documentation?

2016-02-27 Thread Fabrízio de Royes Mello
e not exposed, so we should define an internal API to expose this kind of information. So depending what problem you want to solve you can write an extension to do that. Then unfortunately the short aswer is "depend". Regards, -- Fabrízio de Royes Mello Consultoria/Coaching Postgr

Re: [HACKERS] Sequence Access Method WIP

2016-03-28 Thread Fabrízio de Royes Mello
gt; 0 AND max_value = 9223372036854775807 THEN NULL WHEN increment_by < 0 AND max_value = -1 THEN NULL ELSE max_value END AS max_value, CASE WHEN increment_by > 0 AND min_value = 1 THEN NULL WHEN increment_by < 0 AND min_value = -9223372036854775807 THEN NULL ELSE min_value

[HACKERS] Unused macros in src/include/access/transam.h

2016-04-05 Thread Fabrízio de Royes Mello
Hi all, When dealing with some patch review I've noticed there are two macro is not used anywhere: #define TransactionIdStore(xid, dest) (*(dest) = (xid)) #define StoreInvalidTransactionId(dest) (*(dest) = InvalidTransactionId) Regards, -- Fabrízio de Royes Mello Consultoria/Coaching

Re: [HACKERS] NOT EXIST for PREPARE

2016-03-22 Thread Fabrízio de Royes Mello
lity to PREPARE? > > I think you meant IF NOT EXISTS, right? Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabriziomello.github.io >> Linkedin: http://br.linkedin.com/in/fabriziomello >> T

Re: [HACKERS] NOT EXIST for PREPARE

2016-03-22 Thread Fabrízio de Royes Mello
Em terça-feira, 22 de março de 2016, Yury Zhuravlev < u.zhurav...@postgrespro.ru> escreveu: > Fabrízio de Royes Mello wrote: > >> I think you meant IF NOT EXISTS, right? >> > Thanks, you right. > > You already have a patch? If yes I'm glad to review it. Regar

Re: [HACKERS] NOT EXIST for PREPARE

2016-03-22 Thread Fabrízio de Royes Mello
pping", stmt->name))); 3) There are no regression tests 4) There are no docs Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabriziomello.github.io >> Linkedin:

Re: [HACKERS] NOT EXIST for PREPARE

2016-03-22 Thread Fabrízio de Royes Mello
On Tue, Mar 22, 2016 at 2:32 PM, Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: > > Yury Zhuravlev wrote: > > Fabrízio de Royes Mello wrote: > > >You already have a patch? If yes I'm glad to review it. > > > > If the community is not against it,

Re: [HACKERS] NOT EXIST for PREPARE

2016-03-22 Thread Fabrízio de Royes Mello
On Tue, Mar 22, 2016 at 6:16 PM, Yury Zhuravlev <u.zhurav...@postgrespro.ru> wrote: > > Fabrízio de Royes Mello wrote: >> >> >> You're correct. Yury please add your patch to the next commitfest. > > Done. But I do not have restrictions as part of our P

Re: [HACKERS] NOT EXIST for PREPARE

2016-03-22 Thread Fabrízio de Royes Mello
> statement somehow. > You're correct, but IMHO it should be used when you have control of prepared statement... isn't it analogous to CREATE TABLE IF NOT EXISTS?? -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://

<    1   2   3   4   5   >