Re: [HACKERS] On-demand running query plans using auto_explain and signals

2015-09-01 Thread Pavel Stehule
2015-09-01 15:00 GMT+02:00 Shulgin, Oleksandr : > I'd say we should hide the so-designed pg_cmdstatus() interface behind >>> more friendly calls like pg_explain_backend() and pg_backend_progress() to >>> give some naming examples, to remove the need for magic numbers in the >>> second arg. >>> >>

Re: [HACKERS] On-demand running query plans using auto_explain and signals

2015-09-01 Thread Pavel Stehule
r when some pathological problems are - and you cannot restart cluster in production week, sometimes weeks. The slots are more robust. Pavel > > -- > Alex > >

Re: [HACKERS] [PATCH] SQL function to report log message

2015-09-01 Thread Pavel Stehule
2015-09-02 0:13 GMT+02:00 Jim Nasby : > On 9/1/15 12:47 AM, Pavel Stehule wrote: > >> >> Wouldn't it be better to create an ENUM of error levels instead of >> inventing more parsing code? >> >> >> Do you think SQL ENUM? I little bit af

Re: [HACKERS] On-demand running query plans using auto_explain and signals

2015-09-02 Thread Pavel Stehule
2015-09-02 11:01 GMT+02:00 Shulgin, Oleksandr : > On Tue, Sep 1, 2015 at 7:02 PM, Pavel Stehule > wrote: > >> >>> But do we really need the slots mechanism? Would it not be OK to just >>> let the LWLock do the sequencing of concurrent requests? Given that we

Re: [HACKERS] On-demand running query plans using auto_explain and signals

2015-09-02 Thread Pavel Stehule
2015-09-02 12:36 GMT+02:00 Shulgin, Oleksandr : > On Wed, Sep 2, 2015 at 11:16 AM, Pavel Stehule > wrote: > >> >> >> 2015-09-02 11:01 GMT+02:00 Shulgin, Oleksandr < >> oleksandr.shul...@zalando.de>: >> >>> On Tue, Sep 1, 2015 at 7:02 PM, Pav

Re: [HACKERS] On-demand running query plans using auto_explain and signals

2015-09-02 Thread Pavel Stehule
2015-09-02 15:00 GMT+02:00 Shulgin, Oleksandr : > On Wed, Sep 2, 2015 at 2:56 PM, Pavel Stehule > wrote: > >> >> >> 2015-09-02 12:36 GMT+02:00 Shulgin, Oleksandr < >> oleksandr.shul...@zalando.de>: >> >>> On Wed, Sep 2, 2015 at 11:16 AM, P

Re: [HACKERS] psql tabcomplete - minor bugfix - tabcomplete for SET ROLE TO xxx

2015-09-02 Thread Pavel Stehule
Hi 2015-09-02 15:23 GMT+02:00 Andres Freund : > Hi, > > On 2015-07-08 14:50:37 +0200, Pavel Stehule wrote: > > - static const char *const my_list[] = > > - {"DEFAULT", NULL}; > > +

Re: [HACKERS] On-demand running query plans using auto_explain and signals

2015-09-03 Thread Pavel Stehule
Hi 2015-09-03 18:30 GMT+02:00 Shulgin, Oleksandr : > On Wed, Sep 2, 2015 at 3:07 PM, Shulgin, Oleksandr < > oleksandr.shul...@zalando.de> wrote: > >> On Wed, Sep 2, 2015 at 3:04 PM, Pavel Stehule >> wrote: >>> >>> >>>> Well,

Re: [HACKERS] On-demand running query plans using auto_explain and signals

2015-09-03 Thread Pavel Stehule
2015-09-03 22:06 GMT+02:00 Pavel Stehule : > Hi > > > > > 2015-09-03 18:30 GMT+02:00 Shulgin, Oleksandr < > oleksandr.shul...@zalando.de>: > >> On Wed, Sep 2, 2015 at 3:07 PM, Shulgin, Oleksandr < >> oleksandr.shul...@zalando.de> wrote: >

Re: [HACKERS] On-demand running query plans using auto_explain and signals

2015-09-03 Thread Pavel Stehule
2015-09-04 5:50 GMT+02:00 Shulgin, Oleksandr : > On Sep 3, 2015 10:14 PM, "Pavel Stehule" wrote: > >>> > >>> Please find attached a v3. > >>> > >>> It uses a shared memory queue and also has the ability to capture > plans nested dee

Re: [HACKERS] proposal: function parse_ident

2015-09-03 Thread Pavel Stehule
2015-09-03 13:11 GMT+02:00 Andres Freund : > On 2015-08-23 17:46:36 +0200, Pavel Stehule wrote: > > here is the patch > > > > It is really trivial - all heavy work was done done before. > > This seems to entirely disregard the comments in > http://arch

Re: [HACKERS] [PATCH] SQL function to report log message

2015-09-04 Thread Pavel Stehule
2015-09-02 21:49 GMT+02:00 dinesh kumar : > On Mon, Aug 31, 2015 at 10:08 PM, Pavel Stehule > wrote: > >> >> >> 2015-09-01 6:59 GMT+02:00 Pavel Stehule : >> >>> >>> >>> 2015-08-31 20:43 GMT+02:00 dinesh kumar : >>> >>

Re: [HACKERS] [PATCH] SQL function to report log message

2015-09-04 Thread Pavel Stehule
2015-09-02 21:49 GMT+02:00 dinesh kumar : > On Mon, Aug 31, 2015 at 10:08 PM, Pavel Stehule > wrote: > >> >> >> 2015-09-01 6:59 GMT+02:00 Pavel Stehule : >> >>> >>> >>> 2015-08-31 20:43 GMT+02:00 dinesh kumar : >>> >>

Re: [HACKERS] [PATCH] SQL function to report log message

2015-09-05 Thread Pavel Stehule
2015-09-05 8:35 GMT+02:00 dinesh kumar : > > > On Fri, Sep 4, 2015 at 2:03 PM, Pavel Stehule > wrote: > >> >> >> 2015-09-02 21:49 GMT+02:00 dinesh kumar : >> >>> On Mon, Aug 31, 2015 at 10:08 PM, Pavel Stehule >> > wrote: &

Re: [HACKERS] PL/pgSQL, RAISE and error context

2015-09-05 Thread Pavel Stehule
> Pushed. I'm not too sure about the expected outputs for python other > than 2.6, nor for sepgsql, but hopefully the buildfarm will provide > feedback. > > Thank you very much Pavel

Re: [HACKERS] [PATCH] SQL function to report log message

2015-09-06 Thread Pavel Stehule
Pavel diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml new file mode 100644 index b3b78d2..c0b6a72 *** a/doc/src/sgml/func.sgml --- b/doc/src/sgml/func.sgml *** postgres=# SELECT * FROM pg_xlogfile_nam *** 17925,17930 --- 17925,17939 Return information about a

Re: [HACKERS] [PATCH] SQL function to report log message

2015-09-06 Thread Pavel Stehule
Hi attached patch with fixed broken error message Regards Pavel diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml new file mode 100644 index b3b78d2..b7a2cc2 *** a/doc/src/sgml/func.sgml --- b/doc/src/sgml/func.sgml *** postgres=# SELECT * FROM pg_xlogfile_nam

Re: [HACKERS] [PATCH] SQL function to report log message

2015-09-06 Thread Pavel Stehule
2015-09-06 13:12 GMT+02:00 dinesh kumar : > > On Sun, Sep 6, 2015 at 4:00 PM, dinesh kumar > wrote: > >> On Sun, Sep 6, 2015 at 3:39 PM, Pavel Stehule >> wrote: >> >>> Hi >>> >>> attached patch with fixed broken error message >>&g

Re: [HACKERS] pg_hba_lookup function to get all matching pg_hba.conf entries

2015-09-06 Thread Pavel Stehule
Hi > Any suggestions/comments on this proposed approach? > This is interesting functionality - The same was requested by one important Czech customer. I'll do review Regards Pavel

Re: [HACKERS] pg_hba_lookup function to get all matching pg_hba.conf entries

2015-09-06 Thread Pavel Stehule
hba conf from these partial views. There can be other way - theoretically we can have a function pg_hba_debug with similar API like pg_hba_conf. The result will be a content of pg_hba.conf with information about result of any rule. Regards Pavel

Re: [HACKERS] [patch] Proposal for \rotate in psql

2015-09-07 Thread Pavel Stehule
It's pretty clear what it means and it sounds > similar to but not exactly the same as pivot. > rotate ~ sounds like transpose matrix, what is not true in this case. Pavel > > -- > greg >

Re: [HACKERS] On-demand running query plans using auto_explain and signals

2015-09-07 Thread Pavel Stehule
2015-09-07 11:55 GMT+02:00 Shulgin, Oleksandr : > On Fri, Sep 4, 2015 at 6:11 AM, Pavel Stehule > wrote: > >> Sorry, but I still don't see how the slots help this issue - could you >>> please elaborate? >>> >> with slot (or some similiar) there is n

Re: [HACKERS] psql tabcomplete - minor bugfix - tabcomplete for SET ROLE TO xxx

2015-09-07 Thread Pavel Stehule
2015-09-07 21:44 GMT+02:00 Andres Freund : > Hi, > > On 2015-09-02 22:58:21 +0200, Pavel Stehule wrote: > > > Won't that mean that enum variables don't complete to default anymore? > > > no, it does > > > > #define Query_for_enum \ > > &qu

Re: [HACKERS] proposal: function parse_ident

2015-09-08 Thread Pavel Stehule
2015-09-08 14:06 GMT+02:00 Robert Haas : > On Fri, Sep 4, 2015 at 12:24 AM, Pavel Stehule > wrote: > > The alghoritm for parsing identifiers is same - the differences are in a > > names of levels, and in ending symbols. > > > > I don't would to write totally g

Re: [HACKERS] proposal: function parse_ident

2015-09-08 Thread Pavel Stehule
ot;.NAZDAR[]'::text); ┌───┬───┐ │ parts │ other │ ╞═══╪═══╡ │ {AHOJ,nazdar} │ []│ └───┴───┘ (1 row) Regards Pavel diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml new file mode 100644 index b3b78d2..75ea33a *** a/doc/s

Re: [HACKERS] [patch] Proposal for \rotate in psql

2015-09-08 Thread Pavel Stehule
2015-09-08 22:55 GMT+02:00 Daniel Verite : > Pavel Stehule wrote: > > > rotate ~ sounds like transpose matrix, what is not true in this case. > for me the relation rotation is exactly what \x does > > The various definitions that I can see, such as > http://

Re: [HACKERS] proposal: function parse_ident

2015-09-08 Thread Pavel Stehule
Hi I sending the path with little bit enhanced parser - it doesn't support utf8 alpha in identifiers yet Regards Pavel diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml new file mode 100644 index b3b78d2..75ea33a *** a/doc/src/sgml/func.sgml --- b/doc/src/sgml/func

Re: [HACKERS] On-demand running query plans using auto_explain and signals

2015-09-08 Thread Pavel Stehule
InfoHook - and it can be used for any customer probes - memory, cpu, ... 2. With your support for explain of nested queries we have all what we need for integration auto_explain to core. Regards Pavel > > -- > Alex > >

Re: [HACKERS] proposal: function parse_ident

2015-09-09 Thread Pavel Stehule
next iteration - fixed bug in parsing UTF8 chars, enhanced error messages. Regards Pavel diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml new file mode 100644 index b3b78d2..75ea33a *** a/doc/src/sgml/func.sgml --- b/doc/src/sgml/func.sgml *** *** 1707,1712

Re: [HACKERS] On-demand running query plans using auto_explain and signals

2015-09-09 Thread Pavel Stehule
te see how that follows. What I'm really after is > bringing instrumentation support to this, so that not only plan could be > extracted, but also the rows/loops/times accumulated thus far during the > query run. > It is possible, but not necessary step - but it is premature question in this moment Regards Pavel > > -- > Alex > >

Re: [HACKERS] [patch] Proposal for \rotate in psql

2015-09-09 Thread Pavel Stehule
> > > \x doesn't exactly rotate it either. \x puts the column headers down > the side instead of across the top, but it doesn't put the rows across > the top instead of down the side. Rather, each row is listed in a > separate chunk. true, it is rotation per one row. I was wrong. > This featu

Re: [HACKERS] [PATCH] SQL function to report log message

2015-09-09 Thread Pavel Stehule
should we force that on > > everyone? > > +20 or so here, that being the number of times I recall offhand having > written the function. > I have same opinion - it is pretty often used function. Pavel > > Cheers, > David. > -- > David Fetter http://f

Re: [HACKERS] proposal: function parse_ident

2015-09-09 Thread Pavel Stehule
Hi 2015-09-09 21:55 GMT+02:00 Alvaro Herrera : > Pavel Stehule wrote: > > > I cannot to use current SplitIdentifierString because it is designed for > > different purpose - and it cannot to separate non identifier part. But > the > > code is simple - and will be

Re: [HACKERS] proposal: function parse_ident

2015-09-11 Thread Pavel Stehule
Hi new update of parse_ident function patch Regards Pavel diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml new file mode 100644 index 22d4f61..1581d5a *** a/doc/src/sgml/func.sgml --- b/doc/src/sgml/func.sgml *** *** 1707,1712 --- 1707,1727

Re: [HACKERS] Review: check existency of table for -t option (pg_dump) when pattern...

2015-09-11 Thread Pavel Stehule
y table for work", second says "There are not specific table(s) with specific names (mask)". I am thinking so this information is enough interesting for showing. Can be changed to "No matching table(s) were found for filter "aaa*" &qu

Re: [HACKERS] On-demand running query plans using auto_explain and signals

2015-09-12 Thread Pavel Stehule
le. So perhaps this is non-trivial. > > - And finally, I think we should really support all existing EXPLAIN > formats, not just text. We need to support the other formats (yaml, > json, xml) if we want to use the EXPLAIN PID approach, and it also > makes the plans easier to proces

Re: [HACKERS] Add CREATE support to event triggers

2014-01-14 Thread Pavel Stehule
Hello 2014/1/13 Alvaro Herrera > Alvaro Herrera escribió: > > > In an event trigger, the function > pg_event_trigger_get_creation_commands() > > returns the following JSON blob: > > After playing with this for a while, I realized something that must have > seemed quite obvious to those paying a

Re: [HACKERS] plpgsql.consistent_into

2014-01-14 Thread Pavel Stehule
in this case, it should be safe to make the new default behavior > STRICT; if you forget to set the GUC to disable than you'll get an error > that points directly at the problem, at which point you'll go "Oh, yeah... > I forgot to set X..." > > I disagree - STRICT

Re: [HACKERS] plpgsql.consistent_into

2014-01-14 Thread Pavel Stehule
ther one can see it as bug. My opinion - it is a bug with possible ambiguous result and possible negative performance impacts. Probably we can precise a doc about wrong and good usage SELECT INTO clause. I am working on plpgsql_debug extension and I am thinking so I am able (with small change in plpgsql executor) implement this check as extension. So it can be available for advanced users (that will has a knowledge about additional plpgsql extensions). Regards Pavel regards Pavel > > best regards, > Florian Pflug > > > > > > >

Re: [HACKERS] plpgsql.consistent_into

2014-01-14 Thread Pavel Stehule
by itself? >>a = (SELECT foo FROM table); >> > only this form is allowed in SQL/PSM - and it has some logic - you can assign result of subquery (should be one row only) to variable. > > That looks like a scalar subquery, which is wrong because they can't > r

Re: [HACKERS] plpgsql.consistent_into

2014-01-14 Thread Pavel Stehule
Hello 2014/1/14 Marko Tiikkaja > On 1/14/14 1:28 PM, Pavel Stehule wrote: > >> I prefer subquery only syntax - a := (some) or (a,b,c) = (some a,b,c) with >> possible enhancing for statements with RETURNING >> >> a advance is compatibility with DB2 (SQL/PSM) syntax

Re: [HACKERS] plpgsql.consistent_into

2014-01-15 Thread Pavel Stehule
to have different meaning for = and :=. It is probably second the most ugly thing on plpgsql. I don't know about other crippled embedded SQL statement in any stored procedure language. Regards Pavel > > > I'm not too sure what it'd take to make this work. Right now,

Re: [HACKERS] plpgsql.warn_shadow

2014-01-15 Thread Pavel Stehule
rns as > well. > In this context is not clean if this option is related to plpgsql compile warnings, plpgsql executor warnings or general warnings. plpgsql.compile_warnings = "disabled", "enabled", "fatal" Regards Pavel > > > Regards, > Marko Tiikkaja > > > > -- > Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgsql-hackers >

Re: [HACKERS] plpgsql.warn_shadow

2014-01-15 Thread Pavel Stehule
2014/1/15 Marko Tiikkaja > On 1/15/14 11:20 AM, Pavel Stehule wrote: > > 2014/1/15 Marko Tiikkaja >> >>> Hmm. How about: >>> >>>plpgsql.warnings = 'all' # enable all warnings, defauls to the empty >>> list, i.e. no warnings >

Re: [HACKERS] plpgsql.warn_shadow

2014-01-15 Thread Pavel Stehule
2014/1/15 Marko Tiikkaja > On 1/15/14 11:33 AM, Pavel Stehule wrote: > >> 2014/1/15 Marko Tiikkaja >> >> I agree, it's better to include the word "compiler" in the GUC name. But >>> do we really need WARNING, ERROR and FATAL levels th

Re: [HACKERS] plpgsql.warn_shadow

2014-01-15 Thread Pavel Stehule
2014/1/15 Florian Pflug > On Jan15, 2014, at 11:20 , Pavel Stehule wrote: > > 2014/1/15 Marko Tiikkaja > > On 1/15/14 7:07 AM, Florian Pflug wrote: > > On Jan15, 2014, at 01:34 , Marko Tiikkaja wrote: > > It's me again, trying to find a solution to the most

Re: [HACKERS] plpgsql.warn_shadow

2014-01-15 Thread Pavel Stehule
2014/1/15 Marko Tiikkaja > On 1/15/14 2:00 PM, Florian Pflug wrote: > >> On Jan15, 2014, at 13:32 , Marko Tiikkaja wrote: >> >>> On 1/15/14 1:23 PM, Florian Pflug wrote: >>> The fact that it's named plpgsql.warnings already clearly documents that this only affects plpgsql. But whether

Re: [HACKERS] plpgsql.warn_shadow

2014-01-15 Thread Pavel Stehule
2014/1/15 Marko Tiikkaja > On 1/15/14 2:27 PM, Pavel Stehule wrote: > >> 2014/1/15 Marko Tiikkaja >> >>> Yeah, me neither, it's just something that needs to be communicated very >>> clearly. So probably just a list plpgsql.warnings would be the m

Re: [HACKERS] plpgsql.warn_shadow

2014-01-17 Thread Pavel Stehule
ns or try to help me push plpgsql_check_function to core. It can be a best holder for this and similar checks. Regards Pavel 2014/1/15 Marko Tiikkaja > On 1/15/14 3:09 PM, Pavel Stehule wrote: > >> You first should to say, what is warning and why it is only warning an

Re: [HACKERS] patch: option --if-exists for pg_dump

2014-01-17 Thread Pavel Stehule
Hello 2014/1/16 Jeevan Chalke > Hi Pavel, > > I have reviewed the patch and here are my concerns and notes: > > POSITIVES: > --- > 1. Patch applies with some white-space errors. > 2. make / make install / make check is smooth. No issues as such. > 3. Feature looks go

Re: [HACKERS] proposal, patch: allow multiple plpgsql plugins

2014-01-17 Thread Pavel Stehule
2014/1/16 Marko Tiikkaja > Hi Pavel, > > First of all, thanks for working on this! > > > On 1/12/14, 8:58 PM, Pavel Stehule wrote: > >> I still not happy with plugin_info - it is only per plugin now and should >> be per plugin and per function. >> >

Re: [HACKERS] array_length(anyarray)

2014-01-18 Thread Pavel Stehule
rom patch.) patching file src/test/regress/sql/arrays.sql not sure about source of this problem. Function works correctly and I would this feature Regards Pavel 2014/1/18 Marko Tiikkaja > On 1/12/14, 5:53 AM, I wrote: > >> On 1/9/14, 2:57 PM, Dean Rasheed wrote: >> >>

Re: [HACKERS] array_length(anyarray)

2014-01-18 Thread Pavel Stehule
2014/1/19 Marko Tiikkaja > On 1/19/14, 12:21 AM, Pavel Stehule wrote: > >> I checked it and I got a small issue >> >> bash-4.1$ patch -p1 < cardinality.patch >> (Stripping trailing CRs from patch.) >> >> not sure about source of this problem. >

Re: [HACKERS] using rpmbuild with PostgreSQL 9.2.6 source code

2014-01-19 Thread Pavel Stehule
Hello you need installed devel packages Regards Pavel Stehule 2014/1/20 Sameer Kumar > Hi, > > I have downloaded the tar source code of PostgreSQL and also the SPEC > file. I am trying to use rpmbuild command but I always get below error: > > error: Failed build dependenci

Re: [HACKERS] Closing commitfest 2013-11

2014-01-21 Thread Pavel Stehule
Hello I disagree with it. There was no any request to move "ready for commit" patches to next commitfest! I expected so only unfinishing patches should by moved there by their authors. I sent question to Peter E. But without reply, but Tom did commits from thist list, so I expected so there is som

Re: [HACKERS] Closing commitfest 2013-11

2014-01-21 Thread Pavel Stehule
Dne 21.1.2014 18:52 "Pavel Stehule" napsal(a): > > Hello > > I disagree with it. There was no any request to move "ready for commit" patches to next commitfest! I expected so only unfinishing patches should by moved there by their authors. I sent question to Pet

Re: [HACKERS] Custom collations, collation modifiers (eg case-insensitive)

2014-01-21 Thread Pavel Stehule
This feature is interesting for Czech language too. Lot of applications allows accent free searching due possible issues in original data or some client limits - missing Czech keyboard and similar Dne 21.1.2014 17:17 "Alvaro Herrera" napsal(a): > Craig Ringer wrote: > > > (I intensely dislike the

Re: [HACKERS] Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist

2014-01-22 Thread Pavel Stehule
much larger patch. > > In the end, I felt that Pavel's approach wasn't adding that much new > code, and it's all localised in the one place that does actually > tolerate missing objects. > I though about it too. But I didn't continue - reasons was named by Dean -

Re: [HACKERS] patch: option --if-exists for pg_dump

2014-01-22 Thread Pavel Stehule
Tomorrow I'll send updated version Regards Pavel 2014/1/21 Jeevan Chalke > Hi Pavel, > > Consider following test scenario: > > mydb=# \d emp > Table "public.emp" > Column | Type | Modifiers > +-+--- > empno

Re: [HACKERS] Why do we let autovacuum give up?

2014-01-23 Thread Pavel Stehule
erformance and stability killer. Vacuum of pg attrib has very ugly impacts :( Regars Pavel After redesign - without tmp tables - his applications works well. We needs a global temp tables > Regards > > Mark > > > > > -- > Sent via pgsql-hackers mailing list (pgsq

Re: [HACKERS] pg_upgrade: make the locale comparison more tolerating

2014-01-24 Thread Pavel Raiskup
al probably but it is not nice anyway.. Rather cleaning the patch once more, attached, Pavel >From 35b9f600b592db24bb0e25d168bc5955087d65df Mon Sep 17 00:00:00 2001 From: Pavel Raiskup Date: Sat, 21 Dec 2013 01:27:01 +0100 Subject: [PATCH] pg_upgrade: make the locale comparison more tolerati

Re: [HACKERS] patch: option --if-exists for pg_dump

2014-01-26 Thread Pavel Stehule
Hello Second update - I reduced patch by removing not necessary changes. Attached tests and Makefile Now --if-exists option is fully consistent with -c option With some free time I plan to enhance test script about more object types - now It contains almost all usual types. Regards Pavel

Re: [HACKERS] plpgsql.warn_shadow

2014-01-26 Thread Pavel Stehule
gt; consistent_into (discussed in a separate thread). > > But these objections would go away if restricted this to function > creation time only. So even with warnings_as_errors=on, you > could still *call* a function that produces a warning, but not > *create* one. > +1 behave

Re: [HACKERS] running make check with only specified tests

2014-01-26 Thread Pavel Stehule
t of > a better name. And with it I can do: > > $ make check-with TESTS="json jsonb" > +1 Pavel > > > and have it do the temp install etc and then run just those two tests. > > Thoughts? > > cheers > > andrew > > > -- > Sent via p

Re: [HACKERS] plpgsql.warn_shadow

2014-01-26 Thread Pavel Stehule
Dne 26. 1. 2014 23:24 "Simon Riggs" napsal(a): > > On 26 January 2014 15:53, Pavel Stehule wrote: > > > > > > > > 2014-01-26 Florian Pflug > > > >> On Jan26, 2014, at 10:19 , Simon Riggs wrote: > >> > Also, having > >&g

[HACKERS] missing windows client only installation

2014-01-26 Thread Pavel Stehule
PostgreSQL knowledges Regards Pavel Stehule.

Re: [HACKERS] plpgsql.warn_shadow

2014-01-26 Thread Pavel Stehule
gsql keywords b) it can be nice if validity can be verified by plpgsql plugins and used by plpgsql plugins much more. Now we can use only GUC for plugin parametrization, but it is not readable as #option it is. Regards Pavel

Re: [HACKERS] plpgsql.warn_shadow

2014-01-27 Thread Pavel Stehule
option to > set if you just want errors and no warnings. > what means plpgsql.errors = none ??? I strongly disagree so this design is clean Regards Pavel > > Regards, > Marti > > > -- > Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgsql-hackers >

Re: [HACKERS] A better way than tweaking NTUP_PER_BUCKET

2014-01-27 Thread Pavel Stehule
h work_mem. MergeJoin with quicksort was significantly faster. I didn't deeper research - there is a possibility of virtualization overhead. Regards Pavel > > Thanks, > > Stephen >

Re: [HACKERS] patch: option --if-exists for pg_dump

2014-01-29 Thread Pavel Stehule
2014-01-29 Jeevan Chalke > Hi Pavel, > > Now the patch looks good to me. However when I try to restore your own sql > file's dump, I get following errors: > > pg_restore: [archiver (db)] could not execute query: ERROR: relation > "public.emp" does not exis

Re: [HACKERS] patch: option --if-exists for pg_dump

2014-01-29 Thread Pavel Stehule
2014-01-29 Pavel Stehule > > > > 2014-01-29 Jeevan Chalke > > Hi Pavel, >> >> Now the patch looks good to me. However when I try to restore your own >> sql file's dump, I get following errors: >> >> pg_restore: [archiver (db)] could not exe

[HACKERS] pg_sleep_enhancements.patch

2014-01-29 Thread Pavel Stehule
expect a) what will be expected behave whem time is changed - CET/CEST ? b) what will be expected behave when board clock is not accurate and it is periodically fixed (by NTP) - isn't better to sleep only few seconds and recalculate sleeping interval? Regards Pavel

Re: [HACKERS] pg_sleep_enhancements.patch

2014-01-29 Thread Pavel Stehule
2014-01-29 Vik Fearing > On 01/29/2014 08:04 PM, Pavel Stehule wrote: > > Hello > > > > I am looking on this patch > > Thank you for looking at it. > > > http://www.postgresql.org/message-id/525fe206.6000...@dalibo.com > > > > a) pg_sleep_for -

Re: [HACKERS] pg_sleep_enhancements.patch

2014-01-29 Thread Pavel Stehule
2014-01-29 Vik Fearing > On 01/29/2014 08:21 PM, Pavel Stehule wrote: > > second question - is not this functionality too dangerous? If somebody > > use it as scheduler, then > > > > a) can holds connect, session data, locks too long time > > b) it can stop on

[HACKERS] review: psql command copy count tag

2014-01-29 Thread Pavel Stehule
tests are passed without errors 5. We like this feature - it shows interesting info without any slowdown - psql copy command is more consistent with server side copy statement from psql perspective. This patch is ready for commit Regards Pavel *** ./src/bin/psql/common.c.orig 2014-01-29 21:09

[HACKERS] tests for client programs

2014-01-29 Thread Pavel Stehule
/unexpected) p.s. some tests fails when other Postgres is up. It should be checked on start.and raise warning or stop testing. Regards Pavel ok 4 - pg_ctl initdb waiting for server to startLOG: could not bind IPv6 socket: Address already in use HINT: Is another postmaster already running on port

Re: [HACKERS] patch: option --if-exists for pg_dump

2014-01-30 Thread Pavel Stehule
Hello patch with updated comment regards Pavel 2014-01-30 Jeevan Chalke : > Hi Pavel, > > it should be fixed by >>> http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=b152c6cd0de1827ba58756e24e18110cf902182acommit >>> >> > Ok. Good. >

Re: [HACKERS] patch: option --if-exists for pg_dump

2014-01-30 Thread Pavel Stehule
Hello All is ok Thank you Pavel 2014-01-30 Jeevan Chalke : > Hi Pavel, > > Now patch looks good to me and I think it is in good shape to pass it on to > the committer as well. > > However, I have > - Tweaked few comments > - Removed white-space errors > - Fixed

Re: [HACKERS] patch: option --if-exists for pg_dump

2014-01-30 Thread Pavel Stehule
2014-01-30 Jeevan Chalke : > OK. > > Assigned it to committer. > > Thanks for the hard work. > Thank you for review Pavel > > > On Thu, Jan 30, 2014 at 6:16 PM, Pavel Stehule wrote: > >> Hello >> >> All is ok >> >> Thank you

[HACKERS] Review: tests for client programs

2014-01-30 Thread Pavel Stehule
ion is not blocker - someone can enhance it (when will write tests of pg_dump for example). Regards Pavel Stehule 2014-01-29 Pavel Stehule : > Hello > > I am looking on this patch. > > It is great idea, and I am sure, so we want this patch - it was requested > and proposed mor

Re: [HACKERS] Re: Patch to add support of "IF NOT EXISTS" to others "CREATE" statements

2014-01-30 Thread Pavel Stehule
However, > we already bought into that type of risk when we invented COR for > functions, and by and large there have been few complaints about it. > The ability to substitute an improved version of a function seems to be > worth the risks of substituting a broken version. > >

Re: [HACKERS] plpgsql.warn_shadow

2014-02-03 Thread Pavel Stehule
e and not useful so all syntax errors was catched by this handler. Any debugging was terribly difficult and I had to write plpgsql_lint as solution. Regards Pavel 2014-02-03 Marko Tiikkaja : > Hi everyone, > > Here's a new version of the patch. Added new tests an

Re: [HACKERS] plpgsql.warn_shadow

2014-02-03 Thread Pavel Stehule
Dne 3.2.2014 21:48 "Marko Tiikkaja" napsal(a): > > On 2014-02-03 9:17 PM, Pavel Stehule wrote: >> >> I am not happy from "warnings_as_error" >> >> what about "stop_on_warning" instead? > > > abort_compilation_on_warning? I

Re: [HACKERS] Review: tests for client programs

2014-02-08 Thread Pavel Stehule
2014-02-09 4:16 GMT+01:00 Peter Eisentraut : > I posted an updated patch in the original thread. Please see the commit > fest web site for the URL. > > > On Thu, 2014-01-30 at 19:50 +0100, Pavel Stehule wrote: > > > 6. I found only few issues: > > > > >

Re: [HACKERS] proposal, patch: allow multiple plpgsql plugins

2014-02-09 Thread Pavel Stehule
Hello updated patch - now plugin_info is per plpgsq_estate/plugin again. Regards Pavel 2014-01-17 20:26 GMT+01:00 Pavel Stehule : > > > > 2014/1/16 Marko Tiikkaja > >> Hi Pavel, >> >> First of all, thanks for working on this! >> >> >> On 1/

Re: [HACKERS] proposal, patch: allow multiple plpgsql plugins

2014-02-10 Thread Pavel Stehule
Hello Marko 2014-01-16 23:54 GMT+01:00 Marko Tiikkaja : > Hi Pavel, > > First of all, thanks for working on this! > > > On 1/12/14, 8:58 PM, Pavel Stehule wrote: > >> I still not happy with plugin_info - it is only per plugin now and should >> be per plugin and

Re: [HACKERS] patch: option --if-exists for pg_dump

2014-02-17 Thread Pavel Stehule
out going to as much trouble as > parsing the DROP command. Is there a way to do that? Maybe we can ask > the server for the object identity, for example. There is a new > function to do that in 9.3 which perhaps we can now use. > > do you think a pg_describe_object function? Probably it is possible, but its significantly much more invasive change, you should to get objidentity, that is not trivial Regards Pavel > -- > Álvaro Herrerahttp://www.2ndQuadrant.com/ > PostgreSQL Development, 24x7 Support, Training & Services >

Re: [HACKERS] patch: option --if-exists for pg_dump

2014-02-18 Thread Pavel Stehule
Hello 2014-02-17 22:14 GMT+01:00 Pavel Stehule : > Hello > > > 2014-02-17 18:10 GMT+01:00 Alvaro Herrera : > > Jeevan Chalke escribió: >> >> I don't understand this code. (Well, it's pg_dump.) Or maybe I do >> understand it, and it's not d

Re: Fwd: [HACKERS] patch: make_timestamp function

2014-02-19 Thread Pavel Stehule
2014-02-19 19:01 GMT+01:00 Alvaro Herrera : > Pavel Stehule escribió: > > > > 7) Why do the functions accept only the timezone abbreviation, not the > > >full name? I find it rather confusing, because the 'timezone' option > > >uses the full nam

Re: Fwd: [HACKERS] patch: make_timestamp function

2014-02-19 Thread Pavel Stehule
2014-02-19 19:01 GMT+01:00 Alvaro Herrera : > Pavel Stehule escribió: > > > > 7) Why do the functions accept only the timezone abbreviation, not the > > >full name? I find it rather confusing, because the 'timezone' option > > >uses the full nam

Re: Fwd: [HACKERS] patch: make_timestamp function

2014-02-19 Thread Pavel Stehule
Dne 19. 2. 2014 21:20 "Alvaro Herrera" napsal(a): > > Pavel Stehule escribió: > > > I though about it, and now I am thinking so timezone in format > > 'Europe/Prague' is together with time ambiguous > > > > We can do it, but we have to expe

Re: Fwd: [HACKERS] patch: make_timestamp function

2014-02-20 Thread Pavel Stehule
Hello updated patch without timetz support Regards Pavel 2014-02-19 21:20 GMT+01:00 Alvaro Herrera : > Pavel Stehule escribió: > > > I though about it, and now I am thinking so timezone in format > > 'Europe/Prague' is together with time ambiguous > > >

[HACKERS] Public header files change

2014-02-21 Thread Pavel Raiskup
calling these functions or using the Constraint node will require updating. These seem to be pretty internal symbols to me, but I rather asking here. Is there some project we know off that is using this functions (or is there some obvious usecase for third-parties)? Pavel -- Sent

[HACKERS] often PREPARE can generate high load (and sometimes minutes long unavailability)

2014-02-23 Thread Pavel Stehule
looks it is related to planner, ... Regards Pavel

Re: [HACKERS] often PREPARE can generate high load (and sometimes minutes long unavailability)

2014-02-23 Thread Pavel Stehule
2014-02-23 20:35 GMT+01:00 Jeff Janes : > On Sun, Feb 23, 2014 at 11:04 AM, Pavel Stehule > wrote: > >> Hello >> >> I got a example of code, that generate relatively high load with minimal >> connections. >> >> This code is +/- bad - it repeatedly

Re: [HACKERS] often PREPARE can generate high load (and sometimes minutes long unavailability)

2014-02-23 Thread Pavel Stehule
2014-02-23 20:35 GMT+01:00 Jeff Janes : > On Sun, Feb 23, 2014 at 11:04 AM, Pavel Stehule > wrote: > >> Hello >> >> I got a example of code, that generate relatively high load with minimal >> connections. >> >> This code is +/- bad - it repeatedly

Re: [HACKERS] often PREPARE can generate high load (and sometimes minutes long unavailability)

2014-02-24 Thread Pavel Stehule
2014-02-23 21:32 GMT+01:00 Andres Freund : > Hi, > > On 2014-02-23 20:04:39 +0100, Pavel Stehule wrote: > > There is relative few very long ProcArrayLocks lwlocks > > > > This issue is very pathologic on fast computers with more than 8 CPU. > This > > issue w

Re: [HACKERS] often PREPARE can generate high load (and sometimes minutes long unavailability)

2014-02-24 Thread Pavel Stehule
2014-02-24 16:09 GMT+01:00 Andres Freund : > On 2014-02-23 20:04:39 +0100, Pavel Stehule wrote: > >354246.00 93.0% s_lock > > /usr/lib/postgresql/9.2/bin/postgres > > 10503.00 2.8% LWLockRelease > > /usr/lib/postgresql/9.2/bin/postgres &g

Re: [HACKERS] often PREPARE can generate high load (and sometimes minutes long unavailability)

2014-02-25 Thread Pavel Stehule
Hello 2014-02-24 21:31 GMT+01:00 Jeff Janes : > On Mon, Feb 24, 2014 at 7:02 AM, Pavel Stehule wrote: > >> >> >> >> 2014-02-23 21:32 GMT+01:00 Andres Freund : >> >> Hi, >>> >>> On 2014-02-23 20:04:39 +0100, Pavel Stehule wrote:

Re: [HACKERS] often PREPARE can generate high load (and sometimes minutes long unavailability)

2014-02-25 Thread Pavel Stehule
2014-02-25 11:29 GMT+01:00 Pavel Stehule : > Hello > > > 2014-02-24 21:31 GMT+01:00 Jeff Janes : > > On Mon, Feb 24, 2014 at 7:02 AM, Pavel Stehule wrote: >> >>> >>> >>> >>> 2014-02-23 21:32 GMT+01:00 Andres Freund : >>>

<    5   6   7   8   9   10   11   12   13   14   >