[PATCHES] Spelling fix

2003-07-27 Thread Rod Taylor
contraints -> constraints Index: release.sgml === RCS file: /home/rbt/work/postgresql/cvs/pgsql-server/doc/src/sgml/release.sgml,v retrieving revision 1.202 diff -c -r1.202 release.sgml *** release.sgml 25 Jul 2003 09:00:17 - 1.202

Re: [PATCHES] ruleutils with pretty-print option

2003-07-27 Thread Tom Lane
Andreas Pflug <[EMAIL PROTECTED]> writes: > + int prettyFlags = !PG_ARGISNULL(1) && PG_GETARG_BOOL(1) ? > PRETTYFLAG_PAREN|PRETTYFLAG_INDENT : 0; Since the pg_proc entries are all marked strict, it's unnecessary for you to write any ARGISNULL checks. regar

Re: [PATCHES] ruleutils with pretty-print option

2003-07-27 Thread Andreas Pflug
Bruce Momjian wrote: Tom Lane wrote: Bruce Momjian <[EMAIL PROTECTED]> writes: Tom, how do I pass PG_FUNCTION_ARGS to another function, while adding a new parameter? I wouldn't. Do the PG_GETARGS in the wrapper, and have the called function take a normal C parameter list. So I

Re: [PATCHES] ruleutils with pretty-print option

2003-07-27 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Tom, how do I pass PG_FUNCTION_ARGS to another function, while adding a > > new parameter? > > I wouldn't. Do the PG_GETARGS in the wrapper, and have the called > function take a normal C parameter list. So I need to wrappers for ea

Re: [PATCHES] ruleutils with pretty-print option

2003-07-27 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Tom, how do I pass PG_FUNCTION_ARGS to another function, while adding a > new parameter? I wouldn't. Do the PG_GETARGS in the wrapper, and have the called function take a normal C parameter list. regards, tom lane -

Re: [PATCHES] Eliminate information_schema from oid2name listing

2003-07-27 Thread Bruce Momjian
OK, change made and applied. --- Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Tom Lane wrote: > >> I think v,s,t are all relkinds to exclude here. > > > Is 't' for toast tables? If so, we should allow 't

Re: [PATCHES] Eliminate information_schema from oid2name listing

2003-07-27 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> I think v,s,t are all relkinds to exclude here. > Is 't' for toast tables? If so, we should allow 't', no? I wasn't sure > about 's'? Wups, you are right --- I was thinking 't' meant 'composite type'. The only 's' in the system is

Re: [PATCHES] ruleutils with pretty-print option

2003-07-27 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Are these illustrating a problem with the function definition, or is it > > happening because it is the first time we are calling the same function > > with one and more than one parameter? > > The function definition is broken. Whil

Re: [PATCHES] ruleutils with pretty-print option

2003-07-27 Thread Bruce Momjian
OK, I am working on that now. I suspected that was the solution. I met the patch author at LinuxTag and he mentioned he wasn't familiar with the backend code yet, so I am glad to do the work to get this done correctly. ---

Re: [HACKERS] [PATCHES] PATCH: Memory leaks on start-up

2003-07-27 Thread Bruce Momjian
miscinit.c part of patch applied. Thanks. The other part Tom already addressed. --- Lee Kindness wrote: Content-Description: message body text > Tom, happier with the attached patch? > > I'd have to disagree with regar

Re: [PATCHES] Eliminate information_schema from oid2name listing

2003-07-27 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > ! "where reltype not in > > ('v','c') and " > > Surely you meant relkind. Also, there is no 'c' relkind; perhaps you > meant 's'? I think v,s,t are all relkinds to exclude here. Ye

Re: [PATCHES] ruleutils with pretty-print option

2003-07-27 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Are these illustrating a problem with the function definition, or is it > happening because it is the first time we are calling the same function > with one and more than one parameter? The function definition is broken. While it could be fixed (by expl

Re: [HACKERS] [PATCHES] PATCH: Memory leaks on start-up

2003-07-27 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > This patch no longer applies cleanly. The call is now: > freeaddrinfo_all(hint.ai_family, addrs); > Would you please submit a new patch, or is it no longer required? That part of the patch is not needed (it is the same as what I changed, excep

Re: [PATCHES] Eliminate information_schema from oid2name listing

2003-07-27 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > ! "where reltype not in > ('v','c') and " Surely you meant relkind. Also, there is no 'c' relkind; perhaps you meant 's'? I think v,s,t are all relkinds to exclude here. rega