Re: [PATCHES] [GENERAL] dblink: rollback transaction

2004-02-23 Thread Joe Conway
Tom Lane wrote: Joe Conway <[EMAIL PROTECTED]> writes: I like the idea in general, but maybe instead there should be a new overloaded version of the existing function names that accepts an additional bool argument. Without the argument, behavior would be as it is now; with it, you could specif

Re: [PATCHES] [GENERAL] dblink: rollback transaction

2004-02-23 Thread Tom Lane
Joe Conway <[EMAIL PROTECTED]> writes: > I like the idea in general, but maybe instead there should be a new > overloaded version of the existing function names that accepts an > additional bool argument. Without the argument, behavior would be as it > is now; with it, you could specify the old

Re: [PATCHES] [GENERAL] dblink: rollback transaction

2004-02-23 Thread Joe Conway
Tom Lane wrote: Joe Conway <[EMAIL PROTECTED]> writes: One question that I'd like some feedback on is the following: should the same change be applied to other functions that might throw an ERROR based on the remote side of the connection? For example, currently if dblink() is used in an attemp

Re: [PATCHES] dblink - custom datatypes NOW work :)

2004-02-23 Thread Joe Conway
Tom Lane wrote: Two nitpicks (each applying in 2 places): First, testing for null rsinfo isn't sufficient, since the resultinfo mechanism could be used for other things; you need an IsA test too. Second, is "syntax error" really the most appropriate classification for this? (Also, the errmsg text

Re: [PATCHES] client_encoding in dump file

2004-02-23 Thread Tom Lane
Pavel Stehule <[EMAIL PROTECTED]> writes: > I send my first patch for PostgreSQL - maybe ugly patch. This patch > generate on top of dump file line with setting of current encoding. Its > useful for languages like czech with more than one wide used encoding. > We need informations about used enco

[PATCHES] log_line_info

2004-02-23 Thread Andrew Dunstan
Attached is a patch for tagging log lines produced by backends. It is not quite ready for application - this is for people to look over and play with. For my testing I used the following settings: log_connections = true log_disconnections = true log_line_info = '%T [%P] [EMAIL PROTECTED](%C:%S)