Re: [PATCHES] [HACKERS] notice about costly ri checks (3)

2004-03-11 Thread Fabien COELHO
> > Subject: Re: [HACKERS] notice about costly ri checks (3) > > I hope you put version (4), not version (3)! Otherwise the new > wording is not the "new new one" discussed later... I just checked. You put version 3 in line (NOTICE, no precision about offending attributes), although a later discu

[PATCHES] client side syntax error localisation for psql (v1)

2004-03-11 Thread Fabien COELHO
Dear patchers, Please find attached my first attempt at providing a localisation information on the client side for syntax errors in "psql". Basically, one function is added which takes care of the burden. I put a lot of comments in the function to try make it clear what is going on. It validate

[PATCHES] defer statement logging until after parse

2004-03-11 Thread Andrew Dunstan
The attached patch is for review, not application. It defers logging statements until after they have been parsed. There should be no observable difference in behaviour if there is a successful parse, and on error the following traces appear: line:3 ERROR: syntax error at or near "se3d2" at c

[PATCHES] client side syntax error position (v2)

2004-03-11 Thread Fabien COELHO
Dear patchers, Please find enclosed a new patch submission which take into account comments by Tom Lane about version 1. (1) the function is renamed as "localisation" does not mean what I meant. (2) three dots "..." appear after and before the line when truncated. However, I still put the line

Re: [PATCHES] change output of \dp

2004-03-11 Thread Euler Taveira de Oliveira
Hi, I just forgot the documentation patch. It's attached. Regards, -- Euler Taveira de Oliveira euler (at) ufgnet.ufg.br Desenvolvedor Web e Administrador de Sistemas UFGNet - Universidade Federal de Goiás dp_doc.patch Description: Binary data ---(end of broadcast)--

Re: [PATCHES] client side syntax error position (v2)

2004-03-11 Thread Tom Lane
Fabien COELHO <[EMAIL PROTECTED]> writes: > Same comment as with version one, I don't know how to test the multi-byte > part. It should be fairly easy to test if you use UNICODE client encoding; anything outside the 7-bit-ASCII set will be 2 or more bytes. regards, tom lan

Re: [PATCHES] change output of \dp

2004-03-11 Thread Peter Eisentraut
Euler Taveira de Oliveira wrote: > I just noticed that \dp outputs "Table" to indicate relations > (tables, sequences and views) instead of "Relation" or "Name". This > patch just correct it, using "Name" and attaching its "Type". Maybe we should think of a more general solution. For example, th

Re: [PATCHES] change output of \dp

2004-03-11 Thread Euler Taveira de Oliveira
Hi, > > I just noticed that \dp outputs "Table" to indicate relations > > (tables, sequences and views) instead of "Relation" or "Name". This > > patch just correct it, using "Name" and attaching its "Type". > > Maybe we should think of a more general solution. For example, there is > still no

Re: [PATCHES] costly foreign key ri checks (4)

2004-03-11 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches I will try to apply it within the next 48 hours. --- Fabien COELHO wrote: > > Dear patchers,

Re: [PATCHES] [HACKERS] notice about costly ri checks (3)

2004-03-11 Thread Bruce Momjian
Thanks. Done. --- Fabien COELHO wrote: > > > > Subject: Re: [HACKERS] notice about costly ri checks (3) > > > > I hope you put version (4), not version (3)! Otherwise the new > > wording is not the "new new one" discussed

[PATCHES] libpq Makefile fix

2004-03-11 Thread Claudio Natoli
Fixes recent introduction of noblock.c; Makefile uses nonblock.c. For immediate application. --- Certain disclaimers and policies apply to all email sent from Memetrics. For the full text of these disclaimers and policies see http://www.memetrics.com/emailpolicy.html";>http://www.memetrics.com/

Re: [PATCHES] defer statement logging until after parse

2004-03-11 Thread Bruce Momjian
The problem I see with this patch is that it doesn't print the error query on a syntax error. That seems wrong. I think you should print the query before parsing if they are asking for all queries to be logged, and print them after parsing if they want only DDL or DDL and data modification queri

Re: [PATCHES] libpq Makefile fix

2004-03-11 Thread Bruce Momjian
Patch applied. Thanks. --- Claudio Natoli wrote: > > Fixes recent introduction of noblock.c; Makefile uses nonblock.c. For > immediate application. > > --- > Certain disclaimers and policies apply to all email sent from

[PATCHES] int8 fix for win32

2004-03-11 Thread Claudio Natoli
Fixes recent changes to test. For immediate application. [Note: int8-exp-three-digits.out needs the same treatment] Will review recent changes for float4/8 and implications for win32 when I get a chance. --- Certain disclaimers and policies apply to all email sent from Memetrics. For the f