Re: [PATCHES] defer statement logging until after parse

2004-03-12 Thread Andrew Dunstan
Bruce Momjian wrote: Well, if that is the question, then I don't want to reorder the query printout from the error. OK. I'll let someone else do it. I have no need for it. Forget I spoke. cheers andrew ---(end of broadcast)--- TIP 8: explain an

Re: [PATCHES] defer statement logging until after parse

2004-03-12 Thread Bruce Momjian
Tom Lane wrote: > Andrew Dunstan <[EMAIL PROTECTED]> writes: > > Tom Lane wrote: > >> Has any of this discussion taken into account the fact that a > >> querystring may contain multiple commands? > > > What does the parser do if one of the statements has an error and the > > others are OK? > > T

Re: [PATCHES] defer statement logging until after parse

2004-03-12 Thread Bruce Momjian
Andrew Dunstan wrote: > >> It does print it. In fact the example I gave below which is from a > >> real trace shows it being printed. It is just printed after the error > >> message rather than before. > >> > >> You solution doesn't appear to address the problem of what to do if > >> they ask fo

Re: [PATCHES] Update tests & memory leak fix

2004-03-12 Thread Bruce Momjian
I will put it in the queue today. --- Lee Kindness wrote: > Bruce, do you have an update on when this patch (and the subsequent > one) will be applied or rejected? > > Thanks, Lee. > > Bruce Momjian writes Mon, 8 Mar 2004:

Re: [PATCHES] Update tests & memory leak fix

2004-03-12 Thread Lee Kindness
Bruce, do you have an update on when this patch (and the subsequent one) will be applied or rejected? Thanks, Lee. Bruce Momjian writes Mon, 8 Mar 2004: > > Got the diff -c now, thanks. > > --- > > Lee Kindness wrote

Re: [PATCHES] [pgsql-hackers-win32] initdb problen

2004-03-12 Thread Andrew Dunstan
I believe that the attached patch may solve this setlocale() problem, but I do not have a Windows box handy on which to test it. Can somebody who does please try and let us know the results? thanks andrew Andrew Dunstan wrote: the answer is very probably here: http://archives.postgres

Re: [PATCHES] defer statement logging until after parse

2004-03-12 Thread Andrew Dunstan
Tom Lane wrote: The current definition of log_statement has no problem because we print the whole string, once, before parsing starts. If you put a printout into the per-parse-tree loop then I think you are going to get multiple printouts of the same string. I didn't intend to - I intended to

Re: [PATCHES] defer statement logging until after parse

2004-03-12 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> Has any of this discussion taken into account the fact that a >> querystring may contain multiple commands? > What does the parser do if one of the statements has an error and the > others are OK? The whole thing is rejected. This

Re: [PATCHES] defer statement logging until after parse

2004-03-12 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > My idea was to take log_statement, and instead of true/false, have it be > all, ddl, mod, or off/none/false(?). You keep the existing test for > log_statement where it is, but test for 'all' now, and after parse, you > check for ddl or mod, and print in

Re: [PATCHES] defer statement logging until after parse

2004-03-12 Thread Andrew Dunstan
Bruce Momjian said: > Andrew Dunstan wrote: >> >> >> Bruce Momjian wrote: >> >> >The problem I see with this patch is that it doesn't print the error >> >query on a syntax error. That seems wrong. >> > >> >> It does print it. In fact the example I gave below which is from a >> real trace shows it

Re: [PATCHES] [HACKERS] notice about costly ri checks (3)

2004-03-12 Thread Fabien COELHO
Dear Bruce, > It is in the queue because I need that narrative for the commit > messase. Ok, I get the point. I should have made a fully standalone version with all comments repeated. Thanks, have a nice day, -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)

Re: [PATCHES] defer statement logging until after parse

2004-03-12 Thread Bruce Momjian
Andrew Dunstan wrote: > > > Bruce Momjian wrote: > > >The problem I see with this patch is that it doesn't print the error > >query on a syntax error. That seems wrong. > > > > It does print it. In fact the example I gave below which is from a real > trace shows it being printed. It is just p

Re: [PATCHES] [HACKERS] notice about costly ri checks (3)

2004-03-12 Thread Bruce Momjian
Fabien COELHO wrote: > > Dear Bruce, > > > It is in the queue because I need that narrative for the commit > > messase. > > Ok, I get the point. > > I should have made a fully standalone version with all comments repeated. > > Thanks, have a nice day, No problem. I am used to keeping multiple

Re: [PATCHES] [HACKERS] notice about costly ri checks (3)

2004-03-12 Thread Bruce Momjian
Fabien COELHO wrote: > > Dear Bruce, > > # [PATCHES] notice about costly ri checks (2), Fabien COELHO > > This one which appears on the web page can also be removed, > It is also replaced by version 4. > > Sorry again for the inconvenience, have a nice day, It is in the queue because I need th

Re: [PATCHES] int8 fix for win32

2004-03-12 Thread Bruce Momjian
Patch applied. Thanks. --- Claudio Natoli wrote: > > Fixes recent changes to test. For immediate application. > > [Note: int8-exp-three-digits.out needs the same treatment] > > Will review recent changes for float4/8 an

Re: [PATCHES] [HACKERS] notice about costly ri checks (3)

2004-03-12 Thread Fabien COELHO
Dear Bruce, # [PATCHES] notice about costly ri checks (2), Fabien COELHO This one which appears on the web page can also be removed, It is also replaced by version 4. Sorry again for the inconvenience, have a nice day, -- Fabien Coelho - [EMAIL PROTECTED] ---(end of b

Re: [PATCHES] defer statement logging until after parse

2004-03-12 Thread Andrew Dunstan
Bruce Momjian wrote: The problem I see with this patch is that it doesn't print the error query on a syntax error. That seems wrong. It does print it. In fact the example I gave below which is from a real trace shows it being printed. It is just printed after the error message rather than bef

[PATCHES] client side syntax error position (v3)

2004-03-12 Thread Fabien COELHO
Dear patchers, New submission... after suggestions by Tom and others, the current result looks like the following: psql> CREATE foo; ERROR: syntax error at or near "foo" at character 8 LINE 1: CREATE foo; ^ psql> There may still be issues about some mb encodings, especially with