Re: [PATCHES] [HACKERS] UnixWare/CVS Tip/initdb.c needs to use

2004-03-19 Thread Larry Rosenman
On Fri, 19 Mar 2004, Bruce Momjian wrote: > Larry Rosenman wrote: > > > Yes, his patch ended up adding this to THREAD_LIBS, but > > > template/unixware has: > > > > > > For gcc: > > > > > > THREAD_CPPFLAGS="-pthread" > > > > > > and for non-gcc: > > > > > > THREAD_CPPFLAGS="-K pthread" > > > >

Re: [PATCHES] [HACKERS] UnixWare/CVS Tip/initdb.c needs to use

2004-03-19 Thread Larry Rosenman
On Fri, 19 Mar 2004, Bruce Momjian wrote: > Tom Lane wrote: > > Bruce Momjian <[EMAIL PROTECTED]> writes: > > > Tom Lane wrote: > > >> It seems that what we have to do for Unixware is add > > >> -Kpthread to LDFLAGS; is that correct? > > > > > Unusually, this platform doesn't have a THREAD_LIBS se

Re: [PATCHES] [HACKERS] UnixWare/CVS Tip/initdb.c needs to use

2004-03-19 Thread Bruce Momjian
Larry Rosenman wrote: > > Yes, his patch ended up adding this to THREAD_LIBS, but > > template/unixware has: > > > > For gcc: > > > > THREAD_CPPFLAGS="-pthread" > > > > and for non-gcc: > > > > THREAD_CPPFLAGS="-K pthread" > > > > Larry, are these wrong? > Nope, those work, and should be pass

Re: [PATCHES] [HACKERS] UnixWare/CVS Tip/initdb.c needs to use

2004-03-19 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Tom Lane wrote: > >> It seems that what we have to do for Unixware is add > >> -Kpthread to LDFLAGS; is that correct? > > > Unusually, this platform doesn't have a THREAD_LIBS setting, only > > THREAD_CPPFLAGS. so I have to use that.

Re: [PATCHES] [HACKERS] UnixWare/CVS Tip/initdb.c needs to use

2004-03-19 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> It seems that what we have to do for Unixware is add >> -Kpthread to LDFLAGS; is that correct? > Unusually, this platform doesn't have a THREAD_LIBS setting, only > THREAD_CPPFLAGS. so I have to use that. If Larry quoted the Compiler

Re: [PATCHES] [HACKERS] UnixWare/CVS Tip/initdb.c needs to use

2004-03-19 Thread Bruce Momjian
Bruce Momjian wrote: > Tom Lane wrote: > > Larry Rosenman <[EMAIL PROTECTED]> writes: > > > In other words, the entire application either is or is not linked with > > > threads; it's not a property of an individual library. > > > > > SO, IF we are using the threads flags, we need to use them on AL

Re: [PATCHES] [HACKERS] UnixWare/CVS Tip/initdb.c needs to use

2004-03-19 Thread Bruce Momjian
Tom Lane wrote: > Larry Rosenman <[EMAIL PROTECTED]> writes: > > In other words, the entire application either is or is not linked with > > threads; it's not a property of an individual library. > > > SO, IF we are using the threads flags, we need to use them on ALL=20 > > libpq-using programs, ou

Re: [PATCHES] [HACKERS] UnixWare/CVS Tip/initdb.c needs to use

2004-03-19 Thread Tom Lane
Larry Rosenman <[EMAIL PROTECTED]> writes: > In other words, the entire application either is or is not linked with > threads; it's not a property of an individual library. > SO, IF we are using the threads flags, we need to use them on ALL=20 > libpq-using programs, ours or the users. Yeek. Thi

Re: [PATCHES] FAQ updates

2004-03-19 Thread Bruce Momjian
Robert Treat wrote: > I think I can work that up. Out of curiosity are the plain text files > generated from the html files? Also I noticed that not all plain text > FAQ's have html FAQ's associated with them... is that by design or just > the fact that no one has bothered to bring them up to spe

Re: [PATCHES] FAQ updates

2004-03-19 Thread Robert Treat
I think I can work that up. Out of curiosity are the plain text files generated from the html files? Also I noticed that not all plain text FAQ's have html FAQ's associated with them... is that by design or just the fact that no one has bothered to bring them up to speed? Robert Treat On Fri,

Re: [PATCHES] [HACKERS] UnixWare/CVS Tip/initdb.c needs to use threads

2004-03-19 Thread Bruce Momjian
Larry Rosenman wrote: > > I'll ask the compiler guys, but I suspect we're going to have to do it > > this way. > > > From the Compiler Guys: > > The a.out (not any library) should be linked with -Kpthread (not > -lpthread). > This will force libthread to be linked in the right order relative to

Re: [PATCHES] [HACKERS] UnixWare/CVS Tip/initdb.c needs to use

2004-03-19 Thread Larry Rosenman
--On Friday, March 19, 2004 09:18:03 -0600 Larry Rosenman <[EMAIL PROTECTED]> wrote: --On Friday, March 19, 2004 10:15:56 -0500 Bruce Momjian <[EMAIL PROTECTED]> wrote: [moved to -patches because of the patch] --On Friday, March 19, 2004 08:01:53 -0500 Bruce Momjian <[EMAIL PROTECTED]> wrote

Re: [PATCHES] [HACKERS] UnixWare/CVS Tip/initdb.c needs to use threads

2004-03-19 Thread Bruce Momjian
> [moved to -patches because of the patch] > > > --On Friday, March 19, 2004 08:01:53 -0500 Bruce Momjian > <[EMAIL PROTECTED]> wrote: > > > Larry Rosenman wrote: > >> > I thought that once you include libpthread in libpq, that you don't > >> > have to mention it again then you use libpq. Is y

Re: [PATCHES] syntax error position "CREATE FUNCTION" bug fix

2004-03-19 Thread Fabien COELHO
Dear Tom, > Attached is a proposed patch that fixes the > cursor-position-in-CREATE-FUNCTION issue per my earlier suggestion. > > The re-parsing of the original command is simplistic but will handle all > normal cases. > [...] That's quite a demonstration;-) However, I still stick with my "bad"

Re: [PATCHES] [HACKERS] UnixWare/CVS Tip/initdb.c needs to use threads

2004-03-19 Thread Larry Rosenman
[moved to -patches because of the patch] --On Friday, March 19, 2004 08:01:53 -0500 Bruce Momjian <[EMAIL PROTECTED]> wrote: Larry Rosenman wrote: > I thought that once you include libpthread in libpq, that you don't > have to mention it again then you use libpq. Is your platform > different so