Re: [PATCHES] win32 fixes

2004-04-13 Thread Claudio Natoli
> * rationalized pipe read EINTR for win32 Should read: * rationalized pipe read EOF for win32 Corrected patch attached. --- Certain disclaimers and policies apply to all email sent from Memetrics. For the full text of these disclaimers and policies see http://www.memetrics.com/emailpolicy.ht

Re: [PATCHES] aclitem accessor functions

2004-04-13 Thread Fabien COELHO
Dear Peter, > > I needed these functions to browse aclitems from user land. I can > > load them when necessary, but it seems to me that these accessors for > > a backend type belong to the backend, so I submit them. > > Can you explain what you want to do from the user level? Sure. Before devel

Re: [PATCHES] Updated COPY CSV patch

2004-04-13 Thread Andrew Dunstan
Bruce Momjian said: > > OK, here is a new version of the patch that includes the grammar changes we agreed upon, SGML changes, and \copy support. I will not make any more changes without contacting you so feel free to make adjustments and repost. Excellent. Quick work :-) I will test later today

Re: [PATCHES] Updated COPY CSV patch

2004-04-13 Thread Andrew Dunstan
Bruce Momjian said: > Second, I found a problem with NULLs. If I do: > . >test=> create table test (x text, y text); >CREATE TABLE >test=> insert into test values ('', NULL); >INSERT 17221 1 >test=> > > then this: > >test=> copy test to '/tmp/b' with

Re: [PATCHES] Updated COPY CSV patch

2004-04-13 Thread Bruno Wolff III
On Tue, Apr 13, 2004 at 06:58:24 -0400, Andrew Dunstan <[EMAIL PROTECTED]> wrote: > > One area that we should think about as an enhancement is NOT NULL fields. > As it stands now, we will get what we normally get when we try to insert > a null into a NOT NULL field, namely an error. If the fiel

Re: [PATCHES] Updated COPY CSV patch

2004-04-13 Thread Andrew Dunstan
Andrew Dunstan wrote: Bruce Momjian said: Second, I found a problem with NULLs. If I do: . test=> create table test (x text, y text); CREATE TABLE test=> insert into test values ('', NULL); INSERT 17221 1 test=> then this: test=> copy test to '/tmp/b' with

Re: [PATCHES] Updated COPY CSV patch

2004-04-13 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > Thinking about this some more maybe the right rule would be "quote > all non-numeric non-null values". And how would you define "numeric"? I do *not* like putting data-type-specific knowledge into COPY. regards, tom lane

Re: [PATCHES] Updated COPY CSV patch

2004-04-13 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan <[EMAIL PROTECTED]> writes: Thinking about this some more maybe the right rule would be "quote all non-numeric non-null values". And how would you define "numeric"? At least the following: int8 int2 int4 float4 float8 numeric money and domains based

Re: [PATCHES] Updated COPY CSV patch

2004-04-13 Thread Andrew Dunstan
Bruno Wolff III wrote: On Tue, Apr 13, 2004 at 06:58:24 -0400, Andrew Dunstan <[EMAIL PROTECTED]> wrote: One area that we should think about as an enhancement is NOT NULL fields. As it stands now, we will get what we normally get when we try to insert a null into a NOT NULL field, namely an e

Re: [PATCHES] Updated COPY CSV patch

2004-04-13 Thread Bruce Momjian
Andrew Dunstan wrote: > > > > I have two open issues. First, CSV should support WITH OIDS, no? > > > > Why on earth would you want to? OIDs only have emaning to postgresql. > Dumping to/from CSVs should not be seen as an alternative to Postgresql's > normal text or binary file formats. Rather, it

Re: [PATCHES] Updated COPY CSV patch

2004-04-13 Thread Andrew Dunstan
Bruce Momjian wrote: While doing OIDs seems atypical, it seems like a reasonable thing that CSV should be able to do. Basically, I see no reason to disable it. OK. We have bigger fish to fry ;-) cheers andrew ---(end of broadcast)--- TIP 9: th

Re: [PATCHES] Updated COPY CSV patch

2004-04-13 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > Well, as I indicated we can deal with this in a subsequent round, I > think. However, here's an idea. We know (or can easily discover) if > there is a NOT NULL constraint that can apply to the attribute (or > domain if it is a domain type). If isnull

Re: [PATCHES] Updated COPY CSV patch

2004-04-13 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> And how would you define "numeric"? > At least the following: > int8 > int2 > int4 > float4 > float8 > numeric > money > and domains based on them. Wrong answer, as this excludes user-defined types. COPY should not discrimi

Re: [PATCHES] Updated COPY CSV patch

2004-04-13 Thread Bruce Momjian
Andrew Dunstan wrote: > Bruce Momjian wrote: > > >While doing OIDs seems atypical, it seems like a reasonable thing that > >CSV should be able to do. Basically, I see no reason to disable it. > > > > > > > > OK. We have bigger fish to fry ;-) Uh, sorry, what I meant was that we should have it

Re: [PATCHES] Updated COPY CSV patch

2004-04-13 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan <[EMAIL PROTECTED]> writes: Tom Lane wrote: And how would you define "numeric"? At least the following: int8 int2 int4 float4 float8 numeric money and domains based on them. Wrong answer, as this excludes user-defined types. CO

Re: [PATCHES] Updated COPY CSV patch

2004-04-13 Thread Bruce Momjian
Andrew Dunstan wrote: > >As for setting default values, I think that is a good idea. I suggested > >a while back. There could be another keyword, DEFAULT, on the COPY FROM > >command that is used to define a code that will be replaced by the > >default value (or NULL if there is no default for a co

Re: [PATCHES] Updated COPY CSV patch

2004-04-13 Thread Andrew Dunstan
Bruce Momjian wrote: Andrew Dunstan wrote: Bruce Momjian wrote: While doing OIDs seems atypical, it seems like a reasonable thing that CSV should be able to do. Basically, I see no reason to disable it. OK. We have bigger fish to fry ;-) Uh, sorry, what I meant was that we

Re: [PATCHES] Updated COPY CSV patch

2004-04-13 Thread Bruce Momjian
Andrew Dunstan wrote: > Yes. What *I* meant was that allowing it was OK with me, and not worth > arguing over. OK, thanks. > Incidentally, the patch looks OK at first glance, and seems to work > fine, modulo today's little controversies, with this exception: > > if (csv_mode) > { >

Re: [PATCHES] Updated COPY CSV patch

2004-04-13 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Andrew Dunstan wrote: >> For all those reasons I disallowed use of WITH OIDS for CSV mode. > While doing OIDs seems atypical, it seems like a reasonable thing that > CSV should be able to do. Basically, I see no reason to disable it. I agree. It's an

Re: [PATCHES] Updated COPY CSV patch

2004-04-13 Thread Andrew Dunstan
Bruce Momjian wrote: I see that the default NULL for CSV mode is ''. I was hoping the default was something more special. Right now, by default, comma-comma is a null and comma-double-quote-double-quote-comma is a zero-length string. I am thinking there should be a way to set NULL to be either

Re: [PATCHES] Update french translation of the 7.4 branch

2004-04-13 Thread LELARGE Guillaume
LELARGE Guillaume wrote: Here are some updates of the french .po files. ## pg_dump-fr.po 391 messages traduits. ## pg_resetxlog-fr.po 57 messages traduits. ## pgscripts-fr.po 112 messages traduits. ## psql-fr.po 455 messages traduits. pg_resetxlog, pg_dump and pgscripts .po files are new ones. Th

[PATCHES] Basic subtransaction facility

2004-04-13 Thread Alvaro Herrera
Hackers, Here is a very preliminar patch that allows the user to say "BEGIN" inside a transaction and have the system react accordingly. This is only a modification to xact.c (and slightly to other places to allow it to work); the important functions are empty. It compiles fine for me with both

Re: [PATCHES] Updated COPY CSV patch

2004-04-13 Thread Bruce Momjian
Andrew Dunstan wrote: > I don't believe '' should be special, any more than 'fred' should be. As > it stands now, NULL 'fred' does say that ,, and '"", are empty strings. > > >Again, I can assist in making these modifications to the patch. > > > > > > I appreciate your efforts. But as indicate