[PATCHES] Turning off cluster patch

2004-04-28 Thread Christopher Kings-Lynne
Hi, The attached patch adds a new command: ALTER TABLE [ONLY] foo SET WITHOUT CLUSTER; I would probably have preferred the DROP CLUSTER syntax, but it doesn't seem easy to get working without shift/reduce problems. It has support for inheritance. I have also fixed the previously detailed security

Re: [PATCHES] FW: Timezone library

2004-04-28 Thread Peter Eisentraut
Am Tuesday 27 April 2004 05:06 schrieb Bruce Momjian: > I assume we want to integrate our own timezone library into PostgreSQL. > We have talked about it for a few releases, and Magnus has done it for > us because Win32 needs it for pre-1970 dates. > > The patch to PostgreSQL is 100 lines of diff,

Re: [PATCHES] Basic subtransaction facility

2004-04-28 Thread Alvaro Herrera
On Mon, Apr 26, 2004 at 11:30:16PM -0400, Bruce Momjian wrote: > Alvaro, where are we on this patch. I think the suggestion was to > throw FATAL rather than add a new error level. The assumption was that we would only want an additional level for catching can't-happen conditions. ISTM this is

Re: [PATCHES] Dollar quoting docs, round 1

2004-04-28 Thread David Fetter
On Wed, Apr 28, 2004 at 08:28:58AM +0200, Peter Eisentraut wrote: > David Fetter wrote: > > Kind people, > > > > Please find attached a diff to the SGML docs that attempts to go > > over the new dollar quoting feature. > > I think we should just use $$ in each case. Otherwise it might look > more

Re: [PATCHES] Dollar quoting docs, round 1

2004-04-28 Thread Bruce Momjian
Peter Eisentraut wrote: > David Fetter wrote: > > Kind people, > > > > Please find attached a diff to the SGML docs that attempts to go over > > the new dollar quoting feature. > > I think we should just use $$ in each case. Otherwise it might look > more complicated than before. Agreed. I was

Re: [PATCHES] Dollar quoting docs, round 1

2004-04-28 Thread Bruce Momjian
David Fetter wrote: > On Wed, Apr 28, 2004 at 08:28:58AM +0200, Peter Eisentraut wrote: > > David Fetter wrote: > > > Kind people, > > > > > > Please find attached a diff to the SGML docs that attempts to go > > > over the new dollar quoting feature. > > > > I think we should just use $$ in each c

Re: [PATCHES] Dollar quoting docs, round 1

2004-04-28 Thread Andrew Dunstan
Bruce Momjian wrote: David Fetter wrote: On Wed, Apr 28, 2004 at 08:28:58AM +0200, Peter Eisentraut wrote: David Fetter wrote: Kind people, Please find attached a diff to the SGML docs that attempts to go over the new dollar quoting feature. I think we should just use $$ in

Re: [PATCHES] Dollar quoting docs, round 1

2004-04-28 Thread David Fetter
On Wed, Apr 28, 2004 at 12:30:06PM -0400, Bruce Momjian wrote: > Peter Eisentraut wrote: > > David Fetter wrote: > > > Kind people, > > > > > > Please find attached a diff to the SGML docs that attempts to go over > > > the new dollar quoting feature. > > > > I think we should just use $$ in each

Re: [PATCHES] Dollar quoting docs, round 1

2004-04-28 Thread Andrew Dunstan
Bruce Momjian wrote: Peter Eisentraut wrote: David Fetter wrote: Kind people, Please find attached a diff to the SGML docs that attempts to go over the new dollar quoting feature. I think we should just use $$ in each case. Otherwise it might look more complicated than before.

Re: [PATCHES] SECURITY DEFINER not being propagated...

2004-04-28 Thread Sean Chittenden
This one's simple enough to reproduce (see SQL script below), but, there are some comments in src/backend/catalog/namespace.c that seem questionable and incorrect: The proposed patch reverts a change deliberately applied in namespace.c rev 1.15 (4/29/02). I think you need to go back and consult th

Re: [PATCHES] SECURITY DEFINER not being propagated...

2004-04-28 Thread Tom Lane
Sean Chittenden <[EMAIL PROTECTED]> writes: > Without any rationale as to why CREATE TEMP TABLEs checks the session > user in the archives, could we open this up for discussion again? Well, let me put it this way: if you want to change the behavior you're going to have to work much harder than ju

Re: [PATCHES] Basic subtransaction facility

2004-04-28 Thread Bruce Momjian
Alvaro Herrera wrote: > On Mon, Apr 26, 2004 at 11:30:16PM -0400, Bruce Momjian wrote: > > > Alvaro, where are we on this patch. I think the suggestion was to > > throw FATAL rather than add a new error level. > > The assumption was that we would only want an additional level for > catching can

Re: [PATCHES] Turning off cluster patch

2004-04-28 Thread Bruce Momjian
Patch withdrawn by author. --- Christopher Kings-Lynne wrote: > Hi, > > The attached patch adds a new command: > > ALTER TABLE [ONLY] foo SET WITHOUT CLUSTER; > > I would probably have preferred the DROP CLUSTER syntax, b

Re: [PATCHES] FW: Timezone library

2004-04-28 Thread Bruce Momjian
Peter Eisentraut wrote: > Am Tuesday 27 April 2004 05:06 schrieb Bruce Momjian: > > I assume we want to integrate our own timezone library into PostgreSQL. > > We have talked about it for a few releases, and Magnus has done it for > > us because Win32 needs it for pre-1970 dates. > > > > The patch