Re: [PATCHES] serverlog rotation/functions

2004-07-06 Thread Andreas Pflug
Updated version. Only timestamp of fresh logfile in shared mem, with sanity checks. On SIGHUP, timestamp is checked if rotation was issued, as well as changed log_filename setting from postgresql.conf. Regards, Andreas Index: src/backend/postmaster/postmaster.c ==

Re: [PATCHES] [PATCH] s_lock support for win32

2004-07-06 Thread Bruce Momjian
Manfred Spraul wrote: > Bruce Momjian wrote: > > >Because we don't support non-gcc Win32 builds of the backend, adding > >this patch doesn't make sense. If we ever start to support non-gcc > >Win32 backends we can add this. > > > > > > > Ok. I wasn't aware that the backend is gcc-only. > But wh

Re: [PATCHES] First attempt: support for '\dg' in psql

2004-07-06 Thread Andrew Dunstan
Bruce Momjian said: > > I have moved the mention of the dash higher in the TODO file. Maybe you could put the dash in a different color (red?) so it stands out more. Or maybe the whole item could go in a different color if done. cheers andrew ---(end of broadcast)--

Re: [PATCHES] [PATCH] s_lock support for win32

2004-07-06 Thread Manfred Spraul
Bruce Momjian wrote: Because we don't support non-gcc Win32 builds of the backend, adding this patch doesn't make sense. If we ever start to support non-gcc Win32 backends we can add this. Ok. I wasn't aware that the backend is gcc-only. But what about my libpq patch? Races in the library start

Re: [PATCHES] First attempt: support for "\dg" in psql

2004-07-06 Thread Bruce Momjian
I have moved the mention of the dash higher in the TODO file. --- Markus Bertheau wrote: > This is already in: > > http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/bin/psql/describe.c.diff?r1=text&tr1=1.89&r2=tex

Re: [PATCHES] serverlog rotation/functions

2004-07-06 Thread Andreas Pflug
Tom Lane wrote: Andreas Pflug <[EMAIL PROTECTED]> writes: The attached patch includes serverlog rotation with minimal shared memory usage as discussed and functions to access it. This patch is still unsafe and unworkable. Why would you make the mechanism dependent on shared memory *and* a

Re: [PATCHES] pg_tablespace_databases

2004-07-06 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Tom Lane wrote: > >> [ shrug... ] The name is not going to change again. I have never cared > >> for the practice of writing strlen("foo") as if it were a compile-time > >> constant. > > > I think with gcc strlen("foo") is a compile

Re: [PATCHES] [PATCH] s_lock support for win32

2004-07-06 Thread Bruce Momjian
Because we don't support non-gcc Win32 builds of the backend, adding this patch doesn't make sense. If we ever start to support non-gcc Win32 backends we can add this. --- Manfred Spraul wrote: > Hi, > > The win32 port doe

Re: [PATCHES] pg_tablespace_databases

2004-07-06 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> [ shrug... ] The name is not going to change again. I have never cared >> for the practice of writing strlen("foo") as if it were a compile-time >> constant. > I think with gcc strlen("foo") is a compile-time constant. Portability i

Re: [PATCHES] pg_tablespace_databases

2004-07-06 Thread Gavin Sherry
On Tue, 6 Jul 2004, Bruce Momjian wrote: > Tom Lane wrote: > > Andreas Pflug <[EMAIL PROTECTED]> writes: > > > Joe Conway wrote: > > >> 2) This allocation size was a bit ambigous and I think based on a once > > >> longer tablespace directory name: > > > > > This size calculation originated (copy/p

Re: [PATCHES] pg_tablespace_databases

2004-07-06 Thread Bruce Momjian
Tom Lane wrote: > Andreas Pflug <[EMAIL PROTECTED]> writes: > > Joe Conway wrote: > >> 2) This allocation size was a bit ambigous and I think based on a once > >> longer tablespace directory name: > > > This size calculation originated (copy/paste) from > > commands/tablespace.c, > > Yeah --- B