Re: [PATCHES] [GENERAL] pg_dump and schema namespace notes

Rory Campbell-Lange wrote: > I think this is a suggestion/comment! > > pg_dump man page: > > --schema-only > Dump only the schema (data definitions), no data > > I think this use of the word schema is confusing, meaning data > definitions, whereas elsewhere in the man page sc

Re: [PATCHES] contrib/dbmirror

On 7/1/2004 12:39 AM, Tom Lane wrote: Joe Conway <[EMAIL PROTECTED]> writes: [EMAIL PROTECTED] wrote: Attached is a 1 line bug fix for dbmirror that was submitted. It fixes a bug where some transactions could be dropped when writing mirrored SQL statements to files. I know that there were discuss

Re: [PATCHES] build infrastructure for extensions v3

Bruce Momjian wrote: > Wow, that is a big patch. > > Your patch has been added to the PostgreSQL unapplied patches list > at: > > http://momjian.postgresql.org/cgi-bin/pgpatches > > I will try to apply it within the next 48 hours. ISTM that this version still does not allow building contrib

[PATCHES] value.h has no VALUE_H

The outer #define was forgotten. Attached patch adds it; please apply. -- Alvaro Herrera () "Sallah, I said NO camels! That's FIVE camels; can't you count?" (Indiana Jones) Index: src/include/nodes/value.h === RCS file: /home/alvher

Re: [PATCHES] build infrastructure for extensions v3

Peter Eisentraut <[EMAIL PROTECTED]> writes: > ISTM that this version still does not allow building contrib without > having installed pg_config first. That is a no-no. Sounds like the list of objections is getting shorter anyway ;-). Do you feel that this patch is going in basically the right

Re: [PATCHES] [HACKERS] Configuration patch

I have applied the non-"include" parts of this patch, which allows the configuration files to exist outside the data directory. I have added a TODO: * Add include functionality to postgresql.conf Patch attached and applied. It still needs more documentation. Right now only the postmast

Re: [PATCHES] [HACKERS] Configuration patch

Oh, also, I was not able to put a name on the patch because I only have a 'pgsql' email address for the submitter. Hope that is OK. --- [EMAIL PROTECTED] wrote: > > Bruce Momjian <[EMAIL PROTECTED]> writes: > >>> This patch

Re: [PATCHES] nested xacts and phantom Xids

Added to TODO, just so we don't forget later: * Use a phantom command counter for nested subtransactions to reduce tuple overhead --- Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > Hmm .

Re: [PATCHES] [pgsql-hackers-win32] Re : Win32 binaries test / pg_dump problem

OK, the attached applied patch opens text files in binary mode in psql. As you said, it already handles CRLF OK, and we need this to read control-Z in copy files. I assume we can write control-Z in text mode just fine, right? -

Re: [PATCHES] Updated ALTER TABLE ... SET TABLESPACE patch

I realize this still need WAL work, but we should get this in. Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches I will try to apply it within the next 48 hours. ---

Re: [PATCHES] [pgsql-hackers-win32] Data directory with trailing [back]slash

OK, I have fixed the problem. While your patch got close, it is best to fix the problem in trim_trailing_separator() rather than above. Tom already fixed the Unix case by preventing a path of '/' from being stripped. This patch prevents c:/ and //network/ from being stripped too. (Tom already

Re: [PATCHES] pg_dump --clean w/ <= 7.2 server

Where are we on this? --- Tom Lane wrote: > Kris Jurka <[EMAIL PROTECTED]> writes: > >> Possibly the most correct solution is to assign the name "public" to the > >> dummy schema that pg_dump creates internally when talking

Re: [PATCHES] OWNER TO mega patch #2

Already been applied by Tom, Bruce. Chris Bruce Momjian wrote: Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches I will try to apply it within the next 48 hours.