Re: [PATCHES] Patch for pg_dump: Multiple -t options and new -T option

2004-07-20 Thread Christopher Kings-Lynne
Yes, the reason it would be nice for me is that currently if you want to dump two specific, related tables from your db, there's no way to do it with pg_dump within the one transactions (ie. maintaining integrity). I guess I'm in favour of -t -t but not -T depending on the complexity of it.

Re: [PATCHES] Patch for pg_dump: Multiple -t options and new -T option

2004-07-20 Thread Andrew Dunstan
Tom Lane said: Christopher Kings-Lynne [EMAIL PROTECTED] writes: Well, I guess I'm against it based on the rules of feature freeze, even though it would be really useful for me :( It would have been a lot easier to approve it if it'd arrived on June 30 rather than July 6 :-(. However,

Re: [PATCHES] Patch for pg_dump: Multiple -t options and new -T option

2004-07-20 Thread Tom Lane
Christopher Kings-Lynne [EMAIL PROTECTED] writes: One problem with this patch is that there's no way to dump multiple tables in different schemas. Does this matter? It's a bit non-orthogonal... Yeah. With the combination of -n and -t you can pull a specific table, but as soon as you allow

Re: [PATCHES] Patch for pg_dump: Multiple -t options and new -T

2004-07-20 Thread David F. Skoll
On Tue, 20 Jul 2004, Tom Lane wrote: (BTW, does the patch handle multiple -n switches?) No, it doesn't. I can look into that if you like. The patch was entirely to satisfy a need some of our customers have. The -T switch does fill a real need for our customers; our product has a couple of

[PATCHES] plperl return single composite

2004-07-20 Thread Andrew Dunstan
The attached patch allows 'select foo()' as well as 'select * from foo()' where foo() is a plperl function that returns a single composite. cheers andrew Index: plperl.c === RCS file:

Re: [PATCHES] logfile subprocess and Fancy File Functions

2004-07-20 Thread Andreas Pflug
Bruce Momjian wrote: Andreas Pflug wrote: Very nice. You did a nice trick of reading the log filenames into a timestamp field: count = sscanf(de-d_name, %04d-%02d-%02d_%02d%02d%02d_%05d.log, yea$ You only process files that match that pattern for pg_logfiles_ls() (perhaps this should be

Re: [PATCHES] logfile subprocess and Fancy File Functions

2004-07-20 Thread Bruce Momjian
Andreas Pflug wrote: process the timestamp field in queries. Good idea. What happens if a filename matches the above pattern but isn't a valid timestamp? Does the function fail? Right now, BuildTupleFromCString will fail for invalid timestamps. I'm going to change that to pgsql's

Re: [PATCHES] [HACKERS] Point in Time Recovery

2004-07-20 Thread Klaus Naumann
On Tue, 20 Jul 2004 [EMAIL PROTECTED] wrote: FATAL: unrecognized configuration parameter archive_mode Have I missed something since it has been committed? Yes, Tom has removed this option in favorite of just setting archive_command to a value which then enables the PITR code also. But as

Re: [PATCHES] logfile subprocess and Fancy File Functions

2004-07-20 Thread Peter Eisentraut
Andreas Pflug wrote: How should the prefix be named? pgsql_ ? Make the file names configurable. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 6: Have you searched our list archives?

Re: [PATCHES] logfile subprocess and Fancy File Functions

2004-07-20 Thread Bruce Momjian
Peter Eisentraut wrote: Bruce Momjian wrote: Peter Eisentraut wrote: Andreas Pflug wrote: How should the prefix be named? pgsql_ ? Make the file names configurable. He has code to interpret the file names as timestamps that can be used in queries. If we allowed full user

Re: [PATCHES] logfile subprocess and Fancy File Functions

2004-07-20 Thread Peter Eisentraut
Bruce Momjian wrote: Peter Eisentraut wrote: Andreas Pflug wrote: How should the prefix be named? pgsql_ ? Make the file names configurable. He has code to interpret the file names as timestamps that can be used in queries. If we allowed full user control over the file name, he

Re: [PATCHES] [HACKERS] Point in Time Recovery

2004-07-20 Thread Simon Riggs
On Tue, 2004-07-20 at 17:29, Klaus Naumann wrote: On Tue, 20 Jul 2004 [EMAIL PROTECTED] wrote: FATAL: unrecognized configuration parameter archive_mode Have I missed something since it has been committed? Yes, Tom has removed this option in favorite of just setting archive_command to

Re: [PATCHES] logfile subprocess and Fancy File Functions

2004-07-20 Thread Andreas Pflug
Bruce Momjian wrote: Peter Eisentraut wrote: Bruce Momjian wrote: Peter Eisentraut wrote: Andreas Pflug wrote: How should the prefix be named? pgsql_ ? Make the file names configurable. He has code to interpret the file names as timestamps that can be used in queries. If we allowed full user

Re: [PATCHES] logfile subprocess and Fancy File Functions

2004-07-20 Thread Peter Eisentraut
Andreas Pflug wrote: Apparently it's best to invent a log_file_prefix = 'pgsql_' guc variable. In any case, the prefix postgresql- is more in line with current practice. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of

Re: [PATCHES] logfile subprocess and Fancy File Functions

2004-07-20 Thread Bruce Momjian
Peter Eisentraut wrote: Andreas Pflug wrote: Apparently it's best to invent a log_file_prefix = 'pgsql_' guc variable. In any case, the prefix postgresql- is more in line with current practice. For logs I think pgsql_ is best because that filename is already going to be long, and I

[PATCHES] pg_config

2004-07-20 Thread Andrew Dunstan
Peter Eisentraut wrote: Andrew Dunstan wrote: To that extent is it not broken by relocated installations that we have now made some provision for? Well, then it should be fixed to take relocated installations into account. Relocatable installations are by nature a pretty broken feature.

Re: [PATCHES] win32 readline

2004-07-20 Thread Bruce Momjian
Magnus Hagander wrote: Readline is pretty badly broken under mingw. Basically, it disables the alt-gr key, which renders psql almost useless on most locales (no way to type backslash, and a whole lot of other characters, for example). This patch disables readline on win32. (meaning it's back

Re: [PATCHES] win32 readline

2004-07-20 Thread Peter Eisentraut
Magnus Hagander wrote: Readline is pretty badly broken under mingw. Basically, it disables the alt-gr key, which renders psql almost useless on most locales (no way to type backslash, and a whole lot of other characters, for example). I can't reproduce that. It works perfectly fine here. --

Re: [PATCHES] [HACKERS] Point in Time Recovery

2004-07-20 Thread Mark Kirkwood
I'd vote for it as a clarity factor too. Klaus Naumann wrote: On Tue, 20 Jul 2004 [EMAIL PROTECTED] wrote: FATAL: unrecognized configuration parameter archive_mode Have I missed something since it has been committed? Yes, Tom has removed this option in favorite of just setting

Re: [PATCHES] FAQ_MSWIN patch

2004-07-20 Thread Bruce Momjian
Patch applied. Thanks. --- Jason Tishler wrote: As per the following: http://archives.postgresql.org/pgsql-cygwin/2004-07/msg00090.php Thanks, Jason -- PGP/GPG Key: http://www.tishler.net/jason/pubkey.asc

Re: [PATCHES] Patch for pg_dump: Multiple -t options and new -T option

2004-07-20 Thread Bruce Momjian
David F. Skoll wrote: On Tue, 20 Jul 2004, Tom Lane wrote: (BTW, does the patch handle multiple -n switches?) No, it doesn't. I can look into that if you like. The patch was entirely to satisfy a need some of our customers have. The -T switch does fill a real need for our customers;

Re: [PATCHES] win32 readline

2004-07-20 Thread Bruce Momjian
Peter Eisentraut wrote: Magnus Hagander wrote: Readline is pretty badly broken under mingw. Basically, it disables the alt-gr key, which renders psql almost useless on most locales (no way to type backslash, and a whole lot of other characters, for example). I can't reproduce that. It

Re: [PATCHES] logfile subprocess and Fancy File Functions

2004-07-20 Thread Bruce Momjian
Andreas Pflug wrote: I wasn't talking about what looks best, I was talking about current practice for log files. From that you might be able to extrapolate what other people have previously found to look best. In any case, we're not using DOS and 12 inch monitors any more. File

Re: [PATCHES] win32 readline

2004-07-20 Thread Mark Kirkwood
To add to the confusion it works for me as well - Windows 2003 with Mingw 3.1.0 Peter Eisentraut wrote: Magnus Hagander wrote: Readline is pretty badly broken under mingw. Basically, it disables the alt-gr key, which renders psql almost useless on most locales (no way to type backslash, and

Re: [PATCHES] logfile subprocess and Fancy File Functions

2004-07-20 Thread Bruce Momjian
Andreas Pflug wrote: Peter Eisentraut wrote: Bruce Momjian wrote: For logs I think pgsql_ is best because that filename is already going to be long, and I don't usually like dashes in file names. They look too much like arguments, but tarballs use them and it looks OK there, I guess.

Re: [PATCHES] Patch for pg_dump: Multiple -t options and new -T option

2004-07-20 Thread Christopher Kings-Lynne
No, it doesn't. I can look into that if you like. The patch was entirely to satisfy a need some of our customers have. The -T switch does fill a real need for our customers; our product has a couple of tables that aren't critical if they aren't backed up, but as the product evolves, we

Re: [PATCHES] [HACKERS] Point in Time Recovery

2004-07-20 Thread Christopher Kings-Lynne
I'm in favour of how it is now, so long as the comment is clear. It's the Unix Way :) Chris I'd vote for it as a clarity factor too. Klaus Naumann wrote: On Tue, 20 Jul 2004 [EMAIL PROTECTED] wrote: FATAL: unrecognized configuration parameter archive_mode Have I missed something since it

Re: [PATCHES] Patch for pg_dump: Multiple -t options and new -T

2004-07-20 Thread Gavin Sherry
On Wed, 21 Jul 2004, Christopher Kings-Lynne wrote: No, it doesn't. I can look into that if you like. The patch was entirely to satisfy a need some of our customers have. The -T switch does fill a real need for our customers; our product has a couple of tables that aren't critical if

Re: [PATCHES] Patch for pg_dump: Multiple -t options and new -T option

2004-07-20 Thread Bruce Momjian
Gavin Sherry wrote: On Wed, 21 Jul 2004, Christopher Kings-Lynne wrote: No, it doesn't. I can look into that if you like. The patch was entirely to satisfy a need some of our customers have. The -T switch does fill a real need for our customers; our product has a couple of tables

Re: [PATCHES] logfile subprocess and Fancy File Functions

2004-07-20 Thread Bruce Momjian
Andreas Pflug wrote: Before the thread concentrates too much on a decent default value, I'm posting a fresh version of the patch, for some more discussion. Current default for pg_logfile_prefix is 'postgresql-', may the committers decide which name is The Perfect One. All previous

Re: [PATCHES] Patch for pg_dump: Multiple -t options and new -T option

2004-07-20 Thread Bruce Momjian
Philip Warner wrote: At 12:59 PM 21/07/2004, Bruce Momjian wrote: Yes, no need for it. We discourage that. Might be polite, not to mention legally required, to check with the author of the patch first. To be clear, we will ask the author if we can remove it, and if they say no, we will

Re: [PATCHES] Patch for pg_dump: Multiple -t options and new

2004-07-20 Thread Philip Warner
At 12:59 PM 21/07/2004, Bruce Momjian wrote: Yes, no need for it. We discourage that. Might be polite, not to mention legally required, to check with the author of the patch first. Philip Warner| __---_

Re: [PATCHES] [HACKERS] Point in Time Recovery

2004-07-20 Thread Tom Lane
Simon Riggs [EMAIL PROTECTED] writes: A more important omission is the deletion of a message to indicate that the server is acting in archive_modeso there's no visual clue in the log to warn an admin that its been turned off now or incorrectly specified (by somebody else, of course). (At